You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/15 10:32:05 UTC
[GitHub] [pulsar] codelipenghui commented on a change in pull request #10243: [Issue 9204][Python/C++]Expose replicateSubscriptionState setting for python/c++ consumer
codelipenghui commented on a change in pull request #10243:
URL: https://github.com/apache/pulsar/pull/10243#discussion_r613953050
##########
File path: pulsar-client-cpp/lib/ConsumerConfiguration.cc
##########
@@ -163,6 +163,14 @@ void ConsumerConfiguration::setPatternAutoDiscoveryPeriod(int periodInSeconds) {
int ConsumerConfiguration::getPatternAutoDiscoveryPeriod() const { return impl_->patternAutoDiscoveryPeriod; }
+void ConsumerConfiguration::setReplicateSubscriptionState(bool replicateSubscriptionState) {
Review comment:
```suggestion
void ConsumerConfiguration::setReplicateSubscriptionStateEnabled(bool enabled) {
```
##########
File path: pulsar-client-cpp/lib/ConsumerConfiguration.cc
##########
@@ -163,6 +163,14 @@ void ConsumerConfiguration::setPatternAutoDiscoveryPeriod(int periodInSeconds) {
int ConsumerConfiguration::getPatternAutoDiscoveryPeriod() const { return impl_->patternAutoDiscoveryPeriod; }
+void ConsumerConfiguration::setReplicateSubscriptionState(bool replicateSubscriptionState) {
+ impl_->replicateSubscriptionState = replicateSubscriptionState;
+}
+
+bool ConsumerConfiguration::getReplicateSubscriptionState() const {
Review comment:
```suggestion
bool ConsumerConfiguration::isReplicateSubscriptionStateEnabled() const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org