You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/08/18 16:28:06 UTC
[GitHub] [bookkeeper] tisonkun opened a new pull request, #3449: Bump grpcio dep version of Python client for supporting ARM
tisonkun opened a new pull request, #3449:
URL: https://github.com/apache/bookkeeper/pull/3449
Reference:
* https://github.com/apache/bookkeeper/pull/2432
* https://github.com/apache/pulsar/issues/7477
* https://github.com/grpc/grpc/pull/25418
* https://github.com/apache/pulsar/discussions/17166#discussioncomment-3424343
In the previous PR https://github.com/apache/bookkeeper/pull/2432 we "release" the version range instead of requiring a minimal version. It seems incorrect and if we'd like to support M1, it seems at least 1.37 is required. Send this patch for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] merlimat commented on pull request #3449: Bump grpcio dep version of Python client for supporting ARM
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat commented on PR #3449:
URL: https://github.com/apache/bookkeeper/pull/3449#issuecomment-1515063624
@tisonkun I think we should re-open this, and move to newer Grpc. Otherwise the Pulsar Python client is still stuck with unsupported Grpc version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] tisonkun commented on a diff in pull request #3449: Bump grpcio dep version of Python client for supporting ARM
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #3449:
URL: https://github.com/apache/bookkeeper/pull/3449#discussion_r949717085
##########
stream/clients/python/setup.py:
##########
@@ -31,7 +31,7 @@
'six>=1.10.0',
'pytz',
'futures>=3.2.0;python_version<"3.2"',
- 'grpcio<1.28,>=1.8.2',
+ 'grpcio>=1.37',
Review Comment:
Thank you! I threw the change here to see if it breaks anything. To prepare a solid patch I need more time to understand the mechanism and see how to verify the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] tisonkun closed pull request #3449: Bump grpcio dep version of Python client for supporting ARM
Posted by GitBox <gi...@apache.org>.
tisonkun closed pull request #3449: Bump grpcio dep version of Python client for supporting ARM
URL: https://github.com/apache/bookkeeper/pull/3449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on a diff in pull request #3449: Bump grpcio dep version of Python client for supporting ARM
Posted by GitBox <gi...@apache.org>.
eolivelli commented on code in PR #3449:
URL: https://github.com/apache/bookkeeper/pull/3449#discussion_r949422949
##########
stream/clients/python/setup.py:
##########
@@ -31,7 +31,7 @@
'six>=1.10.0',
'pytz',
'futures>=3.2.0;python_version<"3.2"',
- 'grpcio<1.28,>=1.8.2',
+ 'grpcio>=1.37',
Review Comment:
My understanding is that we have to put a cap here otherwise auto upgrades may break the client.
IIRC it happened in the past.
I I am mot sure that we have CI that is covering this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] tisonkun commented on pull request #3449: Bump grpcio dep version of Python client for supporting ARM
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #3449:
URL: https://github.com/apache/bookkeeper/pull/3449#issuecomment-1220133096
Closed for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] merlimat commented on pull request #3449: Bump grpcio dep version of Python client for supporting ARM
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat commented on PR #3449:
URL: https://github.com/apache/bookkeeper/pull/3449#issuecomment-1515065258
My bad, this was already addressed in #3875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org