[jira] [Commented] (AMBARI-18415) Stack definition: service component 'cardinality' inheritance not working properly

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-18415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15503465#comment-15503465 ] 

Hadoop QA commented on AMBARI-18415:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12829179/AMBARI-18415.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The test build failed in ambari-server 

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/8693//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/8693//console

This message is automatically generated.

> Stack definition: service component 'cardinality' inheritance not working properly
> ----------------------------------------------------------------------------------
>
>                 Key: AMBARI-18415
>                 URL: https://issues.apache.org/jira/browse/AMBARI-18415
>             Project: Ambari
>          Issue Type: Bug
>            Reporter: Andrew Onischuk
>            Assignee: Andrew Onischuk
>             Fix For: 2.5.0
>
>         Attachments: AMBARI-18415.patch
>
>
> In the stack definition if a property of service component is not defined in
> one specific version than it will be inherited from the parent version.
> The `ComponentInfo.cardinality` always has a default value of "0+" from the
> moment the object is instantiated thus the inheritance logic is never applied.
> This leads to if a specific version of a service component doesn't have a
> property set in stack definition it won't inherit it from its parent but
> rather will take the "0+" default value.
> This is not the correct behaviour. First the inheritance should be applied and
> only set `cardinality` to "0+" only if it can't be inherited from the parents
> (as it's not defined in any of the parents up in the inheritance chain)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)