You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kibble.apache.org by GitBox <gi...@apache.org> on 2021/03/03 15:19:36 UTC

[GitHub] [kibble] turbaszek opened a new pull request #6: Add codeowners for automate reviewer assignment

turbaszek opened a new pull request #6:
URL: https://github.com/apache/kibble/pull/6


   > Code owners are automatically requested for review when someone opens a pull request that modifies code that they own. 
   https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners
   
   I think we may try this feature. Currently contributors are not able to request review (unless they ping a committer). 
   
   I tried to create some basic rules but I'm happy to get any suggestions!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kibble] turbaszek commented on a change in pull request #6: Add codeowners for automate reviewer assignment

Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #6:
URL: https://github.com/apache/kibble/pull/6#discussion_r589377509



##########
File path: .github/CODEOWNERS
##########
@@ -0,0 +1,8 @@
+# All repo
+* @turbaszek

Review comment:
       ```suggestion
   * @turbaszek @michalslowikowski00
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kibble] turbaszek commented on a change in pull request #6: Add codeowners for automate reviewer assignment

Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #6:
URL: https://github.com/apache/kibble/pull/6#discussion_r586507416



##########
File path: .github/CODEOWNERS
##########
@@ -0,0 +1,8 @@
+# All repo
+* @turbaszek

Review comment:
       I did not added all committers because not everyone may want to get updates. Let me know if I should add you




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kibble] michalslowikowski00 commented on a change in pull request #6: Add codeowners for automate reviewer assignment

Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on a change in pull request #6:
URL: https://github.com/apache/kibble/pull/6#discussion_r589016692



##########
File path: .github/CODEOWNERS
##########
@@ -0,0 +1,8 @@
+# All repo
+* @turbaszek

Review comment:
       I will do my best to support. Please add me as well, Tomek.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kibble] turbaszek merged pull request #6: Add codeowners for automate reviewer assignment

Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #6:
URL: https://github.com/apache/kibble/pull/6


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kibble] sharanf commented on a change in pull request #6: Add codeowners for automate reviewer assignment

Posted by GitBox <gi...@apache.org>.
sharanf commented on a change in pull request #6:
URL: https://github.com/apache/kibble/pull/6#discussion_r588858491



##########
File path: .github/CODEOWNERS
##########
@@ -0,0 +1,8 @@
+# All repo
+* @turbaszek

Review comment:
       I'm happy to manage the items you put me down for :-) 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org