[GitHub] [doris] JNSimba commented on a diff in pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc

["JNSimba (via GitHub)" <gi...@apache.org>]

JNSimba commented on code in PR #20647:
URL: https://github.com/apache/doris/pull/20647#discussion_r1233067854


##########
fe/fe-core/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java:
##########
@@ -196,6 +198,9 @@ public void preCommitTransaction2PC(Database db, List<Table> tableList, long tra
         } finally {
             MetaLockUtils.writeUnlockTables(tableList);
         }
+        stopWatch.stop();
+        LOG.info("stream load tasks are pre-committed successfully. txns: {}. time cost: {} ms."
+                + " data will be visible later.", transactionId, stopWatch.getTime());

Review Comment:
   `data will be visible later.` May be ambiguous? Because it is in the precommit stage, unless the commit is actively triggered.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org