You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2021/11/06 04:37:43 UTC
[GitHub] [struts] JCgH4164838Gh792C124B5 opened a new pull request #501: WW-5124 - Proposed fix for Struts JSP tag behaviour with tag pooling (re-target to 2.6.x)
JCgH4164838Gh792C124B5 opened a new pull request #501:
URL: https://github.com/apache/struts/pull/501
Hello Apache Struts Team.
This PR is a re-target of PR #489 aiming the equivalent changes to the 2.6.x main branch (hopefully the cherry-picks and subsequent cleanup are OK). Please see the original PR for background and discussion details.
This PR attempts to add logic to call cleanup in the `release()` method for the Tag handler as well, but otherwise should be equivalent to the original PR for 2.5.x.
There may be a better strategy/design to consider instead, but at least it provides a starting point. Please let me know if anyone can see a cleaner solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts] yasserzamani commented on pull request #501: WW-5124 - Proposed fix for Struts JSP tag behaviour with tag pooling (re-target to 2.6.x)
Posted by GitBox <gi...@apache.org>.
yasserzamani commented on pull request #501:
URL: https://github.com/apache/struts/pull/501#issuecomment-983330954
thank you @JCgH4164838Gh792C124B5 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] yasserzamani merged pull request #501: WW-5124 - Proposed fix for Struts JSP tag behaviour with tag pooling (re-target to 2.6.x)
Posted by GitBox <gi...@apache.org>.
yasserzamani merged pull request #501:
URL: https://github.com/apache/struts/pull/501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts] JCgH4164838Gh792C124B5 commented on pull request #501: WW-5124 - Proposed fix for Struts JSP tag behaviour with tag pooling (re-target to 2.6.x)
Posted by GitBox <gi...@apache.org>.
JCgH4164838Gh792C124B5 commented on pull request #501:
URL: https://github.com/apache/struts/pull/501#issuecomment-981256661
Hi. The branch has been updated to resolve the merge conflicts. If anything looks wrong, just let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] yasserzamani commented on pull request #501: WW-5124 - Proposed fix for Struts JSP tag behaviour with tag pooling (re-target to 2.6.x)
Posted by GitBox <gi...@apache.org>.
yasserzamani commented on pull request #501:
URL: https://github.com/apache/struts/pull/501#issuecomment-978161147
Thanks a lot @JCgH4164838Gh792C124B5 LGTM :+1: as well. And apologize in advance that my merge has caused a small conflict here, sorry didn't know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] lukaszlenart commented on pull request #501: WW-5124 - Proposed fix for Struts JSP tag behaviour with tag pooling (re-target to 2.6.x)
Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on pull request #501:
URL: https://github.com/apache/struts/pull/501#issuecomment-978882326
@JCgH4164838Gh792C124B5 conflictes have appeared after merging Yasser's changes, could you update your branch? Thanks a lot! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] JCgH4164838Gh792C124B5 commented on pull request #501: WW-5124 - Proposed fix for Struts JSP tag behaviour with tag pooling (re-target to 2.6.x)
Posted by GitBox <gi...@apache.org>.
JCgH4164838Gh792C124B5 commented on pull request #501:
URL: https://github.com/apache/struts/pull/501#issuecomment-980793723
Hi @lukaszlenart and @yasserzamani . Thanks for the heads-up about the conflicts. I will attempt to resolve the conflicts locally (hopefully soon), and push a new commit with any changes that are needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] coveralls edited a comment on pull request #501: WW-5124 - Proposed fix for Struts JSP tag behaviour with tag pooling (re-target to 2.6.x)
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #501:
URL: https://github.com/apache/struts/pull/501#issuecomment-962400936
[](https://coveralls.io/builds/44587417)
Coverage increased (+0.6%) to 50.509% when pulling **e1167d42beefa26686b31e797179f0c396930ac8 on JCgH4164838Gh792C124B5:localS2_26_WW-5124_fix** into **b2bfdc5c88a13e82d647e7ae836089a12ce001fe on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] coveralls commented on pull request #501: WW-5124 - Proposed fix for Struts JSP tag behaviour with tag pooling (re-target to 2.6.x)
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #501:
URL: https://github.com/apache/struts/pull/501#issuecomment-962400936
[](https://coveralls.io/builds/44063680)
Coverage decreased (-0.3%) to 50.33% when pulling **ac6749617f4ce1d846bbc816e32f647d18fcc6fc on JCgH4164838Gh792C124B5:localS2_26_WW-5124_fix** into **a368cb632895e689f81ec59868b28bbf033d9ef8 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] JCgH4164838Gh792C124B5 commented on pull request #501: WW-5124 - Proposed fix for Struts JSP tag behaviour with tag pooling (re-target to 2.6.x)
Posted by GitBox <gi...@apache.org>.
JCgH4164838Gh792C124B5 commented on pull request #501:
URL: https://github.com/apache/struts/pull/501#issuecomment-966780197
The latest update attempts to improve test coverage a bit (in response to the coveralls report), but to do so it also had to merge recent mainline changes, due to conflicts.
During this activity, it was discovered that the `DateTextFieldTag` may not be functional anymore. If that is true, then maybe it should be corrected or dropped at a later date.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] coveralls edited a comment on pull request #501: WW-5124 - Proposed fix for Struts JSP tag behaviour with tag pooling (re-target to 2.6.x)
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #501:
URL: https://github.com/apache/struts/pull/501#issuecomment-962400936
[](https://coveralls.io/builds/44213098)
Coverage increased (+0.6%) to 50.387% when pulling **f36c7678c5cdd04614a9c3a0090d15350714f4af on JCgH4164838Gh792C124B5:localS2_26_WW-5124_fix** into **76bbe60a78b2b47fcb961f85d3db9971d85fc2d1 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org