You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by ak...@apache.org on 2004/03/01 18:49:52 UTC
cvs commit: httpd-2.0 libhttpd.dsp
ake 2004/03/01 09:49:52
Modified: . libhttpd.dsp
Log:
add eoc_bucket.c to project
Revision Changes Path
1.61 +5 -1 httpd-2.0/libhttpd.dsp
Index: libhttpd.dsp
===================================================================
RCS file: /home/cvs/httpd-2.0/libhttpd.dsp,v
retrieving revision 1.60
retrieving revision 1.61
diff -u -r1.60 -r1.61
--- libhttpd.dsp 11 Mar 2003 00:58:45 -0000 1.60
+++ libhttpd.dsp 1 Mar 2004 17:49:52 -0000 1.61
@@ -53,7 +53,7 @@
# ADD BSC32 /nologo
LINK32=link.exe
# ADD BASE LINK32 kernel32.lib user32.lib advapi32.lib ws2_32.lib mswsock.lib /nologo /subsystem:windows /dll /machine:I386
-# ADD LINK32 kernel32.lib user32.lib advapi32.lib ws2_32.lib mswsock.lib "Release\buildmark.obj" /nologo /subsystem:windows /dll /incremental:no /debug /machine:I386 /base:@"os\win32\BaseAddr.ref",libhttpd.dll /opt:ref
+# ADD LINK32 kernel32.lib user32.lib advapi32.lib ws2_32.lib mswsock.lib "Release\buildmark.obj" /nologo /subsystem:windows /dll /debug /machine:I386 /base:@"os\win32\BaseAddr.ref",libhttpd.dll /opt:ref
# Begin Special Build Tool
SOURCE="$(InputPath)"
PreLink_Desc=Compiling buildmark
@@ -399,6 +399,10 @@
# Begin Group "util"
# PROP Default_Filter ""
+# Begin Source File
+
+SOURCE=.\server\eoc_bucket.c
+# End Source File
# Begin Source File
SOURCE=.\server\error_bucket.c
Re: cvs commit: httpd-2.0 libhttpd.dsp
Posted by Greg Marr <gr...@alum.wpi.edu>.
At 01:33 PM 3/4/2004, William A. Rowe, Jr. wrote:
>At 12:04 PM 3/4/2004, Greg Marr wrote:
> >At 12:00 PM 3/4/2004, William A. Rowe, Jr. wrote:
> >>At 09:55 AM 3/4/2004, Greg Marr wrote:
> >>
> >>>/incremental:no is the default, and MSDev will at times remove
> flags that it finds redundant, even ones that it added
> itself. It's a bit schizophrenic like that.
> >>
> >>uhmmmm wrong. with /debug incremental yes is the default but you
> have
> >>to pound it into the msdev's head. please fix/revert.
> >>
> >>>>> -# ... /dll /incremental:no /debug /machine:I386
> /base:@"os\win32\BaseAddr.ref",libhttpd.dll /opt:ref
> >>>>> +# ... /dll /debug /machine:I386
> /base:@"os\win32\BaseAddr.ref",libhttpd.dll /opt:ref
> >>>>...
> >
> >Odd, I thought non-incremental was the default, but the help says
> otherwise. Incremental is the default, for regular and debug, at
> least in VC6.
> >
> >Why would you not want incremental for a debug build anyway?
>
>Greg we are creating the release build there - we create a pdb for
>unwinding core dumps.
Oh, duh. Yeah.
>It is an optimized binary - incremental is not a healthy way to
>release a final image. Again, please revert.
I would if I could... I was just commenting on why I thought it
happened.
RE: cvs commit: httpd-2.0 libhttpd.dsp
Posted by Sander Striker <st...@apache.org>.
> From: Allan Edwards [mailto:ake1@us.ibm.com]
> Sent: Friday, March 05, 2004 7:38 PM
> William A. Rowe, Jr. wrote:
> >>>uhmmmm wrong. with /debug incremental yes is the default but you have
> >>>to pound it into the msdev's head. please fix/revert.
> >>>
> >>>
> >>>>>> -# ... /dll /incremental:no /debug /machine:I386 /base:@"os\win32\BaseAddr.ref",libhttpd.dll /opt:ref
> >>>>>> +# ... /dll /debug /machine:I386 /base:@"os\win32\BaseAddr.ref",libhttpd.dll /opt:ref
>
> Looks like MSDEV fooness to me. I changed nothing in the project except
> adding the eoc file but I can't coax MSDEV into including /incremental:no
> in the dsp even though it *is* there in the Link Project Options box.
>
> Since I don't want to manually edit the generated file the only thing I can
> do is revert the checkin and let someone else (Bill?) add the eoc file back in.
I'll go and hand edit it then.
Sander
RE: cvs commit: httpd-2.0 libhttpd.dsp
Posted by Sander Striker <st...@apache.org>.
> From: William A. Rowe, Jr. [mailto:wrowe@rowe-clan.net]
> Sent: Friday, March 05, 2004 7:43 PM
> At 12:37 PM 3/5/2004, Allan Edwards wrote:
>
> >Looks like MSDEV fooness to me. I changed nothing in the project except
> >adding the eoc file but I can't coax MSDEV into including /incremental:no
> >in the dsp even though it *is* there in the Link Project Options box.
>
> this is why I always add sources (in alpha order as some DevStudio versions
> seem to prefer) by hand. Yes DevStudio is brain dead on this and other points.
You know, those python build system changes that went into apr
the other day... :)
Sander
Re: cvs commit: httpd-2.0 libhttpd.dsp
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
At 12:37 PM 3/5/2004, Allan Edwards wrote:
>Looks like MSDEV fooness to me. I changed nothing in the project except
>adding the eoc file but I can't coax MSDEV into including /incremental:no
>in the dsp even though it *is* there in the Link Project Options box.
this is why I always add sources (in alpha order as some DevStudio versions
seem to prefer) by hand. Yes DevStudio is brain dead on this and other points.
Bill
Re: cvs commit: httpd-2.0 libhttpd.dsp
Posted by Allan Edwards <ak...@us.ibm.com>.
William A. Rowe, Jr. wrote:
>>>uhmmmm wrong. with /debug incremental yes is the default but you have
>>>to pound it into the msdev's head. please fix/revert.
>>>
>>>
>>>>>> -# ... /dll /incremental:no /debug /machine:I386 /base:@"os\win32\BaseAddr.ref",libhttpd.dll /opt:ref
>>>>>> +# ... /dll /debug /machine:I386 /base:@"os\win32\BaseAddr.ref",libhttpd.dll /opt:ref
Looks like MSDEV fooness to me. I changed nothing in the project except
adding the eoc file but I can't coax MSDEV into including /incremental:no
in the dsp even though it *is* there in the Link Project Options box.
Since I don't want to manually edit the generated file the only thing I can
do is revert the checkin and let someone else (Bill?) add the eoc file back in.
Allan
Re: cvs commit: httpd-2.0 libhttpd.dsp
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
At 12:04 PM 3/4/2004, Greg Marr wrote:
>At 12:00 PM 3/4/2004, William A. Rowe, Jr. wrote:
>>At 09:55 AM 3/4/2004, Greg Marr wrote:
>>
>>>/incremental:no is the default, and MSDev will at times remove flags that it finds redundant, even ones that it added itself. It's a bit schizophrenic like that.
>>
>>uhmmmm wrong. with /debug incremental yes is the default but you have
>>to pound it into the msdev's head. please fix/revert.
>>
>>>>> -# ... /dll /incremental:no /debug /machine:I386 /base:@"os\win32\BaseAddr.ref",libhttpd.dll /opt:ref
>>>>> +# ... /dll /debug /machine:I386 /base:@"os\win32\BaseAddr.ref",libhttpd.dll /opt:ref
>>>>...
>
>Odd, I thought non-incremental was the default, but the help says otherwise. Incremental is the default, for regular and debug, at least in VC6.
>
>Why would you not want incremental for a debug build anyway?
Greg we are creating the release build there - we create a pdb for unwinding
core dumps. It is an optimized binary - incremental is not a healthy way
to release a final image. Again, please revert.
Bill
Re: cvs commit: httpd-2.0 libhttpd.dsp
Posted by Greg Marr <gr...@alum.wpi.edu>.
At 12:00 PM 3/4/2004, William A. Rowe, Jr. wrote:
>At 09:55 AM 3/4/2004, Greg Marr wrote:
>
> >/incremental:no is the default, and MSDev will at times remove
> flags that it finds redundant, even ones that it added
> itself. It's a bit schizophrenic like that.
>
>uhmmmm wrong. with /debug incremental yes is the default but you have
>to pound it into the msdev's head. please fix/revert.
>
> >>> -# ... /dll /incremental:no /debug /machine:I386
> /base:@"os\win32\BaseAddr.ref",libhttpd.dll /opt:ref
> >>> +# ... /dll /debug /machine:I386
> /base:@"os\win32\BaseAddr.ref",libhttpd.dll /opt:ref
> >>...
Odd, I thought non-incremental was the default, but the help says
otherwise. Incremental is the default, for regular and debug, at
least in VC6.
Why would you not want incremental for a debug build anyway?
Re: cvs commit: httpd-2.0 libhttpd.dsp
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
At 09:55 AM 3/4/2004, Greg Marr wrote:
>/incremental:no is the default, and MSDev will at times remove flags that it finds redundant, even ones that it added itself. It's a bit schizophrenic like that.
uhmmmm wrong. with /debug incremental yes is the default but you have
to pound it into the msdev's head. please fix/revert.
>>> -# ... /dll /incremental:no /debug /machine:I386 /base:@"os\win32\BaseAddr.ref",libhttpd.dll /opt:ref
>>> +# ... /dll /debug /machine:I386 /base:@"os\win32\BaseAddr.ref",libhttpd.dll /opt:ref
>>...
Re: cvs commit: httpd-2.0 libhttpd.dsp
Posted by Greg Marr <gr...@alum.wpi.edu>.
At 09:09 AM 3/4/2004, Joe Orton wrote:
>On Mon, Mar 01, 2004 at 05:49:52PM -0000, ake@apache.org wrote:
> > ake 2004/03/01 09:49:52
> >
> > Modified: . libhttpd.dsp
> > Log:
> > add eoc_bucket.c to project
>
>I'm not qualified to review Win32 changes but did you mean to remove
>/incremental:no from the linker flags here as well as adding
>eoc_bucket.c? Can you add this change to the list of changes to
>include
>in the EOC bucket backport if it is really OK to backport for 2.0?
/incremental:no is the default, and MSDev will at times remove flags
that it finds redundant, even ones that it added itself. It's a bit
schizophrenic like that.
> > -# ... /dll /incremental:no /debug /machine:I386
> /base:@"os\win32\BaseAddr.ref",libhttpd.dll /opt:ref
> > +# ... /dll /debug /machine:I386
> /base:@"os\win32\BaseAddr.ref",libhttpd.dll /opt:ref
>...
Re: cvs commit: httpd-2.0 libhttpd.dsp
Posted by Joe Orton <jo...@redhat.com>.
On Mon, Mar 01, 2004 at 05:49:52PM -0000, ake@apache.org wrote:
> ake 2004/03/01 09:49:52
>
> Modified: . libhttpd.dsp
> Log:
> add eoc_bucket.c to project
I'm not qualified to review Win32 changes but did you mean to remove
/incremental:no from the linker flags here as well as adding
eoc_bucket.c? Can you add this change to the list of changes to include
in the EOC bucket backport if it is really OK to backport for 2.0?
> -# ... /dll /incremental:no /debug /machine:I386 /base:@"os\win32\BaseAddr.ref",libhttpd.dll /opt:ref
> +# ... /dll /debug /machine:I386 /base:@"os\win32\BaseAddr.ref",libhttpd.dll /opt:ref
...