You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Christian Grobmeier <gr...@gmail.com> on 2012/12/25 12:59:51 UTC
[VOTE] Release Onami Parent 1 RC2
Hi all,
This is a call for a vote on releasing the following candidate as
Apache Onami parent 1-incubating. This will be our first release.
Improvements over RC1:
* Created a source artifact including the pom + LICENSE and DISCLAIMER files
Artifacts are on Nexus:
https://repository.apache.org/content/repositories/orgapacheonami-066
SVN Tag:
http://svn.apache.org/repos/asf/incubator/onami/tags/org.apache.onami.parent-1-incubating/
The vote is open for 72 at least hours and is closing ~ on December
28th, 13:00pm GMT*.
The Onami Podling has successfully voted with 7 +1 from:
* Daniel Manzke
* Simone Tripodi
* Mohamma Nour El-Din (IPMC)
* Jordi Gerona
* Olivier Lamy (IPMC)
* Ioannis Canellos
* Christian Grobmeier (IPMC)
We are aware that our artifact needs to go to /dist, even when it is
just useful for Maven.
Please cast your votes:
[ ] +1 release it
[ ] +0 go ahead, but ...
[ ] -0 uhm...
[ ] -1 don't release it, because...
Thanks,
Christian
--
http://www.grobmeier.de
https://www.timeandbill.de
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Onami Parent 1 RC2
Posted by Marcel Offermans <ma...@luminis.nl>.
Hello Simone,
In general I'm always sceptical when people point at old releases and say "this must be okay because X did it like this as well". However, in this case I agree that there are many packagers that put in an extra folder in their source archive and put those files there.
So:
+1 for me
Regarding the extra copyright notice. I'm not a lawyer, I just think it does not belong there. No showstopper as far as I'm concerned, but I would remove it for the next release.
Greetings, Marcel
On Dec 27, 2012, at 11:06 , Simone Tripodi <si...@apache.org> wrote:
> Salut Marcel/all,
>
>> So either all of these packages are "wrong" or it seems it is
>> acceptable usage. Actually I think it is fine: it is the only folder
>> which becomes extracted for me everything inside this folder is
>> "root".
>
> +1, and I'd invite you reconsidering to change the -1 vote to a +1:
> inspecting the org.apache:apache:12 it clearly shows the same
> structure of org.apache.onami:org.apache.onami.parent:1-incubating
>
> * with unzip:
>
> $ unzip -l apache-12-source-release.zip
> Archive: apache-12-source-release.zip
> Length Date Time Name
> -------- ---- ---- ----
> 0 11-01-12 22:57 apache-12/
> 0 11-01-12 22:57 apache-12/src/
> 0 11-01-12 22:57 apache-12/src/site-docs/
> 0 11-01-12 22:57 apache-12/src/site-docs/apt/
> 15519 11-01-12 22:57 apache-12/pom.xml
> 2759 11-01-12 22:57 apache-12/site-pom.xml
> 6265 11-01-12 22:57 apache-12/src/site-docs/apt/index.apt
> 2233 11-01-12 22:57 apache-12/src/site-docs/site.xml
> 280 11-01-12 22:57 apache-12/DEPENDENCIES
> 11358 11-01-12 22:57 apache-12/LICENSE
> 182 11-01-12 22:57 apache-12/NOTICE
> -------- -------
> 38596 11 files
>
> * with jar:
>
> $ jar tf apache-12-source-release.zip
> apache-12/
> apache-12/src/
> apache-12/src/site-docs/
> apache-12/src/site-docs/apt/
> apache-12/pom.xml
> apache-12/site-pom.xml
> apache-12/src/site-docs/apt/index.apt
> apache-12/src/site-docs/site.xml
> apache-12/DEPENDENCIES
> apache-12/LICENSE
> apache-12/NOTICE
>
> moreover, the org.apache.onami:org.apache.onami.parent:1-incubating
> zip archive has built with the
> org.apache.apache.resources:apache-source-release-assembly-descriptor:1.0.4
> :)
>
>>> It should only be in the notice if Onami contains third-party software that requires you mention it [1]. Since this is code that was donated to Apache, I don't think that applies, so you should leave it out.
>>
>> Makes sense to me too. Do you consider it a blocker?
>
> It is not a blocker and should be tolerable/acceptable, since previous
> maintainers have already been mentioned in NOTICE file, see Any23's
> NOTICE[1].
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Onami Parent 1 RC2
Posted by Simone Tripodi <si...@apache.org>.
Salut Marcel/all,
> So either all of these packages are "wrong" or it seems it is
> acceptable usage. Actually I think it is fine: it is the only folder
> which becomes extracted for me everything inside this folder is
> "root".
+1, and I'd invite you reconsidering to change the -1 vote to a +1:
inspecting the org.apache:apache:12 it clearly shows the same
structure of org.apache.onami:org.apache.onami.parent:1-incubating
* with unzip:
$ unzip -l apache-12-source-release.zip
Archive: apache-12-source-release.zip
Length Date Time Name
-------- ---- ---- ----
0 11-01-12 22:57 apache-12/
0 11-01-12 22:57 apache-12/src/
0 11-01-12 22:57 apache-12/src/site-docs/
0 11-01-12 22:57 apache-12/src/site-docs/apt/
15519 11-01-12 22:57 apache-12/pom.xml
2759 11-01-12 22:57 apache-12/site-pom.xml
6265 11-01-12 22:57 apache-12/src/site-docs/apt/index.apt
2233 11-01-12 22:57 apache-12/src/site-docs/site.xml
280 11-01-12 22:57 apache-12/DEPENDENCIES
11358 11-01-12 22:57 apache-12/LICENSE
182 11-01-12 22:57 apache-12/NOTICE
-------- -------
38596 11 files
* with jar:
$ jar tf apache-12-source-release.zip
apache-12/
apache-12/src/
apache-12/src/site-docs/
apache-12/src/site-docs/apt/
apache-12/pom.xml
apache-12/site-pom.xml
apache-12/src/site-docs/apt/index.apt
apache-12/src/site-docs/site.xml
apache-12/DEPENDENCIES
apache-12/LICENSE
apache-12/NOTICE
moreover, the org.apache.onami:org.apache.onami.parent:1-incubating
zip archive has built with the
org.apache.apache.resources:apache-source-release-assembly-descriptor:1.0.4
:)
>> It should only be in the notice if Onami contains third-party software that requires you mention it [1]. Since this is code that was donated to Apache, I don't think that applies, so you should leave it out.
>
> Makes sense to me too. Do you consider it a blocker?
It is not a blocker and should be tolerable/acceptable, since previous
maintainers have already been mentioned in NOTICE file, see Any23's
NOTICE[1].
TIA!
-Simo
[1] http://svn.apache.org/repos/asf/any23/trunk/NOTICE.txt
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Onami Parent 1 RC2
Posted by Christian Grobmeier <gr...@gmail.com>.
Hi again,
thanks for your efforts! I appreciate it.
I now what you mean now, but I think its pretty normal. Please look at
what I did with Commons Compress:
$ java -classpath commons-compress-1.4.1.jar
org.apache.commons.compress.archivers.Lister
org.apache.felix.configadmin-1.6.0-source-release.zip
Analysing org.apache.felix.configadmin-1.6.0-source-release.zip
Created org.apache.commons.compress.archivers.zip.ZipArchiveInputStream@2e8f4fb3
org.apache.felix.configadmin-1.6.0/
org.apache.felix.configadmin-1.6.0/src/
org.apache.felix.configadmin-1.6.0/src/main/
org.apache.felix.configadmin-1.6.0/src/main/appended-resources/
org.apache.felix.configadmin-1.6.0/src/main/appended-resources/META-INF/
org.apache.felix.configadmin-1.6.0/src/main/java/
...
Felix configadmin does use the same format.
The binary of Commons Compress has it too:
$ java -classpath commons-compress-1.4.1.jar
org.apache.commons.compress.archivers.Lister
commons-compress-1.4.1-bin.zip
Analysing commons-compress-1.4.1-bin.zip
Created org.apache.commons.compress.archivers.zip.ZipArchiveInputStream@7bd63e39
commons-compress-1.4.1/
commons-compress-1.4.1/LICENSE.txt
commons-compress-1.4.1/NOTICE.txt
commons-compress-1.4.1/README.txt
commons-compress-1.4.1/RELEASE-NOTES.txt
commons-compress-1.4.1/commons-compress-1.4.1-tests.jar
commons-compress-1.4.1/commons-compress-1.4.1.jar
...
And of course the Apache Parent POM.
So either all of these packages are "wrong" or it seems it is
acceptable usage. Actually I think it is fine: it is the only folder
which becomes extracted for me everything inside this folder is
"root".
On Thu, Dec 27, 2012 at 8:41 AM, Marcel Offermans
<ma...@luminis.nl> wrote:
>>> A question about the contents of the NOTICE file, can you explain why you included the line:
>>> "Copyright 2010-2012 The 99 Software Foundation" ?
>>
>> hm I think the original package maintainer left this in the NOTICE
>> file. Before Onami came to the Incubator, it was maintained by "99
>> Software Foundation" (which is not really a registered foundation).
>> Most likely he thinks that the history should be kept in the NOTICE
>> file like we do sometimes with attributing people who donated a few
>> classes.
>
> It should only be in the notice if Onami contains third-party software that requires you mention it [1]. Since this is code that was donated to Apache, I don't think that applies, so you should leave it out.
Makes sense to me too. Do you consider it a blocker?
I looked at it as some kind of attribution, like here:
http://svn.apache.org/repos/asf/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStream.java
Or similar as to the discouraged @author tags.
Don't get me wrong, I am all for removing it and will discuss it on
dev list. I am just thinking if this should block the release or not.
Cheers
Christian
> Greetings, Marcel
>
> [1] http://apache.org/legal/resolved.html#required-third-party-notices
>
>
--
http://www.grobmeier.de
https://www.timeandbill.de
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Onami Parent 1 RC2
Posted by Branko Čibej <br...@apache.org>.
On 27.12.2012 08:41, Marcel Offermans wrote:
> Hello Christian,
>
> On Dec 26, 2012, at 11:05 AM, Christian Grobmeier <gr...@gmail.com> wrote:
>
>> Hi Marcel,
>>
>> On Wed, Dec 26, 2012 at 10:22 AM, Marcel Offermans
>> <ma...@luminis.nl> wrote:
>>> -1 Because: The release now is a ZIP file, and contains the NOTICE and LICENSE files, but they must be located at the root of the archive [1], and not in a subfolder like they are now.
>> For me they are in the root folder. It looks exactly as the Apache Parent:
>> https://repository.apache.org/content/repositories/releases/org/apache/apache/12/
>>
>> My package opens like this:
>>
>> $ tree .
>> .
>> ├── DEPENDENCIES
>> ├── DISCLAIMER
>> ├── LICENSE
>> ├── NOTICE
>> ├── pom.xml
>> └── src
>> └── site
>> └── site.xml
>>
>> Can you please tell me what you are seeing? I really don't get what you mean.
> This is what I am seeing:
>
> Marcels-MacBook-Pro:Downloads marcel$ unzip -l org.apache.onami.parent-1-incubating-source-release.zip
> Archive: org.apache.onami.parent-1-incubating-source-release.zip
> Length Date Time Name
> -------- ---- ---- ----
> 0 12-21-12 05:29 org.apache.onami.parent-1-incubating/
> 0 12-21-12 05:29 org.apache.onami.parent-1-incubating/src/
> 0 12-21-12 05:29 org.apache.onami.parent-1-incubating/src/site/
> 531 12-21-12 05:29 org.apache.onami.parent-1-incubating/DISCLAIMER
> 11357 12-21-12 05:29 org.apache.onami.parent-1-incubating/LICENSE
> 208 12-21-12 05:29 org.apache.onami.parent-1-incubating/NOTICE
> 29715 12-21-12 05:29 org.apache.onami.parent-1-incubating/pom.xml
> 4193 12-21-12 05:29 org.apache.onami.parent-1-incubating/src/site/site.xml
> 262 12-21-12 05:29 org.apache.onami.parent-1-incubating/DEPENDENCIES
> -------- -------
> 46266 9 files
This is clearly per spec. LICENSE, NOTICE, etc. are all at the root of
the source tree. Congrats to the packagers for making a ZIP file that
unpacks into a new subdirectory, instead of the all-to-common braindead
practice of unpacking into the current directory.
Marcel, I suppose you expected LICENSE and NOTICE to appear in ./ not
org.apache.onami.parent-1-incubating/, and that's what caused confusion?
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Onami Parent 1 RC2
Posted by Marcel Offermans <ma...@luminis.nl>.
Hello Christian,
On Dec 26, 2012, at 11:05 AM, Christian Grobmeier <gr...@gmail.com> wrote:
> Hi Marcel,
>
> On Wed, Dec 26, 2012 at 10:22 AM, Marcel Offermans
> <ma...@luminis.nl> wrote:
>> -1 Because: The release now is a ZIP file, and contains the NOTICE and LICENSE files, but they must be located at the root of the archive [1], and not in a subfolder like they are now.
>
> For me they are in the root folder. It looks exactly as the Apache Parent:
> https://repository.apache.org/content/repositories/releases/org/apache/apache/12/
>
> My package opens like this:
>
> $ tree .
> .
> ├── DEPENDENCIES
> ├── DISCLAIMER
> ├── LICENSE
> ├── NOTICE
> ├── pom.xml
> └── src
> └── site
> └── site.xml
>
> Can you please tell me what you are seeing? I really don't get what you mean.
This is what I am seeing:
Marcels-MacBook-Pro:Downloads marcel$ unzip -l org.apache.onami.parent-1-incubating-source-release.zip
Archive: org.apache.onami.parent-1-incubating-source-release.zip
Length Date Time Name
-------- ---- ---- ----
0 12-21-12 05:29 org.apache.onami.parent-1-incubating/
0 12-21-12 05:29 org.apache.onami.parent-1-incubating/src/
0 12-21-12 05:29 org.apache.onami.parent-1-incubating/src/site/
531 12-21-12 05:29 org.apache.onami.parent-1-incubating/DISCLAIMER
11357 12-21-12 05:29 org.apache.onami.parent-1-incubating/LICENSE
208 12-21-12 05:29 org.apache.onami.parent-1-incubating/NOTICE
29715 12-21-12 05:29 org.apache.onami.parent-1-incubating/pom.xml
4193 12-21-12 05:29 org.apache.onami.parent-1-incubating/src/site/site.xml
262 12-21-12 05:29 org.apache.onami.parent-1-incubating/DEPENDENCIES
-------- -------
46266 9 files
Sorry for the crappy formatting. :)
Just to be sure it's not my "unzip" tool:
Marcels-MacBook-Pro:Downloads marcel$ jar tf org.apache.onami.parent-1-incubating-source-release.zip
org.apache.onami.parent-1-incubating/
org.apache.onami.parent-1-incubating/src/
org.apache.onami.parent-1-incubating/src/site/
org.apache.onami.parent-1-incubating/DISCLAIMER
org.apache.onami.parent-1-incubating/LICENSE
org.apache.onami.parent-1-incubating/NOTICE
org.apache.onami.parent-1-incubating/pom.xml
org.apache.onami.parent-1-incubating/src/site/site.xml
org.apache.onami.parent-1-incubating/DEPENDENCIES
>> A question about the contents of the NOTICE file, can you explain why you included the line:
>> "Copyright 2010-2012 The 99 Software Foundation" ?
>
> hm I think the original package maintainer left this in the NOTICE
> file. Before Onami came to the Incubator, it was maintained by "99
> Software Foundation" (which is not really a registered foundation).
> Most likely he thinks that the history should be kept in the NOTICE
> file like we do sometimes with attributing people who donated a few
> classes.
It should only be in the notice if Onami contains third-party software that requires you mention it [1]. Since this is code that was donated to Apache, I don't think that applies, so you should leave it out.
Greetings, Marcel
[1] http://apache.org/legal/resolved.html#required-third-party-notices
Re: [VOTE] Release Onami Parent 1 RC2
Posted by Christian Grobmeier <gr...@gmail.com>.
Hi Marcel,
On Wed, Dec 26, 2012 at 10:22 AM, Marcel Offermans
<ma...@luminis.nl> wrote:
> -1 Because: The release now is a ZIP file, and contains the NOTICE and LICENSE files, but they must be located at the root of the archive [1], and not in a subfolder like they are now.
For me they are in the root folder. It looks exactly as the Apache Parent:
https://repository.apache.org/content/repositories/releases/org/apache/apache/12/
My package opens like this:
$ tree .
.
├── DEPENDENCIES
├── DISCLAIMER
├── LICENSE
├── NOTICE
├── pom.xml
└── src
└── site
└── site.xml
Can you please tell me what you are seeing? I really don't get what you mean.
> A question about the contents of the NOTICE file, can you explain why you included the line:
> "Copyright 2010-2012 The 99 Software Foundation" ?
hm I think the original package maintainer left this in the NOTICE
file. Before Onami came to the Incubator, it was maintained by "99
Software Foundation" (which is not really a registered foundation).
Most likely he thinks that the history should be kept in the NOTICE
file like we do sometimes with attributing people who donated a few
classes.
Cheers,
Christian
>
> Greetings, Marcel
>
> [1] http://www.apache.org/dev/release.html#full-copy-for-each-source-file
>
>
> On Dec 25, 2012, at 12:59 PM, Christian Grobmeier <gr...@gmail.com> wrote:
>
>> Hi all,
>>
>> This is a call for a vote on releasing the following candidate as
>> Apache Onami parent 1-incubating. This will be our first release.
>>
>> Improvements over RC1:
>> * Created a source artifact including the pom + LICENSE and DISCLAIMER files
>>
>> Artifacts are on Nexus:
>> https://repository.apache.org/content/repositories/orgapacheonami-066
>>
>> SVN Tag:
>> http://svn.apache.org/repos/asf/incubator/onami/tags/org.apache.onami.parent-1-incubating/
>>
>> The vote is open for 72 at least hours and is closing ~ on December
>> 28th, 13:00pm GMT*.
>>
>> The Onami Podling has successfully voted with 7 +1 from:
>>
>> * Daniel Manzke
>> * Simone Tripodi
>> * Mohamma Nour El-Din (IPMC)
>> * Jordi Gerona
>> * Olivier Lamy (IPMC)
>> * Ioannis Canellos
>> * Christian Grobmeier (IPMC)
>>
>> We are aware that our artifact needs to go to /dist, even when it is
>> just useful for Maven.
>>
>> Please cast your votes:
>>
>> [ ] +1 release it
>> [ ] +0 go ahead, but ...
>> [ ] -0 uhm...
>> [ ] -1 don't release it, because...
>>
>> Thanks,
>> Christian
>>
>> --
>> http://www.grobmeier.de
>> https://www.timeandbill.de
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>>
>>
>
--
http://www.grobmeier.de
https://www.timeandbill.de
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Onami Parent 1 RC2
Posted by Marcel Offermans <ma...@luminis.nl>.
-1 Because: The release now is a ZIP file, and contains the NOTICE and LICENSE files, but they must be located at the root of the archive [1], and not in a subfolder like they are now.
A question about the contents of the NOTICE file, can you explain why you included the line:
"Copyright 2010-2012 The 99 Software Foundation" ?
Greetings, Marcel
[1] http://www.apache.org/dev/release.html#full-copy-for-each-source-file
On Dec 25, 2012, at 12:59 PM, Christian Grobmeier <gr...@gmail.com> wrote:
> Hi all,
>
> This is a call for a vote on releasing the following candidate as
> Apache Onami parent 1-incubating. This will be our first release.
>
> Improvements over RC1:
> * Created a source artifact including the pom + LICENSE and DISCLAIMER files
>
> Artifacts are on Nexus:
> https://repository.apache.org/content/repositories/orgapacheonami-066
>
> SVN Tag:
> http://svn.apache.org/repos/asf/incubator/onami/tags/org.apache.onami.parent-1-incubating/
>
> The vote is open for 72 at least hours and is closing ~ on December
> 28th, 13:00pm GMT*.
>
> The Onami Podling has successfully voted with 7 +1 from:
>
> * Daniel Manzke
> * Simone Tripodi
> * Mohamma Nour El-Din (IPMC)
> * Jordi Gerona
> * Olivier Lamy (IPMC)
> * Ioannis Canellos
> * Christian Grobmeier (IPMC)
>
> We are aware that our artifact needs to go to /dist, even when it is
> just useful for Maven.
>
> Please cast your votes:
>
> [ ] +1 release it
> [ ] +0 go ahead, but ...
> [ ] -0 uhm...
> [ ] -1 don't release it, because...
>
> Thanks,
> Christian
>
> --
> http://www.grobmeier.de
> https://www.timeandbill.de
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
>
Fwd: [VOTE] Release Onami Parent 1 RC2
Posted by Christian Grobmeier <gr...@gmail.com>.
Ups, forgot to CC you - please monitor the vote on general@incubator
Cheers
---------- Forwarded message ----------
From: Christian Grobmeier <gr...@gmail.com>
Date: Tue, Dec 25, 2012 at 12:59 PM
Subject: [VOTE] Release Onami Parent 1 RC2
To: "general@incubator.apache.org" <ge...@incubator.apache.org>
Hi all,
This is a call for a vote on releasing the following candidate as
Apache Onami parent 1-incubating. This will be our first release.
Improvements over RC1:
* Created a source artifact including the pom + LICENSE and DISCLAIMER files
Artifacts are on Nexus:
https://repository.apache.org/content/repositories/orgapacheonami-066
SVN Tag:
http://svn.apache.org/repos/asf/incubator/onami/tags/org.apache.onami.parent-1-incubating/
The vote is open for 72 at least hours and is closing ~ on December
28th, 13:00pm GMT*.
The Onami Podling has successfully voted with 7 +1 from:
* Daniel Manzke
* Simone Tripodi
* Mohamma Nour El-Din (IPMC)
* Jordi Gerona
* Olivier Lamy (IPMC)
* Ioannis Canellos
* Christian Grobmeier (IPMC)
We are aware that our artifact needs to go to /dist, even when it is
just useful for Maven.
Please cast your votes:
[ ] +1 release it
[ ] +0 go ahead, but ...
[ ] -0 uhm...
[ ] -1 don't release it, because...
Thanks,
Christian
--
http://www.grobmeier.de
https://www.timeandbill.de
--
http://www.grobmeier.de
https://www.timeandbill.de