You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/12/13 14:53:11 UTC
[08/13] hbase-site git commit: Published site at
f32d2618430f70e1b0db92785294b2c7892cc02b.
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/c727a708/devapidocs/src-html/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.html b/devapidocs/src-html/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.html
index de5c849..8959499 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.html
@@ -36,1192 +36,1212 @@
<span class="sourceLineNo">028</span>import java.util.Map;<a name="line.28"></a>
<span class="sourceLineNo">029</span>import java.util.Set;<a name="line.29"></a>
<span class="sourceLineNo">030</span>import java.util.concurrent.ConcurrentHashMap;<a name="line.30"></a>
-<span class="sourceLineNo">031</span>import java.util.concurrent.ThreadPoolExecutor;<a name="line.31"></a>
-<span class="sourceLineNo">032</span>import java.util.concurrent.locks.ReadWriteLock;<a name="line.32"></a>
-<span class="sourceLineNo">033</span>import java.util.concurrent.locks.ReentrantReadWriteLock;<a name="line.33"></a>
-<span class="sourceLineNo">034</span><a name="line.34"></a>
-<span class="sourceLineNo">035</span>import org.apache.hadoop.conf.Configuration;<a name="line.35"></a>
-<span class="sourceLineNo">036</span>import org.apache.hadoop.fs.FSDataInputStream;<a name="line.36"></a>
-<span class="sourceLineNo">037</span>import org.apache.hadoop.fs.FileStatus;<a name="line.37"></a>
-<span class="sourceLineNo">038</span>import org.apache.hadoop.fs.FileSystem;<a name="line.38"></a>
-<span class="sourceLineNo">039</span>import org.apache.hadoop.fs.Path;<a name="line.39"></a>
-<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.HBaseInterfaceAudience;<a name="line.40"></a>
-<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.HConstants;<a name="line.41"></a>
-<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.MetaTableAccessor;<a name="line.42"></a>
-<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.Stoppable;<a name="line.43"></a>
-<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.TableName;<a name="line.44"></a>
-<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.client.TableDescriptor;<a name="line.45"></a>
-<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.client.TableDescriptorBuilder;<a name="line.46"></a>
-<span class="sourceLineNo">047</span>import org.apache.hadoop.hbase.client.TableState;<a name="line.47"></a>
-<span class="sourceLineNo">048</span>import org.apache.hadoop.hbase.errorhandling.ForeignException;<a name="line.48"></a>
-<span class="sourceLineNo">049</span>import org.apache.hadoop.hbase.executor.ExecutorService;<a name="line.49"></a>
-<span class="sourceLineNo">050</span>import org.apache.hadoop.hbase.ipc.RpcServer;<a name="line.50"></a>
-<span class="sourceLineNo">051</span>import org.apache.hadoop.hbase.master.MasterCoprocessorHost;<a name="line.51"></a>
-<span class="sourceLineNo">052</span>import org.apache.hadoop.hbase.master.MasterFileSystem;<a name="line.52"></a>
-<span class="sourceLineNo">053</span>import org.apache.hadoop.hbase.master.MasterServices;<a name="line.53"></a>
-<span class="sourceLineNo">054</span>import org.apache.hadoop.hbase.master.MetricsMaster;<a name="line.54"></a>
-<span class="sourceLineNo">055</span>import org.apache.hadoop.hbase.master.SnapshotSentinel;<a name="line.55"></a>
-<span class="sourceLineNo">056</span>import org.apache.hadoop.hbase.master.cleaner.HFileCleaner;<a name="line.56"></a>
-<span class="sourceLineNo">057</span>import org.apache.hadoop.hbase.master.cleaner.HFileLinkCleaner;<a name="line.57"></a>
-<span class="sourceLineNo">058</span>import org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure;<a name="line.58"></a>
-<span class="sourceLineNo">059</span>import org.apache.hadoop.hbase.master.procedure.MasterProcedureEnv;<a name="line.59"></a>
-<span class="sourceLineNo">060</span>import org.apache.hadoop.hbase.master.procedure.RestoreSnapshotProcedure;<a name="line.60"></a>
-<span class="sourceLineNo">061</span>import org.apache.hadoop.hbase.procedure.MasterProcedureManager;<a name="line.61"></a>
-<span class="sourceLineNo">062</span>import org.apache.hadoop.hbase.procedure.Procedure;<a name="line.62"></a>
-<span class="sourceLineNo">063</span>import org.apache.hadoop.hbase.procedure.ProcedureCoordinator;<a name="line.63"></a>
-<span class="sourceLineNo">064</span>import org.apache.hadoop.hbase.procedure.ProcedureCoordinatorRpcs;<a name="line.64"></a>
-<span class="sourceLineNo">065</span>import org.apache.hadoop.hbase.procedure.ZKProcedureCoordinator;<a name="line.65"></a>
-<span class="sourceLineNo">066</span>import org.apache.hadoop.hbase.procedure2.ProcedureExecutor;<a name="line.66"></a>
-<span class="sourceLineNo">067</span>import org.apache.hadoop.hbase.security.AccessDeniedException;<a name="line.67"></a>
-<span class="sourceLineNo">068</span>import org.apache.hadoop.hbase.security.User;<a name="line.68"></a>
-<span class="sourceLineNo">069</span>import org.apache.hadoop.hbase.security.access.AccessChecker;<a name="line.69"></a>
-<span class="sourceLineNo">070</span>import org.apache.hadoop.hbase.snapshot.ClientSnapshotDescriptionUtils;<a name="line.70"></a>
-<span class="sourceLineNo">071</span>import org.apache.hadoop.hbase.snapshot.HBaseSnapshotException;<a name="line.71"></a>
-<span class="sourceLineNo">072</span>import org.apache.hadoop.hbase.snapshot.RestoreSnapshotException;<a name="line.72"></a>
-<span class="sourceLineNo">073</span>import org.apache.hadoop.hbase.snapshot.SnapshotCreationException;<a name="line.73"></a>
-<span class="sourceLineNo">074</span>import org.apache.hadoop.hbase.snapshot.SnapshotDescriptionUtils;<a name="line.74"></a>
-<span class="sourceLineNo">075</span>import org.apache.hadoop.hbase.snapshot.SnapshotDoesNotExistException;<a name="line.75"></a>
-<span class="sourceLineNo">076</span>import org.apache.hadoop.hbase.snapshot.SnapshotExistsException;<a name="line.76"></a>
-<span class="sourceLineNo">077</span>import org.apache.hadoop.hbase.snapshot.SnapshotManifest;<a name="line.77"></a>
-<span class="sourceLineNo">078</span>import org.apache.hadoop.hbase.snapshot.SnapshotReferenceUtil;<a name="line.78"></a>
-<span class="sourceLineNo">079</span>import org.apache.hadoop.hbase.snapshot.TablePartiallyOpenException;<a name="line.79"></a>
-<span class="sourceLineNo">080</span>import org.apache.hadoop.hbase.snapshot.UnknownSnapshotException;<a name="line.80"></a>
-<span class="sourceLineNo">081</span>import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;<a name="line.81"></a>
-<span class="sourceLineNo">082</span>import org.apache.hadoop.hbase.util.FSUtils;<a name="line.82"></a>
-<span class="sourceLineNo">083</span>import org.apache.hadoop.hbase.util.NonceKey;<a name="line.83"></a>
-<span class="sourceLineNo">084</span>import org.apache.yetus.audience.InterfaceAudience;<a name="line.84"></a>
-<span class="sourceLineNo">085</span>import org.apache.yetus.audience.InterfaceStability;<a name="line.85"></a>
-<span class="sourceLineNo">086</span>import org.apache.zookeeper.KeeperException;<a name="line.86"></a>
-<span class="sourceLineNo">087</span>import org.slf4j.Logger;<a name="line.87"></a>
-<span class="sourceLineNo">088</span>import org.slf4j.LoggerFactory;<a name="line.88"></a>
-<span class="sourceLineNo">089</span>import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;<a name="line.89"></a>
-<span class="sourceLineNo">090</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.HBaseProtos.NameStringPair;<a name="line.90"></a>
-<span class="sourceLineNo">091</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.HBaseProtos.ProcedureDescription;<a name="line.91"></a>
-<span class="sourceLineNo">092</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.SnapshotProtos.SnapshotDescription;<a name="line.92"></a>
-<span class="sourceLineNo">093</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.SnapshotProtos.SnapshotDescription.Type;<a name="line.93"></a>
-<span class="sourceLineNo">094</span><a name="line.94"></a>
-<span class="sourceLineNo">095</span>/**<a name="line.95"></a>
-<span class="sourceLineNo">096</span> * This class manages the procedure of taking and restoring snapshots. There is only one<a name="line.96"></a>
-<span class="sourceLineNo">097</span> * SnapshotManager for the master.<a name="line.97"></a>
-<span class="sourceLineNo">098</span> * <p><a name="line.98"></a>
-<span class="sourceLineNo">099</span> * The class provides methods for monitoring in-progress snapshot actions.<a name="line.99"></a>
-<span class="sourceLineNo">100</span> * <p><a name="line.100"></a>
-<span class="sourceLineNo">101</span> * Note: Currently there can only be one snapshot being taken at a time over the cluster. This is a<a name="line.101"></a>
-<span class="sourceLineNo">102</span> * simplification in the current implementation.<a name="line.102"></a>
-<span class="sourceLineNo">103</span> */<a name="line.103"></a>
-<span class="sourceLineNo">104</span>@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)<a name="line.104"></a>
-<span class="sourceLineNo">105</span>@InterfaceStability.Unstable<a name="line.105"></a>
-<span class="sourceLineNo">106</span>public class SnapshotManager extends MasterProcedureManager implements Stoppable {<a name="line.106"></a>
-<span class="sourceLineNo">107</span> private static final Logger LOG = LoggerFactory.getLogger(SnapshotManager.class);<a name="line.107"></a>
-<span class="sourceLineNo">108</span><a name="line.108"></a>
-<span class="sourceLineNo">109</span> /** By default, check to see if the snapshot is complete every WAKE MILLIS (ms) */<a name="line.109"></a>
-<span class="sourceLineNo">110</span> private static final int SNAPSHOT_WAKE_MILLIS_DEFAULT = 500;<a name="line.110"></a>
-<span class="sourceLineNo">111</span><a name="line.111"></a>
-<span class="sourceLineNo">112</span> /**<a name="line.112"></a>
-<span class="sourceLineNo">113</span> * Wait time before removing a finished sentinel from the in-progress map<a name="line.113"></a>
-<span class="sourceLineNo">114</span> *<a name="line.114"></a>
-<span class="sourceLineNo">115</span> * NOTE: This is used as a safety auto cleanup.<a name="line.115"></a>
-<span class="sourceLineNo">116</span> * The snapshot and restore handlers map entries are removed when a user asks if a snapshot or<a name="line.116"></a>
-<span class="sourceLineNo">117</span> * restore is completed. This operation is part of the HBaseAdmin snapshot/restore API flow.<a name="line.117"></a>
-<span class="sourceLineNo">118</span> * In case something fails on the client side and the snapshot/restore state is not reclaimed<a name="line.118"></a>
-<span class="sourceLineNo">119</span> * after a default timeout, the entry is removed from the in-progress map.<a name="line.119"></a>
-<span class="sourceLineNo">120</span> * At this point, if the user asks for the snapshot/restore status, the result will be<a name="line.120"></a>
-<span class="sourceLineNo">121</span> * snapshot done if exists or failed if it doesn't exists.<a name="line.121"></a>
-<span class="sourceLineNo">122</span> */<a name="line.122"></a>
-<span class="sourceLineNo">123</span> private static final int SNAPSHOT_SENTINELS_CLEANUP_TIMEOUT = 60 * 1000;<a name="line.123"></a>
-<span class="sourceLineNo">124</span><a name="line.124"></a>
-<span class="sourceLineNo">125</span> /** Enable or disable snapshot support */<a name="line.125"></a>
-<span class="sourceLineNo">126</span> public static final String HBASE_SNAPSHOT_ENABLED = "hbase.snapshot.enabled";<a name="line.126"></a>
-<span class="sourceLineNo">127</span><a name="line.127"></a>
-<span class="sourceLineNo">128</span> /**<a name="line.128"></a>
-<span class="sourceLineNo">129</span> * Conf key for # of ms elapsed between checks for snapshot errors while waiting for<a name="line.129"></a>
-<span class="sourceLineNo">130</span> * completion.<a name="line.130"></a>
-<span class="sourceLineNo">131</span> */<a name="line.131"></a>
-<span class="sourceLineNo">132</span> private static final String SNAPSHOT_WAKE_MILLIS_KEY = "hbase.snapshot.master.wakeMillis";<a name="line.132"></a>
-<span class="sourceLineNo">133</span><a name="line.133"></a>
-<span class="sourceLineNo">134</span> /** Name of the operation to use in the controller */<a name="line.134"></a>
-<span class="sourceLineNo">135</span> public static final String ONLINE_SNAPSHOT_CONTROLLER_DESCRIPTION = "online-snapshot";<a name="line.135"></a>
-<span class="sourceLineNo">136</span><a name="line.136"></a>
-<span class="sourceLineNo">137</span> /** Conf key for # of threads used by the SnapshotManager thread pool */<a name="line.137"></a>
-<span class="sourceLineNo">138</span> private static final String SNAPSHOT_POOL_THREADS_KEY = "hbase.snapshot.master.threads";<a name="line.138"></a>
-<span class="sourceLineNo">139</span><a name="line.139"></a>
-<span class="sourceLineNo">140</span> /** number of current operations running on the master */<a name="line.140"></a>
-<span class="sourceLineNo">141</span> private static final int SNAPSHOT_POOL_THREADS_DEFAULT = 1;<a name="line.141"></a>
-<span class="sourceLineNo">142</span><a name="line.142"></a>
-<span class="sourceLineNo">143</span> private boolean stopped;<a name="line.143"></a>
-<span class="sourceLineNo">144</span> private MasterServices master; // Needed by TableEventHandlers<a name="line.144"></a>
-<span class="sourceLineNo">145</span> private ProcedureCoordinator coordinator;<a name="line.145"></a>
-<span class="sourceLineNo">146</span><a name="line.146"></a>
-<span class="sourceLineNo">147</span> // Is snapshot feature enabled?<a name="line.147"></a>
-<span class="sourceLineNo">148</span> private boolean isSnapshotSupported = false;<a name="line.148"></a>
-<span class="sourceLineNo">149</span><a name="line.149"></a>
-<span class="sourceLineNo">150</span> // Snapshot handlers map, with table name as key.<a name="line.150"></a>
-<span class="sourceLineNo">151</span> // The map is always accessed and modified under the object lock using synchronized.<a name="line.151"></a>
-<span class="sourceLineNo">152</span> // snapshotTable() will insert an Handler in the table.<a name="line.152"></a>
-<span class="sourceLineNo">153</span> // isSnapshotDone() will remove the handler requested if the operation is finished.<a name="line.153"></a>
-<span class="sourceLineNo">154</span> private Map<TableName, SnapshotSentinel> snapshotHandlers = new ConcurrentHashMap<>();<a name="line.154"></a>
-<span class="sourceLineNo">155</span><a name="line.155"></a>
-<span class="sourceLineNo">156</span> // Restore map, with table name as key, procedure ID as value.<a name="line.156"></a>
-<span class="sourceLineNo">157</span> // The map is always accessed and modified under the object lock using synchronized.<a name="line.157"></a>
-<span class="sourceLineNo">158</span> // restoreSnapshot()/cloneSnapshot() will insert a procedure ID in the map.<a name="line.158"></a>
-<span class="sourceLineNo">159</span> //<a name="line.159"></a>
-<span class="sourceLineNo">160</span> // TODO: just as the Apache HBase 1.x implementation, this map would not survive master<a name="line.160"></a>
-<span class="sourceLineNo">161</span> // restart/failover. This is just a stopgap implementation until implementation of taking<a name="line.161"></a>
-<span class="sourceLineNo">162</span> // snapshot using Procedure-V2.<a name="line.162"></a>
-<span class="sourceLineNo">163</span> private Map<TableName, Long> restoreTableToProcIdMap = new HashMap<>();<a name="line.163"></a>
-<span class="sourceLineNo">164</span><a name="line.164"></a>
-<span class="sourceLineNo">165</span> private Path rootDir;<a name="line.165"></a>
-<span class="sourceLineNo">166</span> private ExecutorService executorService;<a name="line.166"></a>
+<span class="sourceLineNo">031</span>import java.util.concurrent.Executors;<a name="line.31"></a>
+<span class="sourceLineNo">032</span>import java.util.concurrent.ScheduledExecutorService;<a name="line.32"></a>
+<span class="sourceLineNo">033</span>import java.util.concurrent.ScheduledFuture;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import java.util.concurrent.ThreadPoolExecutor;<a name="line.34"></a>
+<span class="sourceLineNo">035</span>import java.util.concurrent.TimeUnit;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import java.util.concurrent.locks.ReadWriteLock;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import java.util.concurrent.locks.ReentrantReadWriteLock;<a name="line.37"></a>
+<span class="sourceLineNo">038</span><a name="line.38"></a>
+<span class="sourceLineNo">039</span>import org.apache.hadoop.conf.Configuration;<a name="line.39"></a>
+<span class="sourceLineNo">040</span>import org.apache.hadoop.fs.FSDataInputStream;<a name="line.40"></a>
+<span class="sourceLineNo">041</span>import org.apache.hadoop.fs.FileStatus;<a name="line.41"></a>
+<span class="sourceLineNo">042</span>import org.apache.hadoop.fs.FileSystem;<a name="line.42"></a>
+<span class="sourceLineNo">043</span>import org.apache.hadoop.fs.Path;<a name="line.43"></a>
+<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.HBaseInterfaceAudience;<a name="line.44"></a>
+<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.HConstants;<a name="line.45"></a>
+<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.MetaTableAccessor;<a name="line.46"></a>
+<span class="sourceLineNo">047</span>import org.apache.hadoop.hbase.Stoppable;<a name="line.47"></a>
+<span class="sourceLineNo">048</span>import org.apache.hadoop.hbase.TableName;<a name="line.48"></a>
+<span class="sourceLineNo">049</span>import org.apache.hadoop.hbase.client.TableDescriptor;<a name="line.49"></a>
+<span class="sourceLineNo">050</span>import org.apache.hadoop.hbase.client.TableDescriptorBuilder;<a name="line.50"></a>
+<span class="sourceLineNo">051</span>import org.apache.hadoop.hbase.client.TableState;<a name="line.51"></a>
+<span class="sourceLineNo">052</span>import org.apache.hadoop.hbase.errorhandling.ForeignException;<a name="line.52"></a>
+<span class="sourceLineNo">053</span>import org.apache.hadoop.hbase.executor.ExecutorService;<a name="line.53"></a>
+<span class="sourceLineNo">054</span>import org.apache.hadoop.hbase.ipc.RpcServer;<a name="line.54"></a>
+<span class="sourceLineNo">055</span>import org.apache.hadoop.hbase.master.MasterCoprocessorHost;<a name="line.55"></a>
+<span class="sourceLineNo">056</span>import org.apache.hadoop.hbase.master.MasterFileSystem;<a name="line.56"></a>
+<span class="sourceLineNo">057</span>import org.apache.hadoop.hbase.master.MasterServices;<a name="line.57"></a>
+<span class="sourceLineNo">058</span>import org.apache.hadoop.hbase.master.MetricsMaster;<a name="line.58"></a>
+<span class="sourceLineNo">059</span>import org.apache.hadoop.hbase.master.SnapshotSentinel;<a name="line.59"></a>
+<span class="sourceLineNo">060</span>import org.apache.hadoop.hbase.master.cleaner.HFileCleaner;<a name="line.60"></a>
+<span class="sourceLineNo">061</span>import org.apache.hadoop.hbase.master.cleaner.HFileLinkCleaner;<a name="line.61"></a>
+<span class="sourceLineNo">062</span>import org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure;<a name="line.62"></a>
+<span class="sourceLineNo">063</span>import org.apache.hadoop.hbase.master.procedure.MasterProcedureEnv;<a name="line.63"></a>
+<span class="sourceLineNo">064</span>import org.apache.hadoop.hbase.master.procedure.RestoreSnapshotProcedure;<a name="line.64"></a>
+<span class="sourceLineNo">065</span>import org.apache.hadoop.hbase.procedure.MasterProcedureManager;<a name="line.65"></a>
+<span class="sourceLineNo">066</span>import org.apache.hadoop.hbase.procedure.Procedure;<a name="line.66"></a>
+<span class="sourceLineNo">067</span>import org.apache.hadoop.hbase.procedure.ProcedureCoordinator;<a name="line.67"></a>
+<span class="sourceLineNo">068</span>import org.apache.hadoop.hbase.procedure.ProcedureCoordinatorRpcs;<a name="line.68"></a>
+<span class="sourceLineNo">069</span>import org.apache.hadoop.hbase.procedure.ZKProcedureCoordinator;<a name="line.69"></a>
+<span class="sourceLineNo">070</span>import org.apache.hadoop.hbase.procedure2.ProcedureExecutor;<a name="line.70"></a>
+<span class="sourceLineNo">071</span>import org.apache.hadoop.hbase.security.AccessDeniedException;<a name="line.71"></a>
+<span class="sourceLineNo">072</span>import org.apache.hadoop.hbase.security.User;<a name="line.72"></a>
+<span class="sourceLineNo">073</span>import org.apache.hadoop.hbase.security.access.AccessChecker;<a name="line.73"></a>
+<span class="sourceLineNo">074</span>import org.apache.hadoop.hbase.snapshot.ClientSnapshotDescriptionUtils;<a name="line.74"></a>
+<span class="sourceLineNo">075</span>import org.apache.hadoop.hbase.snapshot.HBaseSnapshotException;<a name="line.75"></a>
+<span class="sourceLineNo">076</span>import org.apache.hadoop.hbase.snapshot.RestoreSnapshotException;<a name="line.76"></a>
+<span class="sourceLineNo">077</span>import org.apache.hadoop.hbase.snapshot.SnapshotCreationException;<a name="line.77"></a>
+<span class="sourceLineNo">078</span>import org.apache.hadoop.hbase.snapshot.SnapshotDescriptionUtils;<a name="line.78"></a>
+<span class="sourceLineNo">079</span>import org.apache.hadoop.hbase.snapshot.SnapshotDoesNotExistException;<a name="line.79"></a>
+<span class="sourceLineNo">080</span>import org.apache.hadoop.hbase.snapshot.SnapshotExistsException;<a name="line.80"></a>
+<span class="sourceLineNo">081</span>import org.apache.hadoop.hbase.snapshot.SnapshotManifest;<a name="line.81"></a>
+<span class="sourceLineNo">082</span>import org.apache.hadoop.hbase.snapshot.SnapshotReferenceUtil;<a name="line.82"></a>
+<span class="sourceLineNo">083</span>import org.apache.hadoop.hbase.snapshot.TablePartiallyOpenException;<a name="line.83"></a>
+<span class="sourceLineNo">084</span>import org.apache.hadoop.hbase.snapshot.UnknownSnapshotException;<a name="line.84"></a>
+<span class="sourceLineNo">085</span>import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;<a name="line.85"></a>
+<span class="sourceLineNo">086</span>import org.apache.hadoop.hbase.util.FSUtils;<a name="line.86"></a>
+<span class="sourceLineNo">087</span>import org.apache.hadoop.hbase.util.NonceKey;<a name="line.87"></a>
+<span class="sourceLineNo">088</span>import org.apache.yetus.audience.InterfaceAudience;<a name="line.88"></a>
+<span class="sourceLineNo">089</span>import org.apache.yetus.audience.InterfaceStability;<a name="line.89"></a>
+<span class="sourceLineNo">090</span>import org.apache.zookeeper.KeeperException;<a name="line.90"></a>
+<span class="sourceLineNo">091</span>import org.slf4j.Logger;<a name="line.91"></a>
+<span class="sourceLineNo">092</span>import org.slf4j.LoggerFactory;<a name="line.92"></a>
+<span class="sourceLineNo">093</span>import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;<a name="line.93"></a>
+<span class="sourceLineNo">094</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.HBaseProtos.NameStringPair;<a name="line.94"></a>
+<span class="sourceLineNo">095</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.HBaseProtos.ProcedureDescription;<a name="line.95"></a>
+<span class="sourceLineNo">096</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.SnapshotProtos.SnapshotDescription;<a name="line.96"></a>
+<span class="sourceLineNo">097</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.SnapshotProtos.SnapshotDescription.Type;<a name="line.97"></a>
+<span class="sourceLineNo">098</span>import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;<a name="line.98"></a>
+<span class="sourceLineNo">099</span>import org.apache.hbase.thirdparty.com.google.common.util.concurrent.ThreadFactoryBuilder;<a name="line.99"></a>
+<span class="sourceLineNo">100</span><a name="line.100"></a>
+<span class="sourceLineNo">101</span>/**<a name="line.101"></a>
+<span class="sourceLineNo">102</span> * This class manages the procedure of taking and restoring snapshots. There is only one<a name="line.102"></a>
+<span class="sourceLineNo">103</span> * SnapshotManager for the master.<a name="line.103"></a>
+<span class="sourceLineNo">104</span> * <p><a name="line.104"></a>
+<span class="sourceLineNo">105</span> * The class provides methods for monitoring in-progress snapshot actions.<a name="line.105"></a>
+<span class="sourceLineNo">106</span> * <p><a name="line.106"></a>
+<span class="sourceLineNo">107</span> * Note: Currently there can only be one snapshot being taken at a time over the cluster. This is a<a name="line.107"></a>
+<span class="sourceLineNo">108</span> * simplification in the current implementation.<a name="line.108"></a>
+<span class="sourceLineNo">109</span> */<a name="line.109"></a>
+<span class="sourceLineNo">110</span>@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)<a name="line.110"></a>
+<span class="sourceLineNo">111</span>@InterfaceStability.Unstable<a name="line.111"></a>
+<span class="sourceLineNo">112</span>public class SnapshotManager extends MasterProcedureManager implements Stoppable {<a name="line.112"></a>
+<span class="sourceLineNo">113</span> private static final Logger LOG = LoggerFactory.getLogger(SnapshotManager.class);<a name="line.113"></a>
+<span class="sourceLineNo">114</span><a name="line.114"></a>
+<span class="sourceLineNo">115</span> /** By default, check to see if the snapshot is complete every WAKE MILLIS (ms) */<a name="line.115"></a>
+<span class="sourceLineNo">116</span> private static final int SNAPSHOT_WAKE_MILLIS_DEFAULT = 500;<a name="line.116"></a>
+<span class="sourceLineNo">117</span><a name="line.117"></a>
+<span class="sourceLineNo">118</span> /**<a name="line.118"></a>
+<span class="sourceLineNo">119</span> * Wait time before removing a finished sentinel from the in-progress map<a name="line.119"></a>
+<span class="sourceLineNo">120</span> *<a name="line.120"></a>
+<span class="sourceLineNo">121</span> * NOTE: This is used as a safety auto cleanup.<a name="line.121"></a>
+<span class="sourceLineNo">122</span> * The snapshot and restore handlers map entries are removed when a user asks if a snapshot or<a name="line.122"></a>
+<span class="sourceLineNo">123</span> * restore is completed. This operation is part of the HBaseAdmin snapshot/restore API flow.<a name="line.123"></a>
+<span class="sourceLineNo">124</span> * In case something fails on the client side and the snapshot/restore state is not reclaimed<a name="line.124"></a>
+<span class="sourceLineNo">125</span> * after a default timeout, the entry is removed from the in-progress map.<a name="line.125"></a>
+<span class="sourceLineNo">126</span> * At this point, if the user asks for the snapshot/restore status, the result will be<a name="line.126"></a>
+<span class="sourceLineNo">127</span> * snapshot done if exists or failed if it doesn't exists.<a name="line.127"></a>
+<span class="sourceLineNo">128</span> */<a name="line.128"></a>
+<span class="sourceLineNo">129</span> public static final String HBASE_SNAPSHOT_SENTINELS_CLEANUP_TIMEOUT_MILLIS =<a name="line.129"></a>
+<span class="sourceLineNo">130</span> "hbase.snapshot.sentinels.cleanup.timeoutMillis";<a name="line.130"></a>
+<span class="sourceLineNo">131</span> public static final long SNAPSHOT_SENTINELS_CLEANUP_TIMEOUT_MILLS_DEFAULT = 60 * 1000L;<a name="line.131"></a>
+<span class="sourceLineNo">132</span><a name="line.132"></a>
+<span class="sourceLineNo">133</span> /** Enable or disable snapshot support */<a name="line.133"></a>
+<span class="sourceLineNo">134</span> public static final String HBASE_SNAPSHOT_ENABLED = "hbase.snapshot.enabled";<a name="line.134"></a>
+<span class="sourceLineNo">135</span><a name="line.135"></a>
+<span class="sourceLineNo">136</span> /**<a name="line.136"></a>
+<span class="sourceLineNo">137</span> * Conf key for # of ms elapsed between checks for snapshot errors while waiting for<a name="line.137"></a>
+<span class="sourceLineNo">138</span> * completion.<a name="line.138"></a>
+<span class="sourceLineNo">139</span> */<a name="line.139"></a>
+<span class="sourceLineNo">140</span> private static final String SNAPSHOT_WAKE_MILLIS_KEY = "hbase.snapshot.master.wakeMillis";<a name="line.140"></a>
+<span class="sourceLineNo">141</span><a name="line.141"></a>
+<span class="sourceLineNo">142</span> /** Name of the operation to use in the controller */<a name="line.142"></a>
+<span class="sourceLineNo">143</span> public static final String ONLINE_SNAPSHOT_CONTROLLER_DESCRIPTION = "online-snapshot";<a name="line.143"></a>
+<span class="sourceLineNo">144</span><a name="line.144"></a>
+<span class="sourceLineNo">145</span> /** Conf key for # of threads used by the SnapshotManager thread pool */<a name="line.145"></a>
+<span class="sourceLineNo">146</span> private static final String SNAPSHOT_POOL_THREADS_KEY = "hbase.snapshot.master.threads";<a name="line.146"></a>
+<span class="sourceLineNo">147</span><a name="line.147"></a>
+<span class="sourceLineNo">148</span> /** number of current operations running on the master */<a name="line.148"></a>
+<span class="sourceLineNo">149</span> private static final int SNAPSHOT_POOL_THREADS_DEFAULT = 1;<a name="line.149"></a>
+<span class="sourceLineNo">150</span><a name="line.150"></a>
+<span class="sourceLineNo">151</span> private boolean stopped;<a name="line.151"></a>
+<span class="sourceLineNo">152</span> private MasterServices master; // Needed by TableEventHandlers<a name="line.152"></a>
+<span class="sourceLineNo">153</span> private ProcedureCoordinator coordinator;<a name="line.153"></a>
+<span class="sourceLineNo">154</span><a name="line.154"></a>
+<span class="sourceLineNo">155</span> // Is snapshot feature enabled?<a name="line.155"></a>
+<span class="sourceLineNo">156</span> private boolean isSnapshotSupported = false;<a name="line.156"></a>
+<span class="sourceLineNo">157</span><a name="line.157"></a>
+<span class="sourceLineNo">158</span> // Snapshot handlers map, with table name as key.<a name="line.158"></a>
+<span class="sourceLineNo">159</span> // The map is always accessed and modified under the object lock using synchronized.<a name="line.159"></a>
+<span class="sourceLineNo">160</span> // snapshotTable() will insert an Handler in the table.<a name="line.160"></a>
+<span class="sourceLineNo">161</span> // isSnapshotDone() will remove the handler requested if the operation is finished.<a name="line.161"></a>
+<span class="sourceLineNo">162</span> private final Map<TableName, SnapshotSentinel> snapshotHandlers = new ConcurrentHashMap<>();<a name="line.162"></a>
+<span class="sourceLineNo">163</span> private final ScheduledExecutorService scheduleThreadPool =<a name="line.163"></a>
+<span class="sourceLineNo">164</span> Executors.newScheduledThreadPool(1, new ThreadFactoryBuilder()<a name="line.164"></a>
+<span class="sourceLineNo">165</span> .setNameFormat("SnapshotHandlerChoreCleaner").setDaemon(true).build());<a name="line.165"></a>
+<span class="sourceLineNo">166</span> private ScheduledFuture<?> snapshotHandlerChoreCleanerTask;<a name="line.166"></a>
<span class="sourceLineNo">167</span><a name="line.167"></a>
-<span class="sourceLineNo">168</span> /**<a name="line.168"></a>
-<span class="sourceLineNo">169</span> * Read write lock between taking snapshot and snapshot HFile cleaner. The cleaner should skip to<a name="line.169"></a>
-<span class="sourceLineNo">170</span> * check the HFiles if any snapshot is in progress, otherwise it may clean a HFile which would<a name="line.170"></a>
-<span class="sourceLineNo">171</span> * belongs to the newly creating snapshot. So we should grab the write lock first when cleaner<a name="line.171"></a>
-<span class="sourceLineNo">172</span> * start to work. (See HBASE-21387)<a name="line.172"></a>
-<span class="sourceLineNo">173</span> */<a name="line.173"></a>
-<span class="sourceLineNo">174</span> private ReentrantReadWriteLock takingSnapshotLock = new ReentrantReadWriteLock(true);<a name="line.174"></a>
-<span class="sourceLineNo">175</span><a name="line.175"></a>
-<span class="sourceLineNo">176</span> public SnapshotManager() {}<a name="line.176"></a>
-<span class="sourceLineNo">177</span><a name="line.177"></a>
-<span class="sourceLineNo">178</span> /**<a name="line.178"></a>
-<span class="sourceLineNo">179</span> * Fully specify all necessary components of a snapshot manager. Exposed for testing.<a name="line.179"></a>
-<span class="sourceLineNo">180</span> * @param master services for the master where the manager is running<a name="line.180"></a>
-<span class="sourceLineNo">181</span> * @param coordinator procedure coordinator instance. exposed for testing.<a name="line.181"></a>
-<span class="sourceLineNo">182</span> * @param pool HBase ExecutorServcie instance, exposed for testing.<a name="line.182"></a>
-<span class="sourceLineNo">183</span> */<a name="line.183"></a>
-<span class="sourceLineNo">184</span> public SnapshotManager(final MasterServices master, final MetricsMaster metricsMaster,<a name="line.184"></a>
-<span class="sourceLineNo">185</span> ProcedureCoordinator coordinator, ExecutorService pool)<a name="line.185"></a>
-<span class="sourceLineNo">186</span> throws IOException, UnsupportedOperationException {<a name="line.186"></a>
-<span class="sourceLineNo">187</span> this.master = master;<a name="line.187"></a>
-<span class="sourceLineNo">188</span><a name="line.188"></a>
-<span class="sourceLineNo">189</span> this.rootDir = master.getMasterFileSystem().getRootDir();<a name="line.189"></a>
-<span class="sourceLineNo">190</span> checkSnapshotSupport(master.getConfiguration(), master.getMasterFileSystem());<a name="line.190"></a>
-<span class="sourceLineNo">191</span><a name="line.191"></a>
-<span class="sourceLineNo">192</span> this.coordinator = coordinator;<a name="line.192"></a>
-<span class="sourceLineNo">193</span> this.executorService = pool;<a name="line.193"></a>
-<span class="sourceLineNo">194</span> resetTempDir();<a name="line.194"></a>
-<span class="sourceLineNo">195</span> }<a name="line.195"></a>
-<span class="sourceLineNo">196</span><a name="line.196"></a>
-<span class="sourceLineNo">197</span> /**<a name="line.197"></a>
-<span class="sourceLineNo">198</span> * Gets the list of all completed snapshots.<a name="line.198"></a>
-<span class="sourceLineNo">199</span> * @return list of SnapshotDescriptions<a name="line.199"></a>
-<span class="sourceLineNo">200</span> * @throws IOException File system exception<a name="line.200"></a>
-<span class="sourceLineNo">201</span> */<a name="line.201"></a>
-<span class="sourceLineNo">202</span> public List<SnapshotDescription> getCompletedSnapshots() throws IOException {<a name="line.202"></a>
-<span class="sourceLineNo">203</span> return getCompletedSnapshots(SnapshotDescriptionUtils.getSnapshotsDir(rootDir), true);<a name="line.203"></a>
-<span class="sourceLineNo">204</span> }<a name="line.204"></a>
+<span class="sourceLineNo">168</span> // Restore map, with table name as key, procedure ID as value.<a name="line.168"></a>
+<span class="sourceLineNo">169</span> // The map is always accessed and modified under the object lock using synchronized.<a name="line.169"></a>
+<span class="sourceLineNo">170</span> // restoreSnapshot()/cloneSnapshot() will insert a procedure ID in the map.<a name="line.170"></a>
+<span class="sourceLineNo">171</span> //<a name="line.171"></a>
+<span class="sourceLineNo">172</span> // TODO: just as the Apache HBase 1.x implementation, this map would not survive master<a name="line.172"></a>
+<span class="sourceLineNo">173</span> // restart/failover. This is just a stopgap implementation until implementation of taking<a name="line.173"></a>
+<span class="sourceLineNo">174</span> // snapshot using Procedure-V2.<a name="line.174"></a>
+<span class="sourceLineNo">175</span> private Map<TableName, Long> restoreTableToProcIdMap = new HashMap<>();<a name="line.175"></a>
+<span class="sourceLineNo">176</span><a name="line.176"></a>
+<span class="sourceLineNo">177</span> private Path rootDir;<a name="line.177"></a>
+<span class="sourceLineNo">178</span> private ExecutorService executorService;<a name="line.178"></a>
+<span class="sourceLineNo">179</span><a name="line.179"></a>
+<span class="sourceLineNo">180</span> /**<a name="line.180"></a>
+<span class="sourceLineNo">181</span> * Read write lock between taking snapshot and snapshot HFile cleaner. The cleaner should skip to<a name="line.181"></a>
+<span class="sourceLineNo">182</span> * check the HFiles if any snapshot is in progress, otherwise it may clean a HFile which would<a name="line.182"></a>
+<span class="sourceLineNo">183</span> * belongs to the newly creating snapshot. So we should grab the write lock first when cleaner<a name="line.183"></a>
+<span class="sourceLineNo">184</span> * start to work. (See HBASE-21387)<a name="line.184"></a>
+<span class="sourceLineNo">185</span> */<a name="line.185"></a>
+<span class="sourceLineNo">186</span> private ReentrantReadWriteLock takingSnapshotLock = new ReentrantReadWriteLock(true);<a name="line.186"></a>
+<span class="sourceLineNo">187</span><a name="line.187"></a>
+<span class="sourceLineNo">188</span> public SnapshotManager() {}<a name="line.188"></a>
+<span class="sourceLineNo">189</span><a name="line.189"></a>
+<span class="sourceLineNo">190</span> /**<a name="line.190"></a>
+<span class="sourceLineNo">191</span> * Fully specify all necessary components of a snapshot manager. Exposed for testing.<a name="line.191"></a>
+<span class="sourceLineNo">192</span> * @param master services for the master where the manager is running<a name="line.192"></a>
+<span class="sourceLineNo">193</span> * @param coordinator procedure coordinator instance. exposed for testing.<a name="line.193"></a>
+<span class="sourceLineNo">194</span> * @param pool HBase ExecutorServcie instance, exposed for testing.<a name="line.194"></a>
+<span class="sourceLineNo">195</span> */<a name="line.195"></a>
+<span class="sourceLineNo">196</span> @VisibleForTesting<a name="line.196"></a>
+<span class="sourceLineNo">197</span> SnapshotManager(final MasterServices master, ProcedureCoordinator coordinator,<a name="line.197"></a>
+<span class="sourceLineNo">198</span> ExecutorService pool, int sentinelCleanInterval)<a name="line.198"></a>
+<span class="sourceLineNo">199</span> throws IOException, UnsupportedOperationException {<a name="line.199"></a>
+<span class="sourceLineNo">200</span> this.master = master;<a name="line.200"></a>
+<span class="sourceLineNo">201</span><a name="line.201"></a>
+<span class="sourceLineNo">202</span> this.rootDir = master.getMasterFileSystem().getRootDir();<a name="line.202"></a>
+<span class="sourceLineNo">203</span> Configuration conf = master.getConfiguration();<a name="line.203"></a>
+<span class="sourceLineNo">204</span> checkSnapshotSupport(conf, master.getMasterFileSystem());<a name="line.204"></a>
<span class="sourceLineNo">205</span><a name="line.205"></a>
-<span class="sourceLineNo">206</span> /**<a name="line.206"></a>
-<span class="sourceLineNo">207</span> * Gets the list of all completed snapshots.<a name="line.207"></a>
-<span class="sourceLineNo">208</span> * @param snapshotDir snapshot directory<a name="line.208"></a>
-<span class="sourceLineNo">209</span> * @param withCpCall Whether to call CP hooks<a name="line.209"></a>
-<span class="sourceLineNo">210</span> * @return list of SnapshotDescriptions<a name="line.210"></a>
-<span class="sourceLineNo">211</span> * @throws IOException File system exception<a name="line.211"></a>
-<span class="sourceLineNo">212</span> */<a name="line.212"></a>
-<span class="sourceLineNo">213</span> private List<SnapshotDescription> getCompletedSnapshots(Path snapshotDir, boolean withCpCall)<a name="line.213"></a>
-<span class="sourceLineNo">214</span> throws IOException {<a name="line.214"></a>
-<span class="sourceLineNo">215</span> List<SnapshotDescription> snapshotDescs = new ArrayList<>();<a name="line.215"></a>
-<span class="sourceLineNo">216</span> // first create the snapshot root path and check to see if it exists<a name="line.216"></a>
-<span class="sourceLineNo">217</span> FileSystem fs = master.getMasterFileSystem().getFileSystem();<a name="line.217"></a>
-<span class="sourceLineNo">218</span> if (snapshotDir == null) snapshotDir = SnapshotDescriptionUtils.getSnapshotsDir(rootDir);<a name="line.218"></a>
-<span class="sourceLineNo">219</span><a name="line.219"></a>
-<span class="sourceLineNo">220</span> // if there are no snapshots, return an empty list<a name="line.220"></a>
-<span class="sourceLineNo">221</span> if (!fs.exists(snapshotDir)) {<a name="line.221"></a>
-<span class="sourceLineNo">222</span> return snapshotDescs;<a name="line.222"></a>
-<span class="sourceLineNo">223</span> }<a name="line.223"></a>
-<span class="sourceLineNo">224</span><a name="line.224"></a>
-<span class="sourceLineNo">225</span> // ignore all the snapshots in progress<a name="line.225"></a>
-<span class="sourceLineNo">226</span> FileStatus[] snapshots = fs.listStatus(snapshotDir,<a name="line.226"></a>
-<span class="sourceLineNo">227</span> new SnapshotDescriptionUtils.CompletedSnaphotDirectoriesFilter(fs));<a name="line.227"></a>
-<span class="sourceLineNo">228</span> MasterCoprocessorHost cpHost = master.getMasterCoprocessorHost();<a name="line.228"></a>
-<span class="sourceLineNo">229</span> withCpCall = withCpCall && cpHost != null;<a name="line.229"></a>
-<span class="sourceLineNo">230</span> // loop through all the completed snapshots<a name="line.230"></a>
-<span class="sourceLineNo">231</span> for (FileStatus snapshot : snapshots) {<a name="line.231"></a>
-<span class="sourceLineNo">232</span> Path info = new Path(snapshot.getPath(), SnapshotDescriptionUtils.SNAPSHOTINFO_FILE);<a name="line.232"></a>
-<span class="sourceLineNo">233</span> // if the snapshot is bad<a name="line.233"></a>
-<span class="sourceLineNo">234</span> if (!fs.exists(info)) {<a name="line.234"></a>
-<span class="sourceLineNo">235</span> LOG.error("Snapshot information for " + snapshot.getPath() + " doesn't exist");<a name="line.235"></a>
-<span class="sourceLineNo">236</span> continue;<a name="line.236"></a>
-<span class="sourceLineNo">237</span> }<a name="line.237"></a>
-<span class="sourceLineNo">238</span> FSDataInputStream in = null;<a name="line.238"></a>
-<span class="sourceLineNo">239</span> try {<a name="line.239"></a>
-<span class="sourceLineNo">240</span> in = fs.open(info);<a name="line.240"></a>
-<span class="sourceLineNo">241</span> SnapshotDescription desc = SnapshotDescription.parseFrom(in);<a name="line.241"></a>
-<span class="sourceLineNo">242</span> org.apache.hadoop.hbase.client.SnapshotDescription descPOJO = (withCpCall)<a name="line.242"></a>
-<span class="sourceLineNo">243</span> ? ProtobufUtil.createSnapshotDesc(desc) : null;<a name="line.243"></a>
-<span class="sourceLineNo">244</span> if (withCpCall) {<a name="line.244"></a>
-<span class="sourceLineNo">245</span> try {<a name="line.245"></a>
-<span class="sourceLineNo">246</span> cpHost.preListSnapshot(descPOJO);<a name="line.246"></a>
-<span class="sourceLineNo">247</span> } catch (AccessDeniedException e) {<a name="line.247"></a>
-<span class="sourceLineNo">248</span> LOG.warn("Current user does not have access to " + desc.getName() + " snapshot. "<a name="line.248"></a>
-<span class="sourceLineNo">249</span> + "Either you should be owner of this snapshot or admin user.");<a name="line.249"></a>
-<span class="sourceLineNo">250</span> // Skip this and try for next snapshot<a name="line.250"></a>
-<span class="sourceLineNo">251</span> continue;<a name="line.251"></a>
-<span class="sourceLineNo">252</span> }<a name="line.252"></a>
-<span class="sourceLineNo">253</span> }<a name="line.253"></a>
-<span class="sourceLineNo">254</span> snapshotDescs.add(desc);<a name="line.254"></a>
-<span class="sourceLineNo">255</span><a name="line.255"></a>
-<span class="sourceLineNo">256</span> // call coproc post hook<a name="line.256"></a>
-<span class="sourceLineNo">257</span> if (withCpCall) {<a name="line.257"></a>
-<span class="sourceLineNo">258</span> cpHost.postListSnapshot(descPOJO);<a name="line.258"></a>
-<span class="sourceLineNo">259</span> }<a name="line.259"></a>
-<span class="sourceLineNo">260</span> } catch (IOException e) {<a name="line.260"></a>
-<span class="sourceLineNo">261</span> LOG.warn("Found a corrupted snapshot " + snapshot.getPath(), e);<a name="line.261"></a>
-<span class="sourceLineNo">262</span> } finally {<a name="line.262"></a>
-<span class="sourceLineNo">263</span> if (in != null) {<a name="line.263"></a>
-<span class="sourceLineNo">264</span> in.close();<a name="line.264"></a>
-<span class="sourceLineNo">265</span> }<a name="line.265"></a>
-<span class="sourceLineNo">266</span> }<a name="line.266"></a>
-<span class="sourceLineNo">267</span> }<a name="line.267"></a>
-<span class="sourceLineNo">268</span> return snapshotDescs;<a name="line.268"></a>
-<span class="sourceLineNo">269</span> }<a name="line.269"></a>
-<span class="sourceLineNo">270</span><a name="line.270"></a>
-<span class="sourceLineNo">271</span> /**<a name="line.271"></a>
-<span class="sourceLineNo">272</span> * Cleans up any snapshots in the snapshot/.tmp directory that were left from failed<a name="line.272"></a>
-<span class="sourceLineNo">273</span> * snapshot attempts.<a name="line.273"></a>
-<span class="sourceLineNo">274</span> *<a name="line.274"></a>
-<span class="sourceLineNo">275</span> * @throws IOException if we can't reach the filesystem<a name="line.275"></a>
-<span class="sourceLineNo">276</span> */<a name="line.276"></a>
-<span class="sourceLineNo">277</span> void resetTempDir() throws IOException {<a name="line.277"></a>
-<span class="sourceLineNo">278</span> // cleanup any existing snapshots.<a name="line.278"></a>
-<span class="sourceLineNo">279</span> Path tmpdir = SnapshotDescriptionUtils.getWorkingSnapshotDir(rootDir,<a name="line.279"></a>
-<span class="sourceLineNo">280</span> master.getConfiguration());<a name="line.280"></a>
-<span class="sourceLineNo">281</span> FileSystem tmpFs = tmpdir.getFileSystem(master.getConfiguration());<a name="line.281"></a>
-<span class="sourceLineNo">282</span> if (!tmpFs.delete(tmpdir, true)) {<a name="line.282"></a>
-<span class="sourceLineNo">283</span> LOG.warn("Couldn't delete working snapshot directory: " + tmpdir);<a name="line.283"></a>
-<span class="sourceLineNo">284</span> }<a name="line.284"></a>
+<span class="sourceLineNo">206</span> this.coordinator = coordinator;<a name="line.206"></a>
+<span class="sourceLineNo">207</span> this.executorService = pool;<a name="line.207"></a>
+<span class="sourceLineNo">208</span> resetTempDir();<a name="line.208"></a>
+<span class="sourceLineNo">209</span> snapshotHandlerChoreCleanerTask = this.scheduleThreadPool.scheduleAtFixedRate(<a name="line.209"></a>
+<span class="sourceLineNo">210</span> this::cleanupSentinels, sentinelCleanInterval, sentinelCleanInterval, TimeUnit.SECONDS);<a name="line.210"></a>
+<span class="sourceLineNo">211</span> }<a name="line.211"></a>
+<span class="sourceLineNo">212</span><a name="line.212"></a>
+<span class="sourceLineNo">213</span> /**<a name="line.213"></a>
+<span class="sourceLineNo">214</span> * Gets the list of all completed snapshots.<a name="line.214"></a>
+<span class="sourceLineNo">215</span> * @return list of SnapshotDescriptions<a name="line.215"></a>
+<span class="sourceLineNo">216</span> * @throws IOException File system exception<a name="line.216"></a>
+<span class="sourceLineNo">217</span> */<a name="line.217"></a>
+<span class="sourceLineNo">218</span> public List<SnapshotDescription> getCompletedSnapshots() throws IOException {<a name="line.218"></a>
+<span class="sourceLineNo">219</span> return getCompletedSnapshots(SnapshotDescriptionUtils.getSnapshotsDir(rootDir), true);<a name="line.219"></a>
+<span class="sourceLineNo">220</span> }<a name="line.220"></a>
+<span class="sourceLineNo">221</span><a name="line.221"></a>
+<span class="sourceLineNo">222</span> /**<a name="line.222"></a>
+<span class="sourceLineNo">223</span> * Gets the list of all completed snapshots.<a name="line.223"></a>
+<span class="sourceLineNo">224</span> * @param snapshotDir snapshot directory<a name="line.224"></a>
+<span class="sourceLineNo">225</span> * @param withCpCall Whether to call CP hooks<a name="line.225"></a>
+<span class="sourceLineNo">226</span> * @return list of SnapshotDescriptions<a name="line.226"></a>
+<span class="sourceLineNo">227</span> * @throws IOException File system exception<a name="line.227"></a>
+<span class="sourceLineNo">228</span> */<a name="line.228"></a>
+<span class="sourceLineNo">229</span> private List<SnapshotDescription> getCompletedSnapshots(Path snapshotDir, boolean withCpCall)<a name="line.229"></a>
+<span class="sourceLineNo">230</span> throws IOException {<a name="line.230"></a>
+<span class="sourceLineNo">231</span> List<SnapshotDescription> snapshotDescs = new ArrayList<>();<a name="line.231"></a>
+<span class="sourceLineNo">232</span> // first create the snapshot root path and check to see if it exists<a name="line.232"></a>
+<span class="sourceLineNo">233</span> FileSystem fs = master.getMasterFileSystem().getFileSystem();<a name="line.233"></a>
+<span class="sourceLineNo">234</span> if (snapshotDir == null) snapshotDir = SnapshotDescriptionUtils.getSnapshotsDir(rootDir);<a name="line.234"></a>
+<span class="sourceLineNo">235</span><a name="line.235"></a>
+<span class="sourceLineNo">236</span> // if there are no snapshots, return an empty list<a name="line.236"></a>
+<span class="sourceLineNo">237</span> if (!fs.exists(snapshotDir)) {<a name="line.237"></a>
+<span class="sourceLineNo">238</span> return snapshotDescs;<a name="line.238"></a>
+<span class="sourceLineNo">239</span> }<a name="line.239"></a>
+<span class="sourceLineNo">240</span><a name="line.240"></a>
+<span class="sourceLineNo">241</span> // ignore all the snapshots in progress<a name="line.241"></a>
+<span class="sourceLineNo">242</span> FileStatus[] snapshots = fs.listStatus(snapshotDir,<a name="line.242"></a>
+<span class="sourceLineNo">243</span> new SnapshotDescriptionUtils.CompletedSnaphotDirectoriesFilter(fs));<a name="line.243"></a>
+<span class="sourceLineNo">244</span> MasterCoprocessorHost cpHost = master.getMasterCoprocessorHost();<a name="line.244"></a>
+<span class="sourceLineNo">245</span> withCpCall = withCpCall && cpHost != null;<a name="line.245"></a>
+<span class="sourceLineNo">246</span> // loop through all the completed snapshots<a name="line.246"></a>
+<span class="sourceLineNo">247</span> for (FileStatus snapshot : snapshots) {<a name="line.247"></a>
+<span class="sourceLineNo">248</span> Path info = new Path(snapshot.getPath(), SnapshotDescriptionUtils.SNAPSHOTINFO_FILE);<a name="line.248"></a>
+<span class="sourceLineNo">249</span> // if the snapshot is bad<a name="line.249"></a>
+<span class="sourceLineNo">250</span> if (!fs.exists(info)) {<a name="line.250"></a>
+<span class="sourceLineNo">251</span> LOG.error("Snapshot information for " + snapshot.getPath() + " doesn't exist");<a name="line.251"></a>
+<span class="sourceLineNo">252</span> continue;<a name="line.252"></a>
+<span class="sourceLineNo">253</span> }<a name="line.253"></a>
+<span class="sourceLineNo">254</span> FSDataInputStream in = null;<a name="line.254"></a>
+<span class="sourceLineNo">255</span> try {<a name="line.255"></a>
+<span class="sourceLineNo">256</span> in = fs.open(info);<a name="line.256"></a>
+<span class="sourceLineNo">257</span> SnapshotDescription desc = SnapshotDescription.parseFrom(in);<a name="line.257"></a>
+<span class="sourceLineNo">258</span> org.apache.hadoop.hbase.client.SnapshotDescription descPOJO = (withCpCall)<a name="line.258"></a>
+<span class="sourceLineNo">259</span> ? ProtobufUtil.createSnapshotDesc(desc) : null;<a name="line.259"></a>
+<span class="sourceLineNo">260</span> if (withCpCall) {<a name="line.260"></a>
+<span class="sourceLineNo">261</span> try {<a name="line.261"></a>
+<span class="sourceLineNo">262</span> cpHost.preListSnapshot(descPOJO);<a name="line.262"></a>
+<span class="sourceLineNo">263</span> } catch (AccessDeniedException e) {<a name="line.263"></a>
+<span class="sourceLineNo">264</span> LOG.warn("Current user does not have access to " + desc.getName() + " snapshot. "<a name="line.264"></a>
+<span class="sourceLineNo">265</span> + "Either you should be owner of this snapshot or admin user.");<a name="line.265"></a>
+<span class="sourceLineNo">266</span> // Skip this and try for next snapshot<a name="line.266"></a>
+<span class="sourceLineNo">267</span> continue;<a name="line.267"></a>
+<span class="sourceLineNo">268</span> }<a name="line.268"></a>
+<span class="sourceLineNo">269</span> }<a name="line.269"></a>
+<span class="sourceLineNo">270</span> snapshotDescs.add(desc);<a name="line.270"></a>
+<span class="sourceLineNo">271</span><a name="line.271"></a>
+<span class="sourceLineNo">272</span> // call coproc post hook<a name="line.272"></a>
+<span class="sourceLineNo">273</span> if (withCpCall) {<a name="line.273"></a>
+<span class="sourceLineNo">274</span> cpHost.postListSnapshot(descPOJO);<a name="line.274"></a>
+<span class="sourceLineNo">275</span> }<a name="line.275"></a>
+<span class="sourceLineNo">276</span> } catch (IOException e) {<a name="line.276"></a>
+<span class="sourceLineNo">277</span> LOG.warn("Found a corrupted snapshot " + snapshot.getPath(), e);<a name="line.277"></a>
+<span class="sourceLineNo">278</span> } finally {<a name="line.278"></a>
+<span class="sourceLineNo">279</span> if (in != null) {<a name="line.279"></a>
+<span class="sourceLineNo">280</span> in.close();<a name="line.280"></a>
+<span class="sourceLineNo">281</span> }<a name="line.281"></a>
+<span class="sourceLineNo">282</span> }<a name="line.282"></a>
+<span class="sourceLineNo">283</span> }<a name="line.283"></a>
+<span class="sourceLineNo">284</span> return snapshotDescs;<a name="line.284"></a>
<span class="sourceLineNo">285</span> }<a name="line.285"></a>
<span class="sourceLineNo">286</span><a name="line.286"></a>
<span class="sourceLineNo">287</span> /**<a name="line.287"></a>
-<span class="sourceLineNo">288</span> * Delete the specified snapshot<a name="line.288"></a>
-<span class="sourceLineNo">289</span> * @param snapshot<a name="line.289"></a>
-<span class="sourceLineNo">290</span> * @throws SnapshotDoesNotExistException If the specified snapshot does not exist.<a name="line.290"></a>
-<span class="sourceLineNo">291</span> * @throws IOException For filesystem IOExceptions<a name="line.291"></a>
+<span class="sourceLineNo">288</span> * Cleans up any snapshots in the snapshot/.tmp directory that were left from failed<a name="line.288"></a>
+<span class="sourceLineNo">289</span> * snapshot attempts.<a name="line.289"></a>
+<span class="sourceLineNo">290</span> *<a name="line.290"></a>
+<span class="sourceLineNo">291</span> * @throws IOException if we can't reach the filesystem<a name="line.291"></a>
<span class="sourceLineNo">292</span> */<a name="line.292"></a>
-<span class="sourceLineNo">293</span> public void deleteSnapshot(SnapshotDescription snapshot) throws SnapshotDoesNotExistException, IOException {<a name="line.293"></a>
-<span class="sourceLineNo">294</span> // check to see if it is completed<a name="line.294"></a>
-<span class="sourceLineNo">295</span> if (!isSnapshotCompleted(snapshot)) {<a name="line.295"></a>
-<span class="sourceLineNo">296</span> throw new SnapshotDoesNotExistException(ProtobufUtil.createSnapshotDesc(snapshot));<a name="line.296"></a>
-<span class="sourceLineNo">297</span> }<a name="line.297"></a>
-<span class="sourceLineNo">298</span><a name="line.298"></a>
-<span class="sourceLineNo">299</span> String snapshotName = snapshot.getName();<a name="line.299"></a>
-<span class="sourceLineNo">300</span> // first create the snapshot description and check to see if it exists<a name="line.300"></a>
-<span class="sourceLineNo">301</span> FileSystem fs = master.getMasterFileSystem().getFileSystem();<a name="line.301"></a>
-<span class="sourceLineNo">302</span> Path snapshotDir = SnapshotDescriptionUtils.getCompletedSnapshotDir(snapshotName, rootDir);<a name="line.302"></a>
-<span class="sourceLineNo">303</span> // Get snapshot info from file system. The one passed as parameter is a "fake" snapshotInfo with<a name="line.303"></a>
-<span class="sourceLineNo">304</span> // just the "name" and it does not contains the "real" snapshot information<a name="line.304"></a>
-<span class="sourceLineNo">305</span> snapshot = SnapshotDescriptionUtils.readSnapshotInfo(fs, snapshotDir);<a name="line.305"></a>
-<span class="sourceLineNo">306</span><a name="line.306"></a>
-<span class="sourceLineNo">307</span> // call coproc pre hook<a name="line.307"></a>
-<span class="sourceLineNo">308</span> MasterCoprocessorHost cpHost = master.getMasterCoprocessorHost();<a name="line.308"></a>
-<span class="sourceLineNo">309</span> org.apache.hadoop.hbase.client.SnapshotDescription snapshotPOJO = null;<a name="line.309"></a>
-<span class="sourceLineNo">310</span> if (cpHost != null) {<a name="line.310"></a>
-<span class="sourceLineNo">311</span> snapshotPOJO = ProtobufUtil.createSnapshotDesc(snapshot);<a name="line.311"></a>
-<span class="sourceLineNo">312</span> cpHost.preDeleteSnapshot(snapshotPOJO);<a name="line.312"></a>
+<span class="sourceLineNo">293</span> private void resetTempDir() throws IOException {<a name="line.293"></a>
+<span class="sourceLineNo">294</span> // cleanup any existing snapshots.<a name="line.294"></a>
+<span class="sourceLineNo">295</span> Path tmpdir = SnapshotDescriptionUtils.getWorkingSnapshotDir(rootDir,<a name="line.295"></a>
+<span class="sourceLineNo">296</span> master.getConfiguration());<a name="line.296"></a>
+<span class="sourceLineNo">297</span> FileSystem tmpFs = tmpdir.getFileSystem(master.getConfiguration());<a name="line.297"></a>
+<span class="sourceLineNo">298</span> if (!tmpFs.delete(tmpdir, true)) {<a name="line.298"></a>
+<span class="sourceLineNo">299</span> LOG.warn("Couldn't delete working snapshot directory: " + tmpdir);<a name="line.299"></a>
+<span class="sourceLineNo">300</span> }<a name="line.300"></a>
+<span class="sourceLineNo">301</span> }<a name="line.301"></a>
+<span class="sourceLineNo">302</span><a name="line.302"></a>
+<span class="sourceLineNo">303</span> /**<a name="line.303"></a>
+<span class="sourceLineNo">304</span> * Delete the specified snapshot<a name="line.304"></a>
+<span class="sourceLineNo">305</span> * @param snapshot<a name="line.305"></a>
+<span class="sourceLineNo">306</span> * @throws SnapshotDoesNotExistException If the specified snapshot does not exist.<a name="line.306"></a>
+<span class="sourceLineNo">307</span> * @throws IOException For filesystem IOExceptions<a name="line.307"></a>
+<span class="sourceLineNo">308</span> */<a name="line.308"></a>
+<span class="sourceLineNo">309</span> public void deleteSnapshot(SnapshotDescription snapshot) throws IOException {<a name="line.309"></a>
+<span class="sourceLineNo">310</span> // check to see if it is completed<a name="line.310"></a>
+<span class="sourceLineNo">311</span> if (!isSnapshotCompleted(snapshot)) {<a name="line.311"></a>
+<span class="sourceLineNo">312</span> throw new SnapshotDoesNotExistException(ProtobufUtil.createSnapshotDesc(snapshot));<a name="line.312"></a>
<span class="sourceLineNo">313</span> }<a name="line.313"></a>
<span class="sourceLineNo">314</span><a name="line.314"></a>
-<span class="sourceLineNo">315</span> LOG.debug("Deleting snapshot: " + snapshotName);<a name="line.315"></a>
-<span class="sourceLineNo">316</span> // delete the existing snapshot<a name="line.316"></a>
-<span class="sourceLineNo">317</span> if (!fs.delete(snapshotDir, true)) {<a name="line.317"></a>
-<span class="sourceLineNo">318</span> throw new HBaseSnapshotException("Failed to delete snapshot directory: " + snapshotDir);<a name="line.318"></a>
-<span class="sourceLineNo">319</span> }<a name="line.319"></a>
-<span class="sourceLineNo">320</span><a name="line.320"></a>
-<span class="sourceLineNo">321</span> // call coproc post hook<a name="line.321"></a>
-<span class="sourceLineNo">322</span> if (cpHost != null) {<a name="line.322"></a>
-<span class="sourceLineNo">323</span> cpHost.postDeleteSnapshot(snapshotPOJO);<a name="line.323"></a>
-<span class="sourceLineNo">324</span> }<a name="line.324"></a>
-<span class="sourceLineNo">325</span><a name="line.325"></a>
-<span class="sourceLineNo">326</span> }<a name="line.326"></a>
-<span class="sourceLineNo">327</span><a name="line.327"></a>
-<span class="sourceLineNo">328</span> /**<a name="line.328"></a>
-<span class="sourceLineNo">329</span> * Check if the specified snapshot is done<a name="line.329"></a>
-<span class="sourceLineNo">330</span> *<a name="line.330"></a>
-<span class="sourceLineNo">331</span> * @param expected<a name="line.331"></a>
-<span class="sourceLineNo">332</span> * @return true if snapshot is ready to be restored, false if it is still being taken.<a name="line.332"></a>
-<span class="sourceLineNo">333</span> * @throws IOException IOException if error from HDFS or RPC<a name="line.333"></a>
-<span class="sourceLineNo">334</span> * @throws UnknownSnapshotException if snapshot is invalid or does not exist.<a name="line.334"></a>
-<span class="sourceLineNo">335</span> */<a name="line.335"></a>
-<span class="sourceLineNo">336</span> public boolean isSnapshotDone(SnapshotDescription expected) throws IOException {<a name="line.336"></a>
-<span class="sourceLineNo">337</span> // check the request to make sure it has a snapshot<a name="line.337"></a>
-<span class="sourceLineNo">338</span> if (expected == null) {<a name="line.338"></a>
-<span class="sourceLineNo">339</span> throw new UnknownSnapshotException(<a name="line.339"></a>
-<span class="sourceLineNo">340</span> "No snapshot name passed in request, can't figure out which snapshot you want to check.");<a name="line.340"></a>
-<span class="sourceLineNo">341</span> }<a name="line.341"></a>
-<span class="sourceLineNo">342</span><a name="line.342"></a>
-<span class="sourceLineNo">343</span> String ssString = ClientSnapshotDescriptionUtils.toString(expected);<a name="line.343"></a>
-<span class="sourceLineNo">344</span><a name="line.344"></a>
-<span class="sourceLineNo">345</span> // check to see if the sentinel exists,<a name="line.345"></a>
-<span class="sourceLineNo">346</span> // and if the task is complete removes it from the in-progress snapshots map.<a name="line.346"></a>
-<span class="sourceLineNo">347</span> SnapshotSentinel handler = removeSentinelIfFinished(this.snapshotHandlers, expected);<a name="line.347"></a>
-<span class="sourceLineNo">348</span><a name="line.348"></a>
-<span class="sourceLineNo">349</span> // stop tracking "abandoned" handlers<a name="line.349"></a>
-<span class="sourceLineNo">350</span> cleanupSentinels();<a name="line.350"></a>
-<span class="sourceLineNo">351</span><a name="line.351"></a>
-<span class="sourceLineNo">352</span> if (handler == null) {<a name="line.352"></a>
-<span class="sourceLineNo">353</span> // If there's no handler in the in-progress map, it means one of the following:<a name="line.353"></a>
-<span class="sourceLineNo">354</span> // - someone has already requested the snapshot state<a name="line.354"></a>
-<span class="sourceLineNo">355</span> // - the requested snapshot was completed long time ago (cleanupSentinels() timeout)<a name="line.355"></a>
-<span class="sourceLineNo">356</span> // - the snapshot was never requested<a name="line.356"></a>
-<span class="sourceLineNo">357</span> // In those cases returns to the user the "done state" if the snapshots exists on disk,<a name="line.357"></a>
-<span class="sourceLineNo">358</span> // otherwise raise an exception saying that the snapshot is not running and doesn't exist.<a name="line.358"></a>
-<span class="sourceLineNo">359</span> if (!isSnapshotCompleted(expected)) {<a name="line.359"></a>
-<span class="sourceLineNo">360</span> throw new UnknownSnapshotException("Snapshot " + ssString<a name="line.360"></a>
-<span class="sourceLineNo">361</span> + " is not currently running or one of the known completed snapshots.");<a name="line.361"></a>
-<span class="sourceLineNo">362</span> }<a name="line.362"></a>
-<span class="sourceLineNo">363</span> // was done, return true;<a name="line.363"></a>
-<span class="sourceLineNo">364</span> return true;<a name="line.364"></a>
-<span class="sourceLineNo">365</span> }<a name="line.365"></a>
-<span class="sourceLineNo">366</span><a name="line.366"></a>
-<span class="sourceLineNo">367</span> // pass on any failure we find in the sentinel<a name="line.367"></a>
-<span class="sourceLineNo">368</span> try {<a name="line.368"></a>
-<span class="sourceLineNo">369</span> handler.rethrowExceptionIfFailed();<a name="line.369"></a>
-<span class="sourceLineNo">370</span> } catch (ForeignException e) {<a name="line.370"></a>
-<span class="sourceLineNo">371</span> // Give some procedure info on an exception.<a name="line.371"></a>
-<span class="sourceLineNo">372</span> String status;<a name="line.372"></a>
-<span class="sourceLineNo">373</span> Procedure p = coordinator.getProcedure(expected.getName());<a name="line.373"></a>
-<span class="sourceLineNo">374</span> if (p != null) {<a name="line.374"></a>
-<span class="sourceLineNo">375</span> status = p.getStatus();<a name="line.375"></a>
-<span class="sourceLineNo">376</span> } else {<a name="line.376"></a>
-<span class="sourceLineNo">377</span> status = expected.getName() + " not found in proclist " + coordinator.getProcedureNames();<a name="line.377"></a>
+<span class="sourceLineNo">315</span> String snapshotName = snapshot.getName();<a name="line.315"></a>
+<span class="sourceLineNo">316</span> // first create the snapshot description and check to see if it exists<a name="line.316"></a>
+<span class="sourceLineNo">317</span> FileSystem fs = master.getMasterFileSystem().getFileSystem();<a name="line.317"></a>
+<span class="sourceLineNo">318</span> Path snapshotDir = SnapshotDescriptionUtils.getCompletedSnapshotDir(snapshotName, rootDir);<a name="line.318"></a>
+<span class="sourceLineNo">319</span> // Get snapshot info from file system. The one passed as parameter is a "fake" snapshotInfo with<a name="line.319"></a>
+<span class="sourceLineNo">320</span> // just the "name" and it does not contains the "real" snapshot information<a name="line.320"></a>
+<span class="sourceLineNo">321</span> snapshot = SnapshotDescriptionUtils.readSnapshotInfo(fs, snapshotDir);<a name="line.321"></a>
+<span class="sourceLineNo">322</span><a name="line.322"></a>
+<span class="sourceLineNo">323</span> // call coproc pre hook<a name="line.323"></a>
+<span class="sourceLineNo">324</span> MasterCoprocessorHost cpHost = master.getMasterCoprocessorHost();<a name="line.324"></a>
+<span class="sourceLineNo">325</span> org.apache.hadoop.hbase.client.SnapshotDescription snapshotPOJO = null;<a name="line.325"></a>
+<span class="sourceLineNo">326</span> if (cpHost != null) {<a name="line.326"></a>
+<span class="sourceLineNo">327</span> snapshotPOJO = ProtobufUtil.createSnapshotDesc(snapshot);<a name="line.327"></a>
+<span class="sourceLineNo">328</span> cpHost.preDeleteSnapshot(snapshotPOJO);<a name="line.328"></a>
+<span class="sourceLineNo">329</span> }<a name="line.329"></a>
+<span class="sourceLineNo">330</span><a name="line.330"></a>
+<span class="sourceLineNo">331</span> LOG.debug("Deleting snapshot: " + snapshotName);<a name="line.331"></a>
+<span class="sourceLineNo">332</span> // delete the existing snapshot<a name="line.332"></a>
+<span class="sourceLineNo">333</span> if (!fs.delete(snapshotDir, true)) {<a name="line.333"></a>
+<span class="sourceLineNo">334</span> throw new HBaseSnapshotException("Failed to delete snapshot directory: " + snapshotDir);<a name="line.334"></a>
+<span class="sourceLineNo">335</span> }<a name="line.335"></a>
+<span class="sourceLineNo">336</span><a name="line.336"></a>
+<span class="sourceLineNo">337</span> // call coproc post hook<a name="line.337"></a>
+<span class="sourceLineNo">338</span> if (cpHost != null) {<a name="line.338"></a>
+<span class="sourceLineNo">339</span> cpHost.postDeleteSnapshot(snapshotPOJO);<a name="line.339"></a>
+<span class="sourceLineNo">340</span> }<a name="line.340"></a>
+<span class="sourceLineNo">341</span><a name="line.341"></a>
+<span class="sourceLineNo">342</span> }<a name="line.342"></a>
+<span class="sourceLineNo">343</span><a name="line.343"></a>
+<span class="sourceLineNo">344</span> /**<a name="line.344"></a>
+<span class="sourceLineNo">345</span> * Check if the specified snapshot is done<a name="line.345"></a>
+<span class="sourceLineNo">346</span> *<a name="line.346"></a>
+<span class="sourceLineNo">347</span> * @param expected<a name="line.347"></a>
+<span class="sourceLineNo">348</span> * @return true if snapshot is ready to be restored, false if it is still being taken.<a name="line.348"></a>
+<span class="sourceLineNo">349</span> * @throws IOException IOException if error from HDFS or RPC<a name="line.349"></a>
+<span class="sourceLineNo">350</span> * @throws UnknownSnapshotException if snapshot is invalid or does not exist.<a name="line.350"></a>
+<span class="sourceLineNo">351</span> */<a name="line.351"></a>
+<span class="sourceLineNo">352</span> public boolean isSnapshotDone(SnapshotDescription expected) throws IOException {<a name="line.352"></a>
+<span class="sourceLineNo">353</span> // check the request to make sure it has a snapshot<a name="line.353"></a>
+<span class="sourceLineNo">354</span> if (expected == null) {<a name="line.354"></a>
+<span class="sourceLineNo">355</span> throw new UnknownSnapshotException(<a name="line.355"></a>
+<span class="sourceLineNo">356</span> "No snapshot name passed in request, can't figure out which snapshot you want to check.");<a name="line.356"></a>
+<span class="sourceLineNo">357</span> }<a name="line.357"></a>
+<span class="sourceLineNo">358</span><a name="line.358"></a>
+<span class="sourceLineNo">359</span> String ssString = ClientSnapshotDescriptionUtils.toString(expected);<a name="line.359"></a>
+<span class="sourceLineNo">360</span><a name="line.360"></a>
+<span class="sourceLineNo">361</span> // check to see if the sentinel exists,<a name="line.361"></a>
+<span class="sourceLineNo">362</span> // and if the task is complete removes it from the in-progress snapshots map.<a name="line.362"></a>
+<span class="sourceLineNo">363</span> SnapshotSentinel handler = removeSentinelIfFinished(this.snapshotHandlers, expected);<a name="line.363"></a>
+<span class="sourceLineNo">364</span><a name="line.364"></a>
+<span class="sourceLineNo">365</span> // stop tracking "abandoned" handlers<a name="line.365"></a>
+<span class="sourceLineNo">366</span> cleanupSentinels();<a name="line.366"></a>
+<span class="sourceLineNo">367</span><a name="line.367"></a>
+<span class="sourceLineNo">368</span> if (handler == null) {<a name="line.368"></a>
+<span class="sourceLineNo">369</span> // If there's no handler in the in-progress map, it means one of the following:<a name="line.369"></a>
+<span class="sourceLineNo">370</span> // - someone has already requested the snapshot state<a name="line.370"></a>
+<span class="sourceLineNo">371</span> // - the requested snapshot was completed long time ago (cleanupSentinels() timeout)<a name="line.371"></a>
+<span class="sourceLineNo">372</span> // - the snapshot was never requested<a name="line.372"></a>
+<span class="sourceLineNo">373</span> // In those cases returns to the user the "done state" if the snapshots exists on disk,<a name="line.373"></a>
+<span class="sourceLineNo">374</span> // otherwise raise an exception saying that the snapshot is not running and doesn't exist.<a name="line.374"></a>
+<span class="sourceLineNo">375</span> if (!isSnapshotCompleted(expected)) {<a name="line.375"></a>
+<span class="sourceLineNo">376</span> throw new UnknownSnapshotException("Snapshot " + ssString<a name="line.376"></a>
+<span class="sourceLineNo">377</span> + " is not currently running or one of the known completed snapshots.");<a name="line.377"></a>
<span class="sourceLineNo">378</span> }<a name="line.378"></a>
-<span class="sourceLineNo">379</span> throw new HBaseSnapshotException("Snapshot " + ssString + " had an error. " + status, e,<a name="line.379"></a>
-<span class="sourceLineNo">380</span> ProtobufUtil.createSnapshotDesc(expected));<a name="line.380"></a>
+<span class="sourceLineNo">379</span> // was done, return true;<a name="line.379"></a>
+<span class="sourceLineNo">380</span> return true;<a name="line.380"></a>
<span class="sourceLineNo">381</span> }<a name="line.381"></a>
<span class="sourceLineNo">382</span><a name="line.382"></a>
-<span class="sourceLineNo">383</span> // check to see if we are done<a name="line.383"></a>
-<span class="sourceLineNo">384</span> if (handler.isFinished()) {<a name="line.384"></a>
-<span class="sourceLineNo">385</span> LOG.debug("Snapshot '" + ssString + "' has completed, notifying client.");<a name="line.385"></a>
-<span class="sourceLineNo">386</span> return true;<a name="line.386"></a>
-<span class="sourceLineNo">387</span> } else if (LOG.isDebugEnabled()) {<a name="line.387"></a>
-<span class="sourceLineNo">388</span> LOG.debug("Snapshoting '" + ssString + "' is still in progress!");<a name="line.388"></a>
-<span class="sourceLineNo">389</span> }<a name="line.389"></a>
-<span class="sourceLineNo">390</span> return false;<a name="line.390"></a>
-<span class="sourceLineNo">391</span> }<a name="line.391"></a>
-<span class="sourceLineNo">392</span><a name="line.392"></a>
-<span class="sourceLineNo">393</span> /**<a name="line.393"></a>
-<span class="sourceLineNo">394</span> * Check to see if there is a snapshot in progress with the same name or on the same table.<a name="line.394"></a>
-<span class="sourceLineNo">395</span> * Currently we have a limitation only allowing a single snapshot per table at a time. Also we<a name="line.395"></a>
-<span class="sourceLineNo">396</span> * don't allow snapshot with the same name.<a name="line.396"></a>
-<span class="sourceLineNo">397</span> * @param snapshot description of the snapshot being checked.<a name="line.397"></a>
-<span class="sourceLineNo">398</span> * @return <tt>true</tt> if there is a snapshot in progress with the same name or on the same<a name="line.398"></a>
-<span class="sourceLineNo">399</span> * table.<a name="line.399"></a>
-<span class="sourceLineNo">400</span> */<a name="line.400"></a>
-<span class="sourceLineNo">401</span> synchronized boolean isTakingSnapshot(final SnapshotDescription snapshot) {<a name="line.401"></a>
-<span class="sourceLineNo">402</span> TableName snapshotTable = TableName.valueOf(snapshot.getTable());<a name="line.402"></a>
-<span class="sourceLineNo">403</span> if (isTakingSnapshot(snapshotTable)) {<a name="line.403"></a>
-<span class="sourceLineNo">404</span> return true;<a name="line.404"></a>
+<span class="sourceLineNo">383</span> // pass on any failure we find in the sentinel<a name="line.383"></a>
+<span class="sourceLineNo">384</span> try {<a name="line.384"></a>
+<span class="sourceLineNo">385</span> handler.rethrowExceptionIfFailed();<a name="line.385"></a>
+<span class="sourceLineNo">386</span> } catch (ForeignException e) {<a name="line.386"></a>
+<span class="sourceLineNo">387</span> // Give some procedure info on an exception.<a name="line.387"></a>
+<span class="sourceLineNo">388</span> String status;<a name="line.388"></a>
+<span class="sourceLineNo">389</span> Procedure p = coordinator.getProcedure(expected.getName());<a name="line.389"></a>
+<span class="sourceLineNo">390</span> if (p != null) {<a name="line.390"></a>
+<span class="sourceLineNo">391</span> status = p.getStatus();<a name="line.391"></a>
+<span class="sourceLineNo">392</span> } else {<a name="line.392"></a>
+<span class="sourceLineNo">393</span> status = expected.getName() + " not found in proclist " + coordinator.getProcedureNames();<a name="line.393"></a>
+<span class="sourceLineNo">394</span> }<a name="line.394"></a>
+<span class="sourceLineNo">395</span> throw new HBaseSnapshotException("Snapshot " + ssString + " had an error. " + status, e,<a name="line.395"></a>
+<span class="sourceLineNo">396</span> ProtobufUtil.createSnapshotDesc(expected));<a name="line.396"></a>
+<span class="sourceLineNo">397</span> }<a name="line.397"></a>
+<span class="sourceLineNo">398</span><a name="line.398"></a>
+<span class="sourceLineNo">399</span> // check to see if we are done<a name="line.399"></a>
+<span class="sourceLineNo">400</span> if (handler.isFinished()) {<a name="line.400"></a>
+<span class="sourceLineNo">401</span> LOG.debug("Snapshot '" + ssString + "' has completed, notifying client.");<a name="line.401"></a>
+<span class="sourceLineNo">402</span> return true;<a name="line.402"></a>
+<span class="sourceLineNo">403</span> } else if (LOG.isDebugEnabled()) {<a name="line.403"></a>
+<span class="sourceLineNo">404</span> LOG.debug("Snapshoting '" + ssString + "' is still in progress!");<a name="line.404"></a>
<span class="sourceLineNo">405</span> }<a name="line.405"></a>
-<span class="sourceLineNo">406</span> Iterator<Map.Entry<TableName, SnapshotSentinel>> it = this.snapshotHandlers.entrySet().iterator();<a name="line.406"></a>
-<span class="sourceLineNo">407</span> while (it.hasNext()) {<a name="line.407"></a>
-<span class="sourceLineNo">408</span> Map.Entry<TableName, SnapshotSentinel> entry = it.next();<a name="line.408"></a>
-<span class="sourceLineNo">409</span> SnapshotSentinel sentinel = entry.getValue();<a name="line.409"></a>
-<span class="sourceLineNo">410</span> if (snapshot.getName().equals(sentinel.getSnapshot().getName()) && !sentinel.isFinished()) {<a name="line.410"></a>
-<span class="sourceLineNo">411</span> return true;<a name="line.411"></a>
-<span class="sourceLineNo">412</span> }<a name="line.412"></a>
-<span class="sourceLineNo">413</span> }<a name="line.413"></a>
-<span class="sourceLineNo">414</span> return false;<a name="line.414"></a>
-<span class="sourceLineNo">415</span> }<a name="line.415"></a>
-<span class="sourceLineNo">416</span><a name="line.416"></a>
-<span class="sourceLineNo">417</span> /**<a name="line.417"></a>
-<span class="sourceLineNo">418</span> * Check to see if the specified table has a snapshot in progress. Currently we have a<a name="line.418"></a>
-<span class="sourceLineNo">419</span> * limitation only allowing a single snapshot per table at a time.<a name="line.419"></a>
-<span class="sourceLineNo">420</span> * @param tableName name of the table being snapshotted.<a name="line.420"></a>
-<span class="sourceLineNo">421</span> * @return <tt>true</tt> if there is a snapshot in progress on the specified table.<a name="line.421"></a>
-<span class="sourceLineNo">422</span> */<a name="line.422"></a>
-<span class="sourceLineNo">423</span> public boolean isTakingSnapshot(final TableName tableName) {<a name="line.423"></a>
-<span class="sourceLineNo">424</span> SnapshotSentinel handler = this.snapshotHandlers.get(tableName);<a name="line.424"></a>
-<span class="sourceLineNo">425</span> return handler != null && !handler.isFinished();<a name="line.425"></a>
-<span class="sourceLineNo">426</span> }<a name="line.426"></a>
-<span class="sourceLineNo">427</span><a name="line.427"></a>
-<span class="sourceLineNo">428</span> /**<a name="line.428"></a>
-<span class="sourceLineNo">429</span> * Check to make sure that we are OK to run the passed snapshot. Checks to make sure that we<a name="line.429"></a>
-<span class="sourceLineNo">430</span> * aren't already running a snapshot or restore on the requested table.<a name="line.430"></a>
-<span class="sourceLineNo">431</span> * @param snapshot description of the snapshot we want to start<a name="line.431"></a>
-<span class="sourceLineNo">432</span> * @throws HBaseSnapshotException if the filesystem could not be prepared to start the snapshot<a name="line.432"></a>
-<span class="sourceLineNo">433</span> */<a name="line.433"></a>
-<span class="sourceLineNo">434</span> private synchronized void prepareToTakeSnapshot(SnapshotDescription snapshot)<a name="line.434"></a>
-<span class="sourceLineNo">435</span> throws HBaseSnapshotException {<a name="line.435"></a>
-<span class="sourceLineNo">436</span> Path workingDir = SnapshotDescriptionUtils.getWorkingSnapshotDir(snapshot, rootDir,<a name="line.436"></a>
-<span class="sourceLineNo">437</span> master.getConfiguration());<a name="line.437"></a>
-<span class="sourceLineNo">438</span> TableName snapshotTable =<a name="line.438"></a>
-<span class="sourceLineNo">439</span> TableName.valueOf(snapshot.getTable());<a name="line.439"></a>
-<span class="sourceLineNo">440</span><a name="line.440"></a>
-<span class="sourceLineNo">441</span> // make sure we aren't already running a snapshot<a name="line.441"></a>
-<span class="sourceLineNo">442</span> if (isTakingSnapshot(snapshot)) {<a name="line.442"></a>
-<span class="sourceLineNo">443</span> SnapshotSentinel handler = this.snapshotHandlers.get(snapshotTable);<a name="line.443"></a>
-<span class="sourceLineNo">444</span> throw new SnapshotCreationException("Rejected taking "<a name="line.444"></a>
-<span class="sourceLineNo">445</span> + ClientSnapshotDescriptionUtils.toString(snapshot)<a name="line.445"></a>
-<span class="sourceLineNo">446</span> + " because we are already running another snapshot "<a name="line.446"></a>
-<span class="sourceLineNo">447</span> + (handler != null ? ("on the same table " +<a name="line.447"></a>
-<span class="sourceLineNo">448</span> ClientSnapshotDescriptionUtils.toString(handler.getSnapshot()))<a name="line.448"></a>
-<span class="sourceLineNo">449</span> : "with the same name"), ProtobufUtil.createSnapshotDesc(snapshot));<a name="line.449"></a>
-<span class="sourceLineNo">450</span> }<a name="line.450"></a>
-<span class="sourceLineNo">451</span><a name="line.451"></a>
-<span class="sourceLineNo">452</span> // make sure we aren't running a restore on the same table<a name="line.452"></a>
-<span class="sourceLineNo">453</span> if (isRestoringTable(snapshotTable)) {<a name="line.453"></a>
-<span class="sourceLineNo">454</span> throw new SnapshotCreationException("Rejected taking "<a name="line.454"></a>
-<span class="sourceLineNo">455</span> + ClientSnapshotDescriptionUtils.toString(snapshot)<a name="line.455"></a>
-<span class="sourceLineNo">456</span> + " because we are already have a restore in progress on the same snapshot.");<a name="line.456"></a>
-<span class="sourceLineNo">457</span> }<a name="line.457"></a>
-<span class="sourceLineNo">458</span><a name="line.458"></a>
-<span class="sourceLineNo">459</span> try {<a name="line.459"></a>
-<span class="sourceLineNo">460</span> FileSystem workingDirFS = workingDir.getFileSystem(master.getConfiguration());<a name="line.460"></a>
-<span class="sourceLineNo">461</span> // delete the working directory, since we aren't running the snapshot. Likely leftovers<a name="line.461"></a>
-<span class="sourceLineNo">462</span> // from a failed attempt.<a name="line.462"></a>
-<span class="sourceLineNo">463</span> workingDirFS.delete(workingDir, true);<a name="line.463"></a>
-<span class="sourceLineNo">464</span><a name="line.464"></a>
-<span class="sourceLineNo">465</span> // recreate the working directory for the snapshot<a name="line.465"></a>
-<span class="sourceLineNo">466</span> if (!workingDirFS.mkdirs(workingDir)) {<a name="line.466"></a>
-<span class="sourceLineNo">467</span> throw new SnapshotCreationException("Couldn't create working directory (" + workingDir<a name="line.467"></a>
-<span class="sourceLineNo">468</span> + ") for snapshot" , ProtobufUtil.createSnapshotDesc(snapshot));<a name="line.468"></a>
-<span class="sourceLineNo">469</span> }<a name="line.469"></a>
-<span class="sourceLineNo">470</span> } catch (HBaseSnapshotException e) {<a name="line.470"></a>
-<span class="sourceLineNo">471</span> throw e;<a name="line.471"></a>
-<span class="sourceLineNo">472</span> } catch (IOException e) {<a name="line.472"></a>
-<span class="sourceLineNo">473</span> throw new SnapshotCreationException(<a name="line.473"></a>
-<span class="sourceLineNo">474</span> "Exception while checking to see if snapshot could be started.", e,<a name="line.474"></a>
-<span class="sourceLineNo">475</span> ProtobufUtil.createSnapshotDesc(snapshot));<a name="line.475"></a>
-<span class="sourceLineNo">476</span> }<a name="line.476"></a>
-<span class="sourceLineNo">477</span> }<a name="line.477"></a>
-<span class="sourceLineNo">478</span><a name="line.478"></a>
-<span class="sourceLineNo">479</span> /**<a name="line.479"></a>
-<span class="sourceLineNo">480</span> * Take a snapshot of a disabled table.<a name="line.480"></a>
-<span class="sourceLineNo">481</span> * @param snapshot description of the snapshot to take. Modified to be {@link Type#DISABLED}.<a name="line.481"></a>
-<span class="sourceLineNo">482</span> * @throws IOException if the snapshot could not be started or filesystem for snapshot<a name="line.482"></a>
-<span class="sourceLineNo">483</span> * temporary directory could not be determined<a name="line.483"></a>
-<span class="sourceLineNo">484</span> */<a name="line.484"></a>
-<span class="sourceLineNo">485</span> private synchronized void snapshotDisabledTable(SnapshotDescription snapshot)<a name="line.485"></a>
-<span class="sourceLineNo">486</span> throws IOException {<a name="line.486"></a>
-<span class="sourceLineNo">487</span> // setup the snapshot<a name="line.487"></a>
-<span class="sourceLineNo">488</span> prepareToTakeSnapshot(snapshot);<a name="line.488"></a>
-<span class="sourceLineNo">489</span><a name="line.489"></a>
-<span class="sourceLineNo">490</span> // set the snapshot to be a disabled snapshot, since the client doesn't know about that<a name="line.490"></a>
-<span class="sourceLineNo">491</span> snapshot = snapshot.toBuilder().setType(Type.DISABLED).build();<a name="line.491"></a>
-<span class="sourceLineNo">492</span><a name="line.492"></a>
-<span class="sourceLineNo">493</span> // Take the snapshot of the disabled table<a name="line.493"></a>
-<span class="sourceLineNo">494</span> DisabledTableSnapshotHandler handler =<a name="line.494"></a>
-<span class="sourceLineNo">495</span> new DisabledTableSnapshotHandler(snapshot, master, this);<a name="line.495"></a>
-<span class="sourceLineNo">496</span> snapshotTable(snapshot, handler);<a name="line.496"></a>
-<span class="sourceLineNo">497</span> }<a name="line.497"></a>
-<span class="so
<TRUNCATED>