[GitHub] morningman commented on a change in pull request #333: Add distributor which schedule task to be fairly

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #333: Add distributor which schedule task to be fairly
URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235582623
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java
 ##########
 @@ -107,37 +160,93 @@ public void addRoutineLoadTasks(List<RoutineLoadTask> routineLoadTaskList) {
         }
     }
 
-    public Map<Long, RoutineLoadTask> getIdToRoutineLoadTask() {
-        return idToRoutineLoadTask;
+    public Map<Long, RoutineLoadTaskInfo> getIdToRoutineLoadTask() {
+        readLock();
 
 Review comment:
   This lock protects nothing...
   After the caller gets 'idToRoutineLoadTask', it can do anything without lock protection.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org