[GitHub] [ozone] jojochuang commented on a change in pull request #2453: HDDS 5485. Add new OM DB tables for AssignUserToTenant

[GitBox <gi...@apache.org>]

jojochuang commented on a change in pull request #2453:
URL: https://github.com/apache/ozone/pull/2453#discussion_r677106282



##########
File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmDBAccessIdInfo.java
##########
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+package org.apache.hadoop.ozone.om.helpers;
+
+import com.google.common.base.Preconditions;
+import org.apache.hadoop.hdds.StringUtils;
+
+/**
+ * This class is used for storing Ozone tenant accessId info.
+ */
+public final class OmDBAccessIdInfo {
+  /**
+   * Name of the tenant.
+   */
+  private final String tenantId;
+  /**
+   * Kerberos principal this accessId belongs to.
+   */
+  private final String kerberosPrincipal;
+  /**
+   * Shared secret of the accessId. TODO: Encryption?
+   */
+  private final String sharedSecret;
+
+  // This implies above String fields should NOT contain the split key.
+  public static final String SERIALIZATION_SPLIT_KEY = ";";
+
+  public OmDBAccessIdInfo(String tenantId,
+      String kerberosPrincipal, String sharedSecret) {
+    this.tenantId = tenantId;
+    this.kerberosPrincipal = kerberosPrincipal;
+    this.sharedSecret = sharedSecret;
+  }
+
+  private OmDBAccessIdInfo(String accessIdInfoString) {
+    String[] tInfo = accessIdInfoString.split(SERIALIZATION_SPLIT_KEY);
+    Preconditions.checkState(tInfo.length == 3,
+        "Incorrect accessIdInfoString");
+
+    tenantId = tInfo[0];
+    kerberosPrincipal = tInfo[1];
+    sharedSecret = tInfo[2];
+  }
+
+  public String getTenantId() {
+    return tenantId;
+  }
+
+  private String serialize() {
+    StringBuilder sb = new StringBuilder();
+    sb.append(tenantId).append(SERIALIZATION_SPLIT_KEY);
+    sb.append(kerberosPrincipal).append(SERIALIZATION_SPLIT_KEY);
+    sb.append(sharedSecret);
+    return sb.toString();
+  }
+
+  /**
+   * Convert OmDBAccessIdInfo to byteArray to be persisted to DB.
+   * @return byte[]
+   */
+  public byte[] convertToByteArray() {
+    return StringUtils.string2Bytes(serialize());

Review comment:
       i understand this is the same pattern used elsewhere, but i wonder is it memory efficient. It might save some by skipping constructing the String object.
   (fwiw i don't see StringUtils.string2Bytes() nor StringUtils.bytes2String() popping up in profiler yet)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org