You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by an...@apache.org on 2015/05/27 20:42:07 UTC
spark git commit: [SPARK-7864] [UI] Fix the logic grabbing the link
from table in AllJobPage
Repository: spark
Updated Branches:
refs/heads/master 15459db4f -> 0db76c90a
[SPARK-7864] [UI] Fix the logic grabbing the link from table in AllJobPage
This issue is related to #6419 .
Now AllJobPage doesn't have a "kill link" but I think fix the issue mentioned in #6419 just in case to avoid accidents in the future.
So, it's minor issue for now and I don't file this issue in JIRA.
Author: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Closes #6432 from sarutak/remove-ambiguity-of-link and squashes the following commits:
cd1a503 [Kousuke Saruta] Fixed ambiguity link issue in AllJobPage
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/0db76c90
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/0db76c90
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/0db76c90
Branch: refs/heads/master
Commit: 0db76c90ad5f84d7a5640c41de74876b906ddc90
Parents: 15459db
Author: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Authored: Wed May 27 11:41:35 2015 -0700
Committer: Andrew Or <an...@databricks.com>
Committed: Wed May 27 11:41:37 2015 -0700
----------------------------------------------------------------------
.../src/main/resources/org/apache/spark/ui/static/timeline-view.js | 2 +-
core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/0db76c90/core/src/main/resources/org/apache/spark/ui/static/timeline-view.js
----------------------------------------------------------------------
diff --git a/core/src/main/resources/org/apache/spark/ui/static/timeline-view.js b/core/src/main/resources/org/apache/spark/ui/static/timeline-view.js
index 28ac998..ca74ef9 100644
--- a/core/src/main/resources/org/apache/spark/ui/static/timeline-view.js
+++ b/core/src/main/resources/org/apache/spark/ui/static/timeline-view.js
@@ -46,7 +46,7 @@ function drawApplicationTimeline(groupArray, eventObjArray, startTime) {
};
$(this).click(function() {
- var jobPagePath = $(getSelectorForJobEntry(this)).find("a").attr("href")
+ var jobPagePath = $(getSelectorForJobEntry(this)).find("a.name-link").attr("href")
window.location.href = jobPagePath
});
http://git-wip-us.apache.org/repos/asf/spark/blob/0db76c90/core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala b/core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
index e010ebe..2ce670a 100644
--- a/core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
+++ b/core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
@@ -231,7 +231,7 @@ private[ui] class AllJobsPage(parent: JobsTab) extends WebUIPage("") {
</td>
<td>
<span class="description-input" title={lastStageDescription}>{lastStageDescription}</span>
- <a href={detailUrl}>{lastStageName}</a>
+ <a href={detailUrl} class="name-link">{lastStageName}</a>
</td>
<td sorttable_customkey={job.submissionTime.getOrElse(-1).toString}>
{formattedSubmissionTime}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org