You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/02/21 01:27:00 UTC

[jira] [Updated] (GEOMETRY-88) Revert Facet to ConvexSubPlane name change

     [ https://issues.apache.org/jira/browse/GEOMETRY-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated GEOMETRY-88:
-----------------------------------
    Labels: pull-request-available  (was: )

> Revert Facet to ConvexSubPlane name change
> ------------------------------------------
>
>                 Key: GEOMETRY-88
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-88
>             Project: Apache Commons Geometry
>          Issue Type: Task
>            Reporter: Matt Juntunen
>            Priority: Major
>              Labels: pull-request-available
>
> GEOMETRY-81 changed the name of the {{ConvexSubPlane}} class to {{Facet}}. However, after working more with this, I've come to believe that this is not actually a good name choice for a couple of reasons:
> 1. It implies that the subhyperplane lies on the boundary of a region, which is very often not the case (as GEOMETRY-74 reinforces).
> 2. It prevents us from using the name {{Facet}} for more relevant objects related to 3D modeling.
> So, I think we should revert this name change.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)