You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by "Hongchao Deng (JIRA)" <ji...@apache.org> on 2014/07/18 23:02:07 UTC

[jira] [Updated] (ZOOKEEPER-1970) Fix Findbugs Warnings

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hongchao Deng updated ZOOKEEPER-1970:
-------------------------------------

    Description: 
The findbugs complained a lot of warnings after upgrade:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2191//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html#Warnings_I18N

It would be great to get those warnings settled before 3.5.0 release.

My proposal is:
1. Ignore those "Internationalization Warnings" which is related to encoding. And create a new JIRA to fix encoding later.
2. fix warnnings of:
  * Multithreaded correctness Warnings
  * Performance Warnings
  * Dodgy code Warnings

  was:
The findbugs complained a lot of warnings after upgrade:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2191//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html#Warnings_I18N

It would be great to get those warnings settled.
My proposal is:
1. Ignore those "Internationalization Warnings" which is related to encoding so far. And create a new JIRA to fix encoding later.
2. Use separate JIRAs to fix the rest warnnings one type by another:
  * Multithreaded correctness Warnings
  * Performance Warnings
  * Dodgy code Warnings


> Fix Findbugs Warnings
> ---------------------
>
>                 Key: ZOOKEEPER-1970
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1970
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Hongchao Deng
>            Assignee: Hongchao Deng
>             Fix For: 3.5.0
>
>
> The findbugs complained a lot of warnings after upgrade:
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2191//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html#Warnings_I18N
> It would be great to get those warnings settled before 3.5.0 release.
> My proposal is:
> 1. Ignore those "Internationalization Warnings" which is related to encoding. And create a new JIRA to fix encoding later.
> 2. fix warnnings of:
>   * Multithreaded correctness Warnings
>   * Performance Warnings
>   * Dodgy code Warnings



--
This message was sent by Atlassian JIRA
(v6.2#6252)