[GitHub] [apisix] tzssangglass commented on a diff in pull request #6854: fix(authz-keycloak): do not expose internal errors to the client

[GitBox <gi...@apache.org>]

tzssangglass commented on code in PR #6854:
URL: https://github.com/apache/apisix/pull/6854#discussion_r851701527


##########
apisix/plugins/authz-keycloak.lua:
##########
@@ -722,12 +722,12 @@ local function generate_token_using_password_grant(conf,ctx)
     if not username then
         local err = "username is missing."
         log.error(err)
-        return 422, err
+        return 422, {message = err}

Review Comment:
   add



##########
apisix/plugins/authz-keycloak.lua:
##########
@@ -722,12 +722,12 @@ local function generate_token_using_password_grant(conf,ctx)
     if not username then
         local err = "username is missing."
         log.error(err)
-        return 422, err
+        return 422, {message = err}
     end
     if not password then
         local err = "password is missing."
         log.error(err)
-        return 422, err
+        return 422, {message = err}

Review Comment:
   add



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org