You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/12/16 19:13:47 UTC
[kudu-CR] [thirdparty] Fix curl build on SLES
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16883
Change subject: [thirdparty] Fix curl build on SLES
......................................................................
[thirdparty] Fix curl build on SLES
SLES does not put the krb5-config in /usr/bin as curl expects.
Instead krb5-config is installed into `/usr/lib/mit/bin/`.
Additionally it doesn’t put that location on the `PATH` by default,
which means that the `which` command can fail to find it.
Building curl with an empty KRB5CONFIG results in the following
error:
configure: error: one or more libs available at link-time are not available run-time. Libs used at link-time: -lgssapi
This patch fixes the issue for more common/default environments by
falling back to the special SLES krb5_config location if one is not found
and the file exists.
Change-Id: I0961865a00601431bbc833360590cafa3aaf65c6
---
M thirdparty/build-definitions.sh
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/16883/1
--
To view, visit http://gerrit.cloudera.org:8080/16883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0961865a00601431bbc833360590cafa3aaf65c6
Gerrit-Change-Number: 16883
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [thirdparty] Fix curl build on SLES
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16883 )
Change subject: [thirdparty] Fix curl build on SLES
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh@700
PS1, Line 700: fi
:
> It's not a problem to have empty KRB5CONFIG if the curl is smart enough to
I meant that curl might be able to guess on the location of the krb5-config elsewhere, so having KRB5CONFIG empty might be not a problem elsewhere but on SLES.
And yes: we know that our current version of curl isn't able to detect krb5-config on SLES, so I guess we don't need to check if curl is smart enough in case of SLES :)
--
To view, visit http://gerrit.cloudera.org:8080/16883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0961865a00601431bbc833360590cafa3aaf65c6
Gerrit-Change-Number: 16883
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Dec 2020 20:01:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Fix curl build on SLES
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16883 )
Change subject: [thirdparty] Fix curl build on SLES
......................................................................
[thirdparty] Fix curl build on SLES
SLES does not put the krb5-config in /usr/bin as curl expects.
Instead krb5-config is installed into `/usr/lib/mit/bin/`.
Additionally it doesn’t put that location on the `PATH` by default,
which means that the `which` command can fail to find it.
Building curl with an empty KRB5CONFIG results in the following
error:
configure: error: one or more libs available at link-time are not available run-time. Libs used at link-time: -lgssapi
This patch fixes the issue for more common/default environments by
falling back to the special SLES krb5_config location if one is not found
and the file exists.
Change-Id: I0961865a00601431bbc833360590cafa3aaf65c6
Reviewed-on: http://gerrit.cloudera.org:8080/16883
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M thirdparty/build-definitions.sh
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0961865a00601431bbc833360590cafa3aaf65c6
Gerrit-Change-Number: 16883
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] Fix curl build on SLES
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16883 )
Change subject: [thirdparty] Fix curl build on SLES
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh@700
PS1, Line 700: fi
:
> It was logged in my environment given all the called exports are logged via
Right, though before this patch, there was no such export, and we found ourselves missing KRGB5CONFIG. Was it obvious then that KRGB5CONFIG was important and empty? If not, it might be worth adding a print statement here, in case we find ourselves with no KRGB5CONFIG, e.g. because SLES_KRB5CONFIG_LOCATION is missing
--
To view, visit http://gerrit.cloudera.org:8080/16883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0961865a00601431bbc833360590cafa3aaf65c6
Gerrit-Change-Number: 16883
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Dec 2020 19:46:29 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Fix curl build on SLES
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16883 )
Change subject: [thirdparty] Fix curl build on SLES
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh@700
PS1, Line 700: fi
:
> Better yet, should we fail the build if KRB5CONFIG is empty?
It's not a problem to have empty KRB5CONFIG if the curl is smart enough to find it on itself. The issue was that in case of SLES it wasn't smart enough to do that, so here we are setting that env variable. I guess it's worth trying to see whether current version of curl is already able to handle SLES case, and drop setting this env variable altogether.
--
To view, visit http://gerrit.cloudera.org:8080/16883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0961865a00601431bbc833360590cafa3aaf65c6
Gerrit-Change-Number: 16883
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Dec 2020 19:53:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Fix curl build on SLES
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16883 )
Change subject: [thirdparty] Fix curl build on SLES
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh@697
PS1, Line 697: SLES_KRB5CONFIG_LOCATION="/usr/lib/mit/bin/krb5-config"
> I didn't want to use it unless it exists and only after all else fails. I a
The idea was to put that as the default only in SLES case. But nevermind -- I guess all these nits aren't worth it.
--
To view, visit http://gerrit.cloudera.org:8080/16883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0961865a00601431bbc833360590cafa3aaf65c6
Gerrit-Change-Number: 16883
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Dec 2020 19:24:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Fix curl build on SLES
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16883 )
Change subject: [thirdparty] Fix curl build on SLES
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh@687
PS1, Line 687: (looking at you, SLES12's /usr/lib/mit/bin/krb5-config)
:)
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh@700
PS1, Line 700: fi
:
Would it have helped in debugging to have logged KRGB5CONFIG here? Or is this clear from existing logging?
--
To view, visit http://gerrit.cloudera.org:8080/16883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0961865a00601431bbc833360590cafa3aaf65c6
Gerrit-Change-Number: 16883
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Dec 2020 19:25:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Fix curl build on SLES
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16883 )
Change subject: [thirdparty] Fix curl build on SLES
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh@697
PS1, Line 697: SLES_KRB5CONFIG_LOCATION="/usr/lib/mit/bin/krb5-config"
> Why not just put that as the default for KRB5CONFIG_LOCATION at line 691?
Ah, I guess with all these band-aids it's already good as it is. Please ignore the former comment.
--
To view, visit http://gerrit.cloudera.org:8080/16883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0961865a00601431bbc833360590cafa3aaf65c6
Gerrit-Change-Number: 16883
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Dec 2020 19:23:29 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Fix curl build on SLES
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16883 )
Change subject: [thirdparty] Fix curl build on SLES
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh@700
PS1, Line 700: fi
:
> I meant that curl might be able to guess on the location of the krb5-config
This patch looks good to me, but I guess Andrew might have more feedback/ideas.
--
To view, visit http://gerrit.cloudera.org:8080/16883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0961865a00601431bbc833360590cafa3aaf65c6
Gerrit-Change-Number: 16883
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Dec 2020 20:03:37 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Fix curl build on SLES
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16883 )
Change subject: [thirdparty] Fix curl build on SLES
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh@700
PS1, Line 700: fi
:
> Would it have helped in debugging to have logged KRGB5CONFIG here? Or is th
It was logged in my environment given all the called exports are logged via `set -ex` in build-thirdparty.sh
--
To view, visit http://gerrit.cloudera.org:8080/16883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0961865a00601431bbc833360590cafa3aaf65c6
Gerrit-Change-Number: 16883
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Dec 2020 19:33:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Fix curl build on SLES
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16883 )
Change subject: [thirdparty] Fix curl build on SLES
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh@700
PS1, Line 700: fi
:
> This patch looks good to me, but I guess Andrew might have more feedback/id
I'm OK with the patch as is since it sounds like there's enough info to debug already.
--
To view, visit http://gerrit.cloudera.org:8080/16883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0961865a00601431bbc833360590cafa3aaf65c6
Gerrit-Change-Number: 16883
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Dec 2020 20:14:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Fix curl build on SLES
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16883 )
Change subject: [thirdparty] Fix curl build on SLES
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh@697
PS1, Line 697: SLES_KRB5CONFIG_LOCATION="/usr/lib/mit/bin/krb5-config"
> Why not just put that as the default for KRB5CONFIG_LOCATION at line 691?
I didn't want to use it unless it exists and only after all else fails. I also think it's nice "documentation as code" to show that this is only for SLES.
--
To view, visit http://gerrit.cloudera.org:8080/16883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0961865a00601431bbc833360590cafa3aaf65c6
Gerrit-Change-Number: 16883
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Dec 2020 19:23:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Fix curl build on SLES
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16883 )
Change subject: [thirdparty] Fix curl build on SLES
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh@700
PS1, Line 700: fi
:
> Right, though before this patch, there was no such export, and we found our
Better yet, should we fail the build if KRB5CONFIG is empty?
--
To view, visit http://gerrit.cloudera.org:8080/16883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0961865a00601431bbc833360590cafa3aaf65c6
Gerrit-Change-Number: 16883
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Dec 2020 19:48:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Fix curl build on SLES
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16883 )
Change subject: [thirdparty] Fix curl build on SLES
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh@697
PS1, Line 697: SLES_KRB5CONFIG_LOCATION="/usr/lib/mit/bin/krb5-config"
Why not just put that as the default for KRB5CONFIG_LOCATION at line 691?
--
To view, visit http://gerrit.cloudera.org:8080/16883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0961865a00601431bbc833360590cafa3aaf65c6
Gerrit-Change-Number: 16883
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Dec 2020 19:19:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Fix curl build on SLES
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16883 )
Change subject: [thirdparty] Fix curl build on SLES
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh@700
PS1, Line 700: fi
:
> It's not a problem to have empty KRB5CONFIG if the curl is smart enough to
It did show that KRB5CONFIG_LOCATION was empty which is effectively the same.
We want KRB5CONFIG to be empty in the case that its in /usr/bin.
I did upgrade to the lates curl to test, and it doesn't help. I can push that patch though if you want.
--
To view, visit http://gerrit.cloudera.org:8080/16883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0961865a00601431bbc833360590cafa3aaf65c6
Gerrit-Change-Number: 16883
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Dec 2020 19:59:09 +0000
Gerrit-HasComments: Yes