You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "gabotorresruiz (via GitHub)" <gi...@apache.org> on 2025/11/15 00:24:54 UTC
[PR] feat(embedded): add setThemeMode API for dynamic theme switching [superset]
gabotorresruiz opened a new pull request, #36125:
URL: https://github.com/apache/superset/pull/36125
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR adds a new `setThemeMode()` method to the embedded SDK that allows host applications to dynamically control the theme mode (default/dark/system) of embedded dashboards.
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
1. Set up an embedded dashboard using the SDK
2. Configure a theme with both `theme_default` and `theme_dark`:
```typescript
const dashboard = await embedDashboard({ /* config */ });
dashboard.setThemeConfig({
theme_default: { token: { colorPrimary: '#458588' } },
theme_dark: { token: { colorPrimary: '#458588', colorBgBase: '#282828' }, algorithm: 'dark' }
});
```
3. Call `dashboard.setThemeMode('dark')` - verify dashboard switches to dark theme
4. Call `dashboard.setThemeMode('default')` - verify dashboard switches to default theme
5. Test theme locking: Configure a dashboard with only theme_default, verify `setThemeMode('dark')` is silently ignored (no errors, dashboard stays in default mode)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(embedded): add setThemeMode API for dynamic theme switching [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36125:
URL: https://github.com/apache/superset/pull/36125#issuecomment-3535153908
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(embedded): add setThemeMode API for dynamic theme switching [superset]
Posted by "sagautam5 (via GitHub)" <gi...@apache.org>.
sagautam5 commented on PR #36125:
URL: https://github.com/apache/superset/pull/36125#issuecomment-3906611404
Does it works with superset `v6.0.0` and sdk version `v0.3.0`
In my case, it doesn't seems to work !
https://github.com/apache/superset/issues/37989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(embedded): add setThemeMode API for dynamic theme switching [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe merged PR #36125:
URL: https://github.com/apache/superset/pull/36125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org