You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/28 13:29:55 UTC

[GitHub] [arrow-julia] SimonDanisch opened a new pull request, #349: fix Julia 1.6

SimonDanisch opened a new pull request, #349:
URL: https://github.com/apache/arrow-julia/pull/349

   When I look at the CI jobs on the last commit on `main` it looks like Arrow tests aren't run against `1.6`, but the CI.yml looks like it does consider 1.6 - but it's also a more complex setup, I guess something may go wrong somewhere?
   Anyways, the latest tagged version of Arrow.jl fails to compile on Julia 1.6...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] kou commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
kou commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1319380833

   Passed: https://lists.apache.org/thread/q9bjmktlowkj5xm93nsw5cpjh2kgmjtf
   
   Could someone update the Julia General registry?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] quinnj commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
quinnj commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1295084927

   Oof, yeah, sorry about the mixup here folks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] ericphanson commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
ericphanson commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1295085514

   cc @kou apparently Arrow.jl v2.4 is totally broken on Julia 1.6 and won't even load, causing CI issues in a lot of places (particularly private repos at Beacon where we use a lot of Arrow.jl). Can we either:
   * expedite the patch release faster than 24 hr, OR
   * register this in the Julia package registry before the official release vote goes through?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] ericphanson commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
ericphanson commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1295074078

   Looking at the git history, I think those exclusions were originally intended so that ArrowTypes and Arrow could have different minimum supported Julia versions (xref https://github.com/apache/arrow-julia/pull/223), but were incorrectly updated over time, such that now they incorrectly exclude things.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] bkamins commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
bkamins commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1295200924

   We might want to wait with the release for https://github.com/apache/arrow-julia/pull/350 to be merged (that PR is small, but requires a review from someone who has good understanding of different requirements of host platforms)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] kou commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
kou commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1317811685

   Vote thread: https://lists.apache.org/thread/mp8mg70c01kvs4648ttq1kq4vq9nr7cv


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] bkamins commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
bkamins commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1295036521

   @quinnj - is this line
   https://github.com/apache/arrow-julia/blob/b49255ad486fce9d8fe6f30370583de5bbffd895/.github/workflows/ci.yml#L86
   disabling Arrow.jl tests on Julia 1.6?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] ericphanson commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
ericphanson commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1317667029

   > this project follows semantic versioning 
   Yep!
   
   > confirm that the current main doesn't include a backward compatibility change nor a new feature?  
   
   Since v2.4.0 we have
   * this PR: bugfix
   * https://github.com/apache/arrow-julia/pull/356: bugfix
   * https://github.com/apache/arrow-julia/pull/355: internal tooling change / not really sure if it's a bugfix or feature
   * https://github.com/apache/arrow-julia/pull/357: bugfix
   * https://github.com/apache/arrow-julia/pull/358: not sure, bugfix or feature
   
   Maybe someone else can weigh in about #355 and #358


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] ericphanson commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
ericphanson commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1317636295

   This PR incremented the version number, in anticipation of a release. Is it better next time if that is a separate PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] bkamins commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
bkamins commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1295058200

   The reason for error is that `@lock` is not exported in Julia 1.6. Its export was added in https://github.com/JuliaLang/julia/pull/39588


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] bkamins commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
bkamins commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1295202541

   (but if that PR is problematic I would not wait with the release)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] kou commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
kou commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1317806250

   OK. I'll prepare RC and vote.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] ericphanson commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
ericphanson commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1320062198

   Ok, I've made https://github.com/JuliaRegistries/General/pull/72443 to register 2.4.1. When that PR is merged, it will be registered in General


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] ericphanson commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
ericphanson commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1317621662

   Someone needs to do the steps from https://github.com/apache/arrow-julia/tree/main/dev/release#release


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] kou commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
kou commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1317633560

   > 1. Test the revision to be released
   
   Could you confirm that the current main is releasable?
   
   > 2. Increment version number in `Project.toml`
   
   Could someone open a pull request for it?
   
   Then, I can do the following tasks:
   
   > 3. Prepare RC and vote (detailed later)
   > 4. Publish (detailed later)
   
   If there is a person who wants to try these tasks, I can support the person.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] ericphanson commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
ericphanson commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1295190240

   > cc @kou apparently Arrow.jl v2.4 is totally broken on Julia 1.6 and won't even load, causing CI issues in a lot of places (particularly private repos at Beacon where we use a lot of Arrow.jl). Can we either:
   > 
   > * expedite the patch release faster than 24 hr, OR
   > * register this in the Julia package registry before the official release vote goes through?
   
   Actually, we can just yank the 2.4.0 release, meaning it won't be installed by default anymore. This will solve the CI issues. Then we can land 2.4.1, waiting the 24 hours.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] ericphanson commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
ericphanson commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1295196193

   Ok, 2.4.0 is yanked on the General registry, so at least we don't have the broken release causing CI problems. Now we can re-land the release as 2.4.1. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] ericphanson merged pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
ericphanson merged PR #349:
URL: https://github.com/apache/arrow-julia/pull/349


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] ericphanson commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
ericphanson commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1295083111

   Can you remove those exclusions from the workflow and bump the patch version @SimonDanisch? Then we can see CI passing on 1.6 here and merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] ericphanson commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
ericphanson commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1295233493

   I tried making a 2.4.1-rc1 but I don't have java installed, nor a PGP key, and I am out of motivation for today


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] baumgold commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
baumgold commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1317580782

   It seems we're still not able to make a 2.4 release?  I lost track of what the holdup is at this point...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] kou commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
kou commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1317653967

   Oh, I didn't notice it.
   I think that a separate PR is better because we need to choose which version (major/minor/patch) to be incremented when we put multiple changes to one release.
   But we can choose this mixed approach by discussing and reaching a consensus. It's for "Open Communications" in [the Apache way](anticipation). If it's needed, we should open a new issue for it.
    
   Could you confirm that the current main doesn't include a backward compatibility change nor a new feature? (I think that this project follows semantic versioning, right?)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] quinnj commented on pull request #349: fix Julia 1.6

Posted by GitBox <gi...@apache.org>.
quinnj commented on PR #349:
URL: https://github.com/apache/arrow-julia/pull/349#issuecomment-1317668393

   All bugfixes; a patch release should be appropriate


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org