You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/07/09 18:49:14 UTC
[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10893
Change subject: IMPALA-6677: [DOCS] Document the next_day function
......................................................................
IMPALA-6677: [DOCS] Document the next_day function
Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
---
M docs/topics/impala_datetime_functions.xml
1 file changed, 52 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/10893/1
--
To view, visit http://gerrit.cloudera.org:8080/10893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Gerrit-Change-Number: 10893
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10893
to look at the new patch set (#3).
Change subject: IMPALA-6677: [DOCS] Document the next_day function
......................................................................
IMPALA-6677: [DOCS] Document the next_day function
Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
---
M docs/topics/impala_datetime_functions.xml
1 file changed, 61 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/10893/3
--
To view, visit http://gerrit.cloudera.org:8080/10893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Gerrit-Change-Number: 10893
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10893 )
Change subject: IMPALA-6677: [DOCS] Document the next_day function
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Gerrit-Change-Number: 10893
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Jul 2018 00:55:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10893 )
Change subject: IMPALA-6677: [DOCS] Document the next_day function
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10893/3/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:
http://gerrit.cloudera.org:8080/#/c/10893/3/docs/topics/impala_datetime_functions.xml@1941
PS3, Line 1941: one a week later
> the "a" should be removed.
Done
http://gerrit.cloudera.org:8080/#/c/10893/3/docs/topics/impala_datetime_functions.xml@1951
PS3, Line 1951: 07-12
> perhaps include the example referenced on L1940?
Done
--
To view, visit http://gerrit.cloudera.org:8080/10893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Gerrit-Change-Number: 10893
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Jul 2018 23:44:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Lars Volker, Impala Public Jenkins, Vuk Ercegovac,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10893
to look at the new patch set (#5).
Change subject: IMPALA-6677: [DOCS] Document the next_day function
......................................................................
IMPALA-6677: [DOCS] Document the next_day function
Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
---
M docs/topics/impala_datetime_functions.xml
1 file changed, 58 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/10893/5
--
To view, visit http://gerrit.cloudera.org:8080/10893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Gerrit-Change-Number: 10893
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10893 )
Change subject: IMPALA-6677: [DOCS] Document the next_day function
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:
http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml@1941
PS1, Line 1941:
> Did you see my comment above? I would like to use upper case for SQL. And h
Sorry, I had missed your comment.
I think it'd be good to keep the style consistent, and the previous few examples that I looked at used lowercase for SQL keywords and function names. Other pages of our docs use uppercase or lowercase for SQL keywords and lowercase for function names. Most notably, our function pages also use lowercase for function names: https://impala.apache.org/docs/build3x/html/topics/impala_math_functions.html#math_functions
If we want to change this going forward, I suggest to change it in a single commit (since the files are rather large). I don't feel strongly about which way we should go as long as it's consistent.
Space before parentheses usually expresses a logical grouping, whereas function arguments are usually not separated from the function name.
This example from our docs contains both:
SELECT x FROM t1 WHERE y = (SELECT max(z) FROM t2);
I think that this convention provides the best readability. If you feel strongly about it, I suggest to start a thread on dev@ and ask for more feedback.
We might also want to check what other projects do. I briefly looked at the docs of Hive and Phoenix and they seem to follow our current style.
http://gerrit.cloudera.org:8080/#/c/10893/2/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:
http://gerrit.cloudera.org:8080/#/c/10893/2/docs/topics/impala_datetime_functions.xml@1941
PS2, Line 1941: Saturday December 25
"first Saturday after December..."?
--
To view, visit http://gerrit.cloudera.org:8080/10893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Gerrit-Change-Number: 10893
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 03:33:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10893 )
Change subject: IMPALA-6677: [DOCS] Document the next_day function
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:
http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml@1921
PS1, Line 1921: <b>Purpose:</b> Returns the date of the <varname>weekday</varname>
It seems somewhat implied, but maybe we should mention that the calling this with the current day returns the one a week later. E.g.
select next_day('2018-07-12', 'thu'); --> 2018-07-19
This could also be added in the examples.
http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml@1930
PS1, Line 1930: <codeph>"Sunday"</codeph>/<codeph>"SUN"</codeph>,
Maybe make these follow the same case, if they're case insensitive? It seems odd to point out that case doesn't matter, but then have half of them in all-caps. I saw that these come from the original code but for the docs it seems nicer to have Sunday / Sun etc.
http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml@1941
PS1, Line 1941: Saturday December
missing word? Also can you wrap the lines at 90 chars within the codeblock?
http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml@1941
PS1, Line 1941: SELECT NEXT_DAY
The previous example above uses lower case and doesn't have a space before the opening "(".
select next_day('2013...
--
To view, visit http://gerrit.cloudera.org:8080/10893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Gerrit-Change-Number: 10893
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jul 2018 20:42:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10893 )
Change subject: IMPALA-6677: [DOCS] Document the next_day function
......................................................................
Patch Set 2:
> (2 comments)
I checked a few other RDBMS docs, and see that no space before and after (). I will follow that convention, and I will use the upper case SQL keywords and function names.
I strongly believe in consistency, but with not enough bandwidth, I will update the docs whenever I have a chance.
Thank you for keeping the docs honest!
--
To view, visit http://gerrit.cloudera.org:8080/10893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Gerrit-Change-Number: 10893
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 03:49:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10893 )
Change subject: IMPALA-6677: [DOCS] Document the next_day function
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10893/4/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:
http://gerrit.cloudera.org:8080/#/c/10893/4/docs/topics/impala_datetime_functions.xml@1941
PS4, Line 1941: SELECT NEXT_DAY
> I've followed a little bit the discussion about moving towards this style.
Done
--
To view, visit http://gerrit.cloudera.org:8080/10893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Gerrit-Change-Number: 10893
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Jul 2018 00:30:59 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10893 )
Change subject: IMPALA-6677: [DOCS] Document the next_day function
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10893/4/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:
http://gerrit.cloudera.org:8080/#/c/10893/4/docs/topics/impala_datetime_functions.xml@1941
PS4, Line 1941: SELECT NEXT_DAY
I've followed a little bit the discussion about moving towards this style. However, I'd prefer that we retain file-level consistency, then move to the new style at the file granularity. I'm concerned that an inconsistent style for a given file will be worse than a consistent style, even it we're moving away from it. This file looks like it uses lower-case for both keywords and functions.
--
To view, visit http://gerrit.cloudera.org:8080/10893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Gerrit-Change-Number: 10893
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Jul 2018 23:58:00 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10893 )
Change subject: IMPALA-6677: [DOCS] Document the next_day function
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:
http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml@1941
PS1, Line 1941: 00:00:00' the f
> The previous example above uses lower case and doesn't have a space before
This one is still open.
http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml@1941
PS1, Line 1941:
> missing word? Also can you wrap the lines at 90 chars within the codeblock?
This one is still open, too.
--
To view, visit http://gerrit.cloudera.org:8080/10893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Gerrit-Change-Number: 10893
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 02:07:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10893
to look at the new patch set (#2).
Change subject: IMPALA-6677: [DOCS] Document the next_day function
......................................................................
IMPALA-6677: [DOCS] Document the next_day function
Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
---
M docs/topics/impala_datetime_functions.xml
1 file changed, 57 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/10893/2
--
To view, visit http://gerrit.cloudera.org:8080/10893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Gerrit-Change-Number: 10893
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10893 )
Change subject: IMPALA-6677: [DOCS] Document the next_day function
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:
http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml@1941
PS1, Line 1941: Saturday December
> This one is still open, too.
Did you see my comment above? I would like to use upper case for SQL. And have a space before parenth.
Could you tell me if you object these?
--
To view, visit http://gerrit.cloudera.org:8080/10893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Gerrit-Change-Number: 10893
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 02:13:36 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Lars Volker, Impala Public Jenkins, Vuk Ercegovac,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10893
to look at the new patch set (#4).
Change subject: IMPALA-6677: [DOCS] Document the next_day function
......................................................................
IMPALA-6677: [DOCS] Document the next_day function
Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
---
M docs/topics/impala_datetime_functions.xml
1 file changed, 59 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/10893/4
--
To view, visit http://gerrit.cloudera.org:8080/10893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Gerrit-Change-Number: 10893
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10893 )
Change subject: IMPALA-6677: [DOCS] Document the next_day function
......................................................................
IMPALA-6677: [DOCS] Document the next_day function
Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Reviewed-on: http://gerrit.cloudera.org:8080/10893
Reviewed-by: Vuk Ercegovac <ve...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_datetime_functions.xml
1 file changed, 58 insertions(+), 15 deletions(-)
Approvals:
Vuk Ercegovac: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Gerrit-Change-Number: 10893
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10893 )
Change subject: IMPALA-6677: [DOCS] Document the next_day function
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10893/3/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:
http://gerrit.cloudera.org:8080/#/c/10893/3/docs/topics/impala_datetime_functions.xml@1941
PS3, Line 1941: one a week later
the "a" should be removed.
http://gerrit.cloudera.org:8080/#/c/10893/3/docs/topics/impala_datetime_functions.xml@1951
PS3, Line 1951: 07-12
perhaps include the example referenced on L1940?
--
To view, visit http://gerrit.cloudera.org:8080/10893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Gerrit-Change-Number: 10893
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Jul 2018 22:02:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10893 )
Change subject: IMPALA-6677: [DOCS] Document the next_day function
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/352/
--
To view, visit http://gerrit.cloudera.org:8080/10893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Gerrit-Change-Number: 10893
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Jul 2018 02:09:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10893 )
Change subject: IMPALA-6677: [DOCS] Document the next_day function
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:
http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml@1921
PS1, Line 1921: <b>Purpose:</b> Returns the date of the <varname>weekday</varname>
> It seems somewhat implied, but maybe we should mention that the calling thi
Done
http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml@1930
PS1, Line 1930: <codeph>"Sunday"</codeph>/<codeph>"SUN"</codeph>,
> Maybe make these follow the same case, if they're case insensitive? It seem
Done
http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml@1941
PS1, Line 1941: SELECT NEXT_DAY
> The previous example above uses lower case and doesn't have a space before
The original style for SQL is to use upper case for keywords even though not consistently followed. Will use upper case going forward and change the existing examples whenever possible.
I would like to have space before opening paren unless there is a good reason not to use a space. Let me know if there is a reason that I am not aware of.
http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml@1941
PS1, Line 1941: Saturday December
> missing word? Also can you wrap the lines at 90 chars within the codeblock?
Done
--
To view, visit http://gerrit.cloudera.org:8080/10893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Gerrit-Change-Number: 10893
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jul 2018 22:33:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10893 )
Change subject: IMPALA-6677: [DOCS] Document the next_day function
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Gerrit-Change-Number: 10893
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Jul 2018 02:19:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10893 )
Change subject: IMPALA-6677: [DOCS] Document the next_day function
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10893/2/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:
http://gerrit.cloudera.org:8080/#/c/10893/2/docs/topics/impala_datetime_functions.xml@1941
PS2, Line 1941: Saturday December 25
> "first Saturday after December..."?
Done
--
To view, visit http://gerrit.cloudera.org:8080/10893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715
Gerrit-Change-Number: 10893
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 15:55:37 +0000
Gerrit-HasComments: Yes