[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1207: DISPATCH-2110: Formatted numbers correctly in verbose outputs

[GitBox <gi...@apache.org>]

kgiusti commented on a change in pull request #1207:
URL: https://github.com/apache/qpid-dispatch/pull/1207#discussion_r630154298



##########
File path: tools/qdstat.in
##########
@@ -540,8 +540,12 @@ class BusManager(object):
                 row.append(PlainNum(node.routerLink))
 
             if self.opts.verbose:
-                row.append(get(node, 'protocolVersion'))
-                row.append(get(node, 'cost'))
+                row.append(PlainNum(get(node, 'protocolVersion')))
+                cost = get(node, 'cost')
+                if cost:

Review comment:
       Why the need for the conditional?  what is the expected output of the 'else' if cost is '0', or None?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org