[GitHub] [rocketmq] zhiliatom commented on a diff in pull request #5244: [ISSUE #5243] Add acl support to TimerProducer/TimerConsumer

[GitBox <gi...@apache.org>]

zhiliatom commented on code in PR #5244:
URL: https://github.com/apache/rocketmq/pull/5244#discussion_r990725960


##########
example/src/main/java/org/apache/rocketmq/example/benchmark/timer/TimerConsumer.java:
##########
@@ -151,6 +166,30 @@ private Options buildCommandlineOptions(Options options) {
         opt.setRequired(false);
         options.addOption(opt);
 
+        opt = new Option("w", "threadCount", true, "Thread count, Default: 20");
+        opt.setRequired(false);
+        options.addOption(opt);
+
+        opt = new Option("m", "msgTraceEnable", true, "Message Trace Enable, Default: false");
+        opt.setRequired(false);
+        options.addOption(opt);
+
+        opt = new Option("g", "group", true, "Consumer group name, Default: benchmark_consumer");
+        opt.setRequired(false);
+        options.addOption(opt);
+
+        opt = new Option("a", "aclEnable", true, "Acl Enable, Default: false");

Review Comment:
   Good suggestion, but to keep consistent wist other code, I don't do any change here.
    If It really need to change, I'd like to make a new patch to change all .sh .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org