You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/11/17 02:26:29 UTC

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #7128: [Dependency] Add breakpad for minidump

yangzhg commented on a change in pull request #7128:
URL: https://github.com/apache/incubator-doris/pull/7128#discussion_r750833811



##########
File path: thirdparty/vars.sh
##########
@@ -375,6 +375,14 @@ BENCHMARK_NAME=benchmark-1.5.6.tar.gz
 BENCHMARK_SOURCE=benchmark-1.5.6
 BENCHMARK_MD5SUM="668b9e10d8b0795e5d461894db18db3c"
 
+# breakpad
+# breakpad has no release version, the source is from commit@38ee0be,
+# and also add lss files. See README.md in it.
+BREAKPAD_DOWNLOAD="https://doris-thirdparty-repo.bj.bcebos.com/thirdparty/breakpad-src-38ee0be-with-lss.tar.gz"

Review comment:
       you'd better use 
    an official download link https://github.com/google/breakpad/archive/38ee0be4d1118c9d86c0ffab25c6c521ff99fdee.zip 
   and use bos as a mirror




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org