[GitHub] betodealmeida opened a new pull request #5828: Fix cache for multiple time comparisons

[GitBox <gi...@apache.org>]

betodealmeida opened a new pull request #5828: Fix cache for multiple time comparisons
URL: https://github.com/apache/incubator-superset/pull/5828
 
 
   Currently we have these two conflicting behaviors:
   
   1. When computing the cache key from the query object _"we remove datetime bounds that are hard values, and replace them with the use-provided inputs to bounds, which may be time-relative (as in "5 days ago" or "now")."_ This removes `from_dttm` and `to_dttm` from the query object when generating the cache dict.
   2. When running a query for a time comparison, say "1 week", we move the values stored in the keys `from_dttm` and `to_dttm` in the query object to `inner_from_dttm` and `inner_to_dttm`, and update the original keys with the shifted values.
   
   When the second query runs, the cache key will be different from the first one even though `from_dttm` and `to_dttm` are stripped from both query objects, because the second one has the `inner_from_dttm` and `inner_to_dttm` keys set.
   
   The problem is that **multiple time shifts** will have the same cache key, since the only thing differing them is `from_dttm` and `to_dttm`. This results in a false positive cache hit. I fixed it by allowing passing extra cache keys when fetching a dataframe. This way each time comparison will add, eg, `time_compare: "1 week"` to the cache dict.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org