[spark] branch master updated: [SPARK-39661][SQL] Avoid creating unnecessary SLF4J Logger

[sr...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

srowen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new d4cb2ea37a5 [SPARK-39661][SQL] Avoid creating unnecessary SLF4J Logger
d4cb2ea37a5 is described below

commit d4cb2ea37a5d2fa39003f355400a9a2170797981
Author: panbingkun <pb...@gmail.com>
AuthorDate: Fri Jul 8 08:19:07 2022 -0500

    [SPARK-39661][SQL] Avoid creating unnecessary SLF4J Logger
    
    ### What changes were proposed in this pull request?
    The pr follow up: https://issues.apache.org/jira/browse/SPARK-39538 https://github.com/apache/spark/pull/36930
    
    ### Why are the changes needed?
    To improve performance.
    
    ### Does this PR introduce _any_ user-facing change?
    No.
    
    ### How was this patch tested?
    Existing UT.
    
    Closes #37058 from panbingkun/loggerToStatic.
    
    Authored-by: panbingkun <pb...@gmail.com>
    Signed-off-by: Sean Owen <sr...@gmail.com>
---
 .../apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java b/sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java
index 58b28ed4a35..6a74f64d448 100644
--- a/sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java
+++ b/sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java
@@ -48,7 +48,7 @@ import org.slf4j.LoggerFactory;
  *
  */
 public abstract class RowBasedKeyValueBatch extends MemoryConsumer implements Closeable {
-  protected final Logger logger = LoggerFactory.getLogger(RowBasedKeyValueBatch.class);
+  protected static final Logger logger = LoggerFactory.getLogger(RowBasedKeyValueBatch.class);
 
   private static final int DEFAULT_CAPACITY = 1 << 16;
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org