You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by nadyaA <gi...@git.apache.org> on 2014/03/31 15:40:24 UTC
[GitHub] cordova-plugin-inappbrowser pull request: Add necessary capability...
GitHub user nadyaA opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/33
Add necessary capability so the plugin works on its own
If the plugin is installed on clean Cordova project with no other plugins enabled, it needs the ID_CAP_NETWORKING capability enabled in order to work. Both for wp8 and wp7.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Icenium/cordova-plugin-inappbrowser enable-wp-capability
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/33.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #33
----
commit bdf4ade2bb1e5805ebd632f264fcdd09109cc5d1
Author: Nadya Atanasova <na...@gmail.com>
Date: 2014-03-26T13:51:49Z
Add necessary capability so the plugin works on its own
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Add necessary capability...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/33#issuecomment-39089517
I believe we have ID_CAP_NETWORKING by default
https://github.com/apache/cordova-wp8/blob/master/wp8/template/Properties/WMAppManifest.xml#L11
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Add necessary capability...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/33#issuecomment-40994721
Merged to dev branch, this will be available in the next release of the plugin. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Add necessary capability...
Posted by nadyaA <gi...@git.apache.org>.
Github user nadyaA commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/33#issuecomment-39104074
Hi and thanks for the quick comment.
Still the plugin can be installed on earlier versions of Cordova (according to plugin.xml) - like Cordova 3.2.0 - https://github.com/apache/cordova-wp8/blob/3.2.0/wp8/template/Properties/WMAppManifest.xml.
It also can be used in project that has disabled this capability earlier.
I believe the plugin needs to be self-explained and this is why I added the capability.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Add necessary capability...
Posted by nadyaA <gi...@git.apache.org>.
Github user nadyaA commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/33#issuecomment-41008469
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Add necessary capability...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/33
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---