You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "baldimir (via GitHub)" <gi...@apache.org> on 2024/05/23 12:34:23 UTC

[PR] [NO-ISSUE] Use apache-release profile when doing a release build [incubator-kie-optaplanner]

baldimir opened a new pull request, #3093:
URL: https://github.com/apache/incubator-kie-optaplanner/pull/3093

   Adds gpg setup and apache-release Maven profile to the release build.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [NO-ISSUE] Use apache-release profile when doing a release build [incubator-kie-optaplanner]

Posted by "baldimir (via GitHub)" <gi...@apache.org>.
baldimir commented on code in PR #3093:
URL: https://github.com/apache/incubator-kie-optaplanner/pull/3093#discussion_r1612943856


##########
.ci/jenkins/Jenkinsfile.deploy:
##########
@@ -139,13 +139,29 @@ pipeline {
                         } else {
                             installOrDeploy = 'install'
                         }
+
+                        def mavenCommand = getOptaplannerMavenCommand()
+                           .withProperty('maven.test.failure.ignore', true)
+                           .withProperty('operator.image.build')
+                           .skipTests(params.SKIP_TESTS)
+                           .withSettingsXmlFile(MAVEN_SETTINGS_FILE)

Review Comment:
   Fixed. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [NO-ISSUE] Use apache-release profile when doing a release build [incubator-kie-optaplanner]

Posted by "jstastny-cz (via GitHub)" <gi...@apache.org>.
jstastny-cz commented on code in PR #3093:
URL: https://github.com/apache/incubator-kie-optaplanner/pull/3093#discussion_r1611778872


##########
.ci/jenkins/Jenkinsfile.deploy:
##########
@@ -139,13 +139,29 @@ pipeline {
                         } else {
                             installOrDeploy = 'install'
                         }
+
+                        def mavenCommand = getOptaplannerMavenCommand()
+                           .withProperty('maven.test.failure.ignore', true)
+                           .withProperty('operator.image.build')
+                           .skipTests(params.SKIP_TESTS)
+                           .withSettingsXmlFile(MAVEN_SETTINGS_FILE)

Review Comment:
   needs to be accessed within configFileProvider block.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [NO-ISSUE] Use apache-release profile when doing a release build [incubator-kie-optaplanner]

Posted by "jstastny-cz (via GitHub)" <gi...@apache.org>.
jstastny-cz merged PR #3093:
URL: https://github.com/apache/incubator-kie-optaplanner/pull/3093


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org