You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by sv...@apache.org on 2022/10/10 04:00:03 UTC

svn commit: r1904478 - in /subversion/branches/1.14.x: ./ STATUS subversion/bindings/swig/ruby/svn/util.rb subversion/bindings/swig/ruby/test/test_wc.rb subversion/bindings/swig/ruby/test/windows_util.rb

Author: svn-role
Date: Mon Oct 10 04:00:03 2022
New Revision: 1904478

URL: http://svn.apache.org/viewvc?rev=1904478&view=rev
Log:
Merge r1904472 from trunk:

 * r1904472
   swig-rb: Use Ruby API 'File.exist?' instead of deprecated 'File.exists?'
   Justification:
     Deprecated API 'File.exists?' is deprecated as of Ruby 2.1 and removed
     as of Ruby 3.2.
   Votes:
    +1: hartmannathan, dsahlberg

Modified:
    subversion/branches/1.14.x/   (props changed)
    subversion/branches/1.14.x/STATUS
    subversion/branches/1.14.x/subversion/bindings/swig/ruby/svn/util.rb
    subversion/branches/1.14.x/subversion/bindings/swig/ruby/test/test_wc.rb
    subversion/branches/1.14.x/subversion/bindings/swig/ruby/test/windows_util.rb

Propchange: subversion/branches/1.14.x/
------------------------------------------------------------------------------
  Merged /subversion/trunk:r1904472

Modified: subversion/branches/1.14.x/STATUS
URL: http://svn.apache.org/viewvc/subversion/branches/1.14.x/STATUS?rev=1904478&r1=1904477&r2=1904478&view=diff
==============================================================================
--- subversion/branches/1.14.x/STATUS (original)
+++ subversion/branches/1.14.x/STATUS Mon Oct 10 04:00:03 2022
@@ -100,12 +100,3 @@ Veto-blocked changes:
 
 Approved changes:
 =================
-
- * r1904472
-   swig-rb: Use Ruby API 'File.exist?' instead of deprecated 'File.exists?'
-   Justification:
-     Deprecated API 'File.exists?' is deprecated as of Ruby 2.1 and removed
-     as of Ruby 3.2.
-   Votes:
-    +1: hartmannathan, dsahlberg
-

Modified: subversion/branches/1.14.x/subversion/bindings/swig/ruby/svn/util.rb
URL: http://svn.apache.org/viewvc/subversion/branches/1.14.x/subversion/bindings/swig/ruby/svn/util.rb?rev=1904478&r1=1904477&r2=1904478&view=diff
==============================================================================
--- subversion/branches/1.14.x/subversion/bindings/swig/ruby/svn/util.rb (original)
+++ subversion/branches/1.14.x/subversion/bindings/swig/ruby/svn/util.rb Mon Oct 10 04:00:03 2022
@@ -20,7 +20,7 @@
 if /cygwin|mingw|mswin32|bccwin32/.match(RUBY_PLATFORM)
   $LOAD_PATH.each do |load_path|
     svn_ext_path = File.join(load_path, "svn", "ext")
-    if File.exists?(svn_ext_path)
+    if File.exist?(svn_ext_path)
       svn_ext_path_win = File.expand_path(svn_ext_path)
       svn_ext_path_win = svn_ext_path.gsub(File::SEPARATOR, File::ALT_SEPARATOR)
       unless ENV["PATH"].split(";").find {|path| path == svn_ext_path_win}

Modified: subversion/branches/1.14.x/subversion/bindings/swig/ruby/test/test_wc.rb
URL: http://svn.apache.org/viewvc/subversion/branches/1.14.x/subversion/bindings/swig/ruby/test/test_wc.rb?rev=1904478&r1=1904477&r2=1904478&view=diff
==============================================================================
--- subversion/branches/1.14.x/subversion/bindings/swig/ruby/test/test_wc.rb (original)
+++ subversion/branches/1.14.x/subversion/bindings/swig/ruby/test/test_wc.rb Mon Oct 10 04:00:03 2022
@@ -342,11 +342,11 @@ class SvnWcTest < Test::Unit::TestCase
 
   def test_adm_ensure
     adm_dir = Dir.glob(File.join(@wc_path, "{.,_}svn")).first
-    assert(File.exists?(adm_dir))
+    assert(File.exist?(adm_dir))
     FileUtils.rm_rf(adm_dir)
-    assert(!File.exists?(adm_dir))
+    assert(!File.exist?(adm_dir))
     Svn::Wc.ensure_adm(@wc_path, @fs.uuid, @repos_uri, @repos_uri, 0)
-    assert(File.exists?(adm_dir))
+    assert(File.exist?(adm_dir))
   end
 
   def test_merge
@@ -474,19 +474,19 @@ EOE
       ctx.add(path)
       ctx.ci(@wc_path).revision
 
-      assert(File.exists?(path))
+      assert(File.exist?(path))
       Svn::Wc::AdmAccess.open(nil, @wc_path, true, 5) do |access|
         access.delete(path)
       end
-      assert(!File.exists?(path))
+      assert(!File.exist?(path))
 
       ctx.revert(path)
 
-      assert(File.exists?(path))
+      assert(File.exist?(path))
       Svn::Wc::AdmAccess.open(nil, @wc_path, true, 5) do |access|
         access.delete(path, nil, nil, true)
       end
-      assert(File.exists?(path))
+      assert(File.exist?(path))
     end
   end
 
@@ -808,9 +808,9 @@ EOE
         ctx.add(path2)
         rev2 = ctx.commit(@wc_path).revision
 
-        assert(File.exists?(path2))
+        assert(File.exist?(path2))
         assert_equal(0, ctx.up(@wc_path, 0))
-        assert(!File.exists?(path2))
+        assert(!File.exist?(path2))
         Svn::Wc::AdmAccess.open(nil, @wc_path) do |access|
           editor = access.update_editor('', 0)
           assert_equal(0, editor.target_revision)
@@ -848,9 +848,9 @@ EOE
         ctx.add(path2)
         rev2 = ctx.commit(@wc_path).revision
 
-        assert(File.exists?(path2))
+        assert(File.exist?(path2))
         assert_equal(0, ctx.up(@wc_path, 0))
-        assert(!File.exists?(path2))
+        assert(!File.exist?(path2))
         notification_count = 0
         Svn::Wc::AdmAccess.open(nil, @wc_path) do |access|
           notify_func = Proc.new {|n| notification_count += 1}
@@ -946,9 +946,9 @@ EOE
         ctx.add(dir2_path)
         rev2 = ctx.commit(@wc_path).revision
 
-        assert(File.exists?(path1))
+        assert(File.exist?(path1))
         assert_equal(rev2, ctx.switch(@wc_path, dir2_uri))
-        assert(File.exists?(File.join(@wc_path, file2)))
+        assert(File.exist?(File.join(@wc_path, file2)))
         Svn::Wc::AdmAccess.open_anchor(@wc_path) do |access, dir_access, target|
           editor = dir_access.switch_editor('', dir1_uri, rev2)
           assert_equal(rev2, editor.target_revision)

Modified: subversion/branches/1.14.x/subversion/bindings/swig/ruby/test/windows_util.rb
URL: http://svn.apache.org/viewvc/subversion/branches/1.14.x/subversion/bindings/swig/ruby/test/windows_util.rb?rev=1904478&r1=1904477&r2=1904478&view=diff
==============================================================================
--- subversion/branches/1.14.x/subversion/bindings/swig/ruby/test/windows_util.rb (original)
+++ subversion/branches/1.14.x/subversion/bindings/swig/ruby/test/windows_util.rb Mon Oct 10 04:00:03 2022
@@ -115,7 +115,7 @@ exit 1
           lines = []
           gen_make_opts = File.join(@@top_dir, "gen-make.opts")
           lines =
-            File.read(gen_make_opts).lines.to_a if File.exists?(gen_make_opts)
+            File.read(gen_make_opts).lines.to_a if File.exist?(gen_make_opts)
           config = Hash.new do |hash, key|
             if /^--with-(.*)$/ =~ key
               hash[key] = File.join(@@top_dir, $1)