You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/01/23 22:32:09 UTC
[GitHub] clintropolis opened a new pull request #6906: fix long/float/double
dimension filtering for columns with nulls
clintropolis opened a new pull request #6906: fix long/float/double dimension filtering for columns with nulls
URL: https://github.com/apache/incubator-druid/pull/6906
Fixes an oversight in sql compatible null handling where single value matchers for long, float, and double columns could not handle null values, instead resulting in errors of the form
```
2019-01-23T12:13:34,086 ERROR [main] com.google.common.util.concurrent.Futures$CombinedFuture - input future failed.
java.lang.AssertionError
at org.apache.druid.math.expr.ExprEval$StringExprEval.computeDouble(ExprEval.java:352) ~[classes/:?]
at org.apache.druid.math.expr.ExprEval$StringExprEval.asDouble(ExprEval.java:314) ~[classes/:?]
at org.apache.druid.segment.virtual.SingleStringInputCachingExpressionColumnValueSelector.getDouble(SingleStringInputCachingExpressionColumnValueSelector.java:90) ~[classes/:?]
at org.apache.druid.segment.virtual.ExpressionSelectors$1.getDouble(ExpressionSelectors.java:78) ~[classes/:?]
at org.apache.druid.query.filter.DoubleValueMatcherColumnSelectorStrategy$1.matches(DoubleValueMatcherColumnSelectorStrategy.java:44) ~[classes/:?]
...
```
Adds a new datasource to calcite query tests that has some numerical dimension columns and some tests to cover this case that will fail without the modifications to the `ValueMatcherColumnSelectorStrategy` implementations.
Discovered in failing tests in #6902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org