You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by pf...@apache.org on 2005/03/21 20:30:48 UTC

cvs commit: jakarta-tapestry/framework/src/org/apache/tapestry/asset AssetService.java

pferraro    2005/03/21 11:30:48

  Modified:    framework/src/org/apache/tapestry/asset Tag: branch-3-0
                        AssetService.java
  Log:
  Fixed incorrect log message when getLink() is called with the wrong number of parameters.  This would only be the case if a user is using the AssetService with a custom IAsset implementation.
  
  Revision  Changes    Path
  No                   revision
  No                   revision
  1.8.2.2   +6 -6      jakarta-tapestry/framework/src/org/apache/tapestry/asset/Attic/AssetService.java
  
  Index: AssetService.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tapestry/framework/src/org/apache/tapestry/asset/Attic/AssetService.java,v
  retrieving revision 1.8.2.1
  retrieving revision 1.8.2.2
  diff -u -r1.8.2.1 -r1.8.2.2
  --- AssetService.java	17 Mar 2005 08:14:54 -0000	1.8.2.1
  +++ AssetService.java	21 Mar 2005 19:30:48 -0000	1.8.2.2
  @@ -38,8 +38,8 @@
    *
    *  <p>The retrieval part is directly linked to {@link PrivateAsset}.
    *  The service responds to a URL that encodes the path of a resource
  - *  within the classpath.  The 
  - *  {@link #service(IEngineServiceView, IRequestCycle, ResponseOutputStream)} 
  + *  within the classpath.  The
  + *  {@link #service(IEngineServiceView, IRequestCycle, ResponseOutputStream)}
    *  method reads the resource and streams it out.
    *
    *  <p>TBD: Security issues.  Should only be able to retrieve a
  @@ -86,7 +86,7 @@
       {
           if (Tapestry.size(parameters) != 2)
               throw new ApplicationRuntimeException(
  -                Tapestry.format("service-single-parameter", Tapestry.ASSET_SERVICE));
  +                Tapestry.format("service-incorrect-parameter-count", Tapestry.ASSET_SERVICE, new Integer(2)));
   
           // Service is stateless
   
  @@ -146,13 +146,13 @@
                   Tapestry.format("missing-resource", resourcePath));
   
           String actualChecksum = engine.getResourceChecksumSource().getChecksum(resourceURL);
  -        
  +
           if (!actualChecksum.equals(checksum))
           {
               throw new ApplicationRuntimeException(
                   Tapestry.format("AssetService.checksum-failure", checksum, resourcePath));
           }
  -        
  +
           URLConnection resourceConnection = resourceURL.openConnection();
   
           ServletContext servletContext = cycle.getRequestContext().getServlet().getServletContext();
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org