You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/08/11 11:17:35 UTC

[GitHub] [ozone] siddhantsangwan opened a new pull request #2523: HDDS-5603. Stop ContainerBalancer when SCM is stopped.

siddhantsangwan opened a new pull request #2523:
URL: https://github.com/apache/ozone/pull/2523


   ## What changes were proposed in this pull request?
   
   ContainerBalancer should be stopped in `StorageContainerManager#stop`.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-5603
   
   ## How was this patch tested?
   
   Existing tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] lokeshj1703 commented on pull request #2523: HDDS-5603. Stop ContainerBalancer when SCM is stopped.

Posted by GitBox <gi...@apache.org>.
lokeshj1703 commented on pull request #2523:
URL: https://github.com/apache/ozone/pull/2523#issuecomment-899431832


   @siddhantsangwan Thanks for the contribution! @JacksonYao287 Thanks for the review! I have merged the PR to master branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] siddhantsangwan commented on pull request #2523: HDDS-5603. Stop ContainerBalancer when SCM is stopped.

Posted by GitBox <gi...@apache.org>.
siddhantsangwan commented on pull request #2523:
URL: https://github.com/apache/ozone/pull/2523#issuecomment-896770196


   Thanks for the review!
   
   > Container balancer should also call join for the balancer thread on stop and currentBalancingThread can be set to null.
   
   Done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] siddhantsangwan commented on pull request #2523: HDDS-5603. Stop ContainerBalancer when SCM is stopped.

Posted by GitBox <gi...@apache.org>.
siddhantsangwan commented on pull request #2523:
URL: https://github.com/apache/ozone/pull/2523#issuecomment-896741836


   @lokeshj1703 @JacksonYao287 please take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] lokeshj1703 merged pull request #2523: HDDS-5603. Stop ContainerBalancer when SCM is stopped.

Posted by GitBox <gi...@apache.org>.
lokeshj1703 merged pull request #2523:
URL: https://github.com/apache/ozone/pull/2523


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org