You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rajani Karuturi <ra...@gmail.com> on 2014/07/01 07:02:40 UTC
Re: Review Request 22721: removed hard coded jdk_dirs in cloud-usage script
> On June 30, 2014, 8:29 p.m., Sebastien Goasguen wrote:
> > Seems I can take that to 4.3.1 as well ?
yes. this can be applied to 4.3.1 as well. let me know if it doesnt apply cleanly on 4.3.1.
- Rajani
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22721/#review47015
-----------------------------------------------------------
On June 18, 2014, 10:15 a.m., Rajani Karuturi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22721/
> -----------------------------------------------------------
>
> (Updated June 18, 2014, 10:15 a.m.)
>
>
> Review request for cloudstack, Kishan Kavala and Rayees Namathponnan.
>
>
> Bugs: CLOUDSTACK-6926
> https://issues.apache.org/jira/browse/CLOUDSTACK-6926
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> used to readlink -e and dirname to get the JAVA_HOME
> if JAVA_HOME is not already defined, sets it to jdk home if javac is present else jre home if java is present.
> if nothing is present, it exits with error
>
>
> Diffs
> -----
>
> packaging/centos63/cloud-usage.rc 6170379
> packaging/debian/init/cloud-usage 1cc75cc
>
> Diff: https://reviews.apache.org/r/22721/diff/
>
>
> Testing
> -------
>
>
> tested it when java is not installed, jre is installed, jdk installed or when a older version is installed on centos 6.4 and ubuntu 14.04
>
>
> Thanks,
>
> Rajani Karuturi
>
>