You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by József Márton Jung <j....@levi9.com> on 2015/06/04 16:42:16 UTC

Review Request 35071: SAMZA-572 SamzaContainer checkpoints and windows immediately on startup

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35071/
-----------------------------------------------------------

Review request for samza.


Repository: samza


Description
-------

Fix for [SAMZA-572](https://issues.apache.org/jira/browse/SAMZA-572):

In RunLoop commit() and window() are called immediately on startup. This patch fixes the problem by setting the lastCommitMs and lastWindowMs to clock()


Diffs
-----

  samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala 4c0faf6 
  samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala 73ec2b5 

Diff: https://reviews.apache.org/r/35071/diff/


Testing
-------

Unit test added to verify that window() and commit() are not called immediately on startup.


Thanks,

József Márton Jung


Re: Review Request 35071: SAMZA-572 SamzaContainer checkpoints and windows immediately on startup

Posted by Navina Ramesh <nr...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35071/#review87507
-----------------------------------------------------------

Ship it!


lgtm!

- Navina Ramesh


On June 4, 2015, 2:42 p.m., József Márton Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35071/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 2:42 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Fix for [SAMZA-572](https://issues.apache.org/jira/browse/SAMZA-572):
> 
> In RunLoop commit() and window() are called immediately on startup. This patch fixes the problem by setting the lastCommitMs and lastWindowMs to clock()
> 
> 
> Diffs
> -----
> 
>   samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala 4c0faf6 
>   samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala 73ec2b5 
> 
> Diff: https://reviews.apache.org/r/35071/diff/
> 
> 
> Testing
> -------
> 
> Unit test added to verify that window() and commit() are not called immediately on startup.
> 
> 
> Thanks,
> 
> József Márton Jung
> 
>


Re: Review Request 35071: SAMZA-572 SamzaContainer checkpoints and windows immediately on startup

Posted by József Márton Jung <j....@levi9.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35071/
-----------------------------------------------------------

(Updated June 15, 2015, noon)


Review request for samza.


Repository: samza


Description
-------

Fix for [SAMZA-572](https://issues.apache.org/jira/browse/SAMZA-572):

In RunLoop commit() and window() are called immediately on startup. This patch fixes the problem by setting the lastCommitMs and lastWindowMs to clock()


Diffs (updated)
-----

  samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala e0c3e7e 
  samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala cec6477 

Diff: https://reviews.apache.org/r/35071/diff/


Testing
-------

Unit test added to verify that window() and commit() are not called immediately on startup.


Thanks,

József Márton Jung