You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/18 23:57:21 UTC

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #706: fix batchIdx error for non-batch message

cckellogg commented on a change in pull request #706:
URL: https://github.com/apache/pulsar-client-go/pull/706#discussion_r787243707



##########
File path: pulsar/consumer_partition.go
##########
@@ -596,7 +596,7 @@ func (pc *partitionConsumer) MessageReceived(response *pb.CommandMessage, header
 		msgID := newTrackingMessageID(
 			int64(pbMsgID.GetLedgerId()),
 			int64(pbMsgID.GetEntryId()),
-			int32(i),
+			pbMsgID.GetBatchIndex(),

Review comment:
       Could there be compatibility issues if users upgrade? Is this what the java client does too?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org