You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by Randgalt <gi...@git.apache.org> on 2016/03/07 15:17:13 UTC
[GitHub] curator pull request: [CURATOR-306] Background operations would be...
GitHub user Randgalt opened a pull request:
https://github.com/apache/curator/pull/139
[CURATOR-306] Background operations would benefit from an optional error handler
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/curator CURATOR-306
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/139.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #139
----
commit 4956fd9604d3188d58552001f1e8fea587bad810
Author: randgalt <ra...@apache.org>
Date: 2016-02-08T18:25:42Z
[maven-release-plugin] prepare release apache-curator-2.10.0
commit 71498909f940735b8b0c3c214f2f6ee83b9b555b
Author: randgalt <ra...@apache.org>
Date: 2016-02-08T18:25:54Z
[maven-release-plugin] prepare for next development iteration
commit c43116a28fd0737a05754f9db3f3c1eec36329b3
Author: randgalt <ra...@apache.org>
Date: 2016-02-10T13:54:11Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/curator
commit 72ce8563341e35966ed8eb753024adf052144070
Author: randgalt <ra...@apache.org>
Date: 2016-02-10T20:14:23Z
[maven-release-plugin] prepare release apache-curator-2.10.0
commit 18e912dc973f888526352b24db807708c547caa7
Author: randgalt <ra...@apache.org>
Date: 2016-02-10T20:14:36Z
[maven-release-plugin] prepare for next development iteration
commit 8499680187d1f1061ca8597886e9f869bf637321
Author: randgalt <ra...@apache.org>
Date: 2016-03-07T14:15:07Z
Added a method for background operations to intercept exeptions.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: [CURATOR-306] Background operations would be...
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the pull request:
https://github.com/apache/curator/pull/139#issuecomment-195074289
Yeah - I agree. Maybe we can start a discussion on Curator 4.0 and open it up to major refactoring.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: [CURATOR-306] Background operations would be...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/curator/pull/139
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: [CURATOR-306] Background operations would be...
Posted by cammckenzie <gi...@git.apache.org>.
Github user cammckenzie commented on the pull request:
https://github.com/apache/curator/pull/139#issuecomment-194051764
Looks good to me. It does make me appreciate how much duplicate code there is in all of the builder classes though. We should probably look at rationalising that at some point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---