[jira] [Commented] (CALCITE-746) Fix false positives when Apache RAT is run from outside maven

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201786#comment-15201786 ] 

Julian Hyde commented on CALCITE-746:
-------------------------------------

Add an exclusion for {{git.properties}} so that it succeeds on a source tarball.

Move the config from the apache-release profile build to the build section. Then people will pick up the exclusions if they run {{mvn apache-rat:check}} or {{mvn verify}} and don't remember to specify {{-Papache-release}}.

With these changes RAT can at least be run from inside maven, but insider or outside of the release process, which I think is good enough.

> Fix false positives when Apache RAT is run from outside maven
> -------------------------------------------------------------
>
>                 Key: CALCITE-746
>                 URL: https://issues.apache.org/jira/browse/CALCITE-746
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>             Fix For: 1.8.0
>
>
> In http://mail-archives.apache.org/mod_mbox/incubator-general/201505.mbox/%3C55654545.4090202%40apache.org%3E Brane wrote:
> {noformat}
>  RAT emits warnings:
> Files with unapproved licenses:
>   ./git.properties
>   ./avatica/src/main/resources/META-INF/services/java.sql.Driver
>   ./core/src/main/resources/META-INF/services/java.sql.Driver
>   ./example/csv/src/test/resources/bug/DATE.csv
>   ./example/csv/src/test/resources/bug/WACKY_COLUMN_NAMES.csv
>   ./example/csv/src/test/resources/bug/archers.json
>   ./example/csv/src/test/resources/sales/DEPTS.csv
> *****************************************************
> Archives:
>  + ./example/csv/src/test/resources/sales/EMPS.csv.gz
> These are clearly false positives, and I see that the pom.xml file
> contains exclusions for these files. I suggest also providing a
> rat-excludes file with the same exclusion rules, so that RAT can be run
> on the tree without going through maven (and trusting the pom.xml :).
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)