[GitHub] [ignite-3] denis-chudov commented on a diff in pull request #2329: IGNITE-15927 One-phase commit

["denis-chudov (via GitHub)" <gi...@apache.org>]

denis-chudov commented on code in PR #2329:
URL: https://github.com/apache/ignite-3/pull/2329#discussion_r1280660605


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/command/PartitionCommand.java:
##########
@@ -28,4 +28,9 @@ public interface PartitionCommand extends SafeTimePropagatingCommand {
      * Returns a transaction id.
      */
     UUID txId();
+
+    /**
+     * Returns {@code true} if a command represents a full transaction.
+     */
+    boolean full();

Review Comment:
   I agree with Alexander, first time I saw "full" I thought it means something like "full-process tx", which is quite opposite to actual meaning. Maybe "complete" would be better? Or at least you should explain it in javadoc, because it is really counter-intuitive.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org