[GitHub] eolivelli closed pull request #1371: Use isEmpty method instead of size check

[GitBox <gi...@apache.org>]

eolivelli closed pull request #1371: Use isEmpty method instead of size check
URL: https://github.com/apache/bookkeeper/pull/1371
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/ListLedgerService.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/ListLedgerService.java
index 1023d6b20..758af704f 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/ListLedgerService.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/ListLedgerService.java
@@ -142,13 +142,13 @@ public HttpServiceResponse handle(HttpServiceRequest request) throws Exception {
                         }
                     }
                     if (futures.size() >= LIST_LEDGER_BATCH_SIZE) {
-                        while (futures.size() > 0) {
+                        while (!futures.isEmpty()) {
                             ReadLedgerMetadataCallback cb = futures.remove(0);
                             keepLedgerMetadata(cb, output);
                         }
                     }
                 }
-                while (futures.size() > 0) {
+                while (!futures.isEmpty()) {
                     ReadLedgerMetadataCallback cb = futures.remove(0);
                     keepLedgerMetadata(cb, output);
                 }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services