You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Alanxtl (via GitHub)" <gi...@apache.org> on 2025/04/06 05:04:11 UTC
[I] CI: Update CI toolchain to go1.23 [dubbo-go]
Alanxtl opened a new issue, #2825:
URL: https://github.com/apache/dubbo-go/issues/2825
Currently, the go version of dubbogo uses go1.23, but CI and go.mod still denotes go1.20, result in fail of Integration Testing, also mentioned in [dubbogo#2821](https://github.com/apache/dubbo-go/pull/2821).

I tried to update go.mod to 1.23 and update golangci/golangci-lint-action to v7 and update config file version to v2. Following the update of [dubbo-go-samples#813](https://github.com/apache/dubbo-go-samples/pull/813)
This indeed solve the fail of Integration Testing. But result in static check fail.

To see what I've done and the static check error in detail, see [here](https://github.com/Alanxtl/dubbo-go/pull/1)
Should we fix the static check error or change the golangci-lint strategy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] CI: Update CI toolchain to go1.23 [dubbo-go]
Posted by "flypiggyyoyoyo (via GitHub)" <gi...@apache.org>.
flypiggyyoyoyo commented on issue #2825:
URL: https://github.com/apache/dubbo-go/issues/2825#issuecomment-2781255936
I will check the error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] CI: Update CI toolchain to go1.23 [dubbo-go]
Posted by "flypiggyyoyoyo (via GitHub)" <gi...@apache.org>.
flypiggyyoyoyo commented on issue #2825:
URL: https://github.com/apache/dubbo-go/issues/2825#issuecomment-2792039592
> Static check errors do exist (the version upgrade has exposed them), and declaring some exclusion rules might temporarily alleviate this issue?
Yes, it should be the stricter static check in the new version that discovered them. However, disabling static check directly in the new version feels inappropriate. I am seeking to review the previous version with less strict static checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] CI: Update CI toolchain to go1.23 [dubbo-go]
Posted by "flypiggyyoyoyo (via GitHub)" <gi...@apache.org>.
flypiggyyoyoyo commented on issue #2825:
URL: https://github.com/apache/dubbo-go/issues/2825#issuecomment-2792085973
It's a WeChat group. You add me as a friend, I'll pull you in. This is my WeChat ID: flypiggyyoyoyo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] CI: Update CI toolchain to go1.23 [dubbo-go]
Posted by "flypiggyyoyoyo (via GitHub)" <gi...@apache.org>.
flypiggyyoyoyo commented on issue #2825:
URL: https://github.com/apache/dubbo-go/issues/2825#issuecomment-2792063630
@Flying-Tom By the way, are you in the development group?Communicating in a group may be more convenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] CI: Update CI toolchain to go1.23 [dubbo-go]
Posted by "Flying-Tom (via GitHub)" <gi...@apache.org>.
Flying-Tom commented on issue #2825:
URL: https://github.com/apache/dubbo-go/issues/2825#issuecomment-2791986432
Static check errors do exist (the version upgrade has exposed them), and declaring some exclusion rules might temporarily alleviate this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] CI: Update CI toolchain to go1.23 [dubbo-go]
Posted by "flypiggyyoyoyo (via GitHub)" <gi...@apache.org>.
flypiggyyoyoyo commented on issue #2825:
URL: https://github.com/apache/dubbo-go/issues/2825#issuecomment-2781258367
plz assign to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] CI: Update CI toolchain to go1.23 [dubbo-go]
Posted by "flypiggyyoyoyo (via GitHub)" <gi...@apache.org>.
flypiggyyoyoyo commented on issue #2825:
URL: https://github.com/apache/dubbo-go/issues/2825#issuecomment-2783693370
I suspected it was a problem with the "disable" before. After verification, both of these versions have disabled the style checks (such as gocritic).This is a bit strange. I will continue to follow up on this. Sorry about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] CI: Update CI toolchain to go1.23 [dubbo-go]
Posted by "FoghostCn (via GitHub)" <gi...@apache.org>.
FoghostCn closed issue #2825: CI: Update CI toolchain to go1.23
URL: https://github.com/apache/dubbo-go/issues/2825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] CI: Update CI toolchain to go1.23 [dubbo-go]
Posted by "Flying-Tom (via GitHub)" <gi...@apache.org>.
Flying-Tom commented on issue #2825:
URL: https://github.com/apache/dubbo-go/issues/2825#issuecomment-2792080512
> [@Flying-Tom](https://github.com/Flying-Tom) By the way, are you in the development group?Communicating in a group may be more convenient.
Developer group in Discord or DingTalk?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org