You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2010/07/13 03:30:52 UTC

DO NOT REPLY [Bug 49589] New: Tag handlers with constant attribute values are always reinitialized

https://issues.apache.org/bugzilla/show_bug.cgi?id=49589

           Summary: Tag handlers with constant attribute values are always
                    reinitialized
           Product: Tomcat 7
           Version: trunk
          Platform: PC
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Jasper
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: jboynes@apache.org


Tags such as the JSTL <x:out> tag that have idempotent attribute values are
being reinitialized before use. The specification allows the container to pool
and reuse tags with the same attribute values, calling them multiple times
without reinitializing the values. However, the code generated by Jasper always
sets the attribute values after retrieving an instance from the pool even if
they have constant values.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 49589] Tag handlers with constant attribute values are always reinitialized

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49589

--- Comment #3 from Mark Thomas <ma...@apache.org> 2012-01-22 19:45:04 UTC ---
I'm leaning towards marking this as WONTFIX. Trying to write the code to do
this even for simple cases looks like it will increase the complexity of the
generation code significantly.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 49589] Tag handlers with constant attribute values are always reinitialized

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49589

--- Comment #2 from Jeremy Boynes <jb...@apache.org> 2010-07-12 21:35:05 EDT ---
Created an attachment (id=25758)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25758)
Java source generated by Jasper <jspc> ant task

Relevant snippet from end

//  x:out
    org.apache.taglibs.standard.tag.rt.xml.ExprTag _jspx_th_x_005fout_005f0 =
(org.apache.taglibs.standard.tag.rt.xml.ExprTag)
_005fjspx_005ftagPool_005fx_005fout_0026_005fselect_005fnobody.get(org.apache.taglibs.standard.tag.rt.xml.ExprTag.class);
    _jspx_th_x_005fout_005f0.setPageContext(_jspx_page_context);
    _jspx_th_x_005fout_005f0.setParent((javax.servlet.jsp.tagext.Tag)
_jspx_th_x_005fforEach_005f0);
    //
/org/apache/taglibs/standard/tag/el/xml/TestForEachPerformance.jsp(24,67) name
= select type = java.lang.String reqTime = false required = true fragment =
false deferredValue = false expectedTypeName = null deferredMethod = false
methodSignature = null
    _jspx_th_x_005fout_005f0.setSelect("y");
    int _jspx_eval_x_005fout_005f0 = _jspx_th_x_005fout_005f0.doStartTag();

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 49589] Tag handlers with constant attribute values are always reinitialized

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49589

--- Comment #1 from Jeremy Boynes <jb...@apache.org> 2010-07-12 21:33:02 EDT ---
Created an attachment (id=25757)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25757)
Test JSP

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org