You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/04/18 20:21:48 UTC

[Impala-ASF-CR] IMPALA-6868: [DOCS] Removed kerberos reinit interval flag 

Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10103


Change subject: IMPALA-6868: [DOCS] Removed kerberos_reinit_interval flag
......................................................................

IMPALA-6868: [DOCS] Removed kerberos_reinit_interval flag

Change-Id: If04c6cf73d92562b6a236ce244b8d499a0d91949
Cherry-picks: not for 2.x.
---
M docs/topics/impala_kerberos.xml
M docs/topics/impala_scalability.xml
2 files changed, 0 insertions(+), 23 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/10103/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If04c6cf73d92562b6a236ce244b8d499a0d91949
Gerrit-Change-Number: 10103
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>

[Impala-ASF-CR] IMPALA-6868: [DOCS] Removed kerberos reinit interval flag

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Sailesh Mukil, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10103

to look at the new patch set (#3).

Change subject: IMPALA-6868: [DOCS] Removed kerberos_reinit_interval flag
......................................................................

IMPALA-6868: [DOCS] Removed kerberos_reinit_interval flag

Change-Id: If04c6cf73d92562b6a236ce244b8d499a0d91949
Cherry-picks: not for 2.x.
---
M docs/topics/impala_kerberos.xml
M docs/topics/impala_scalability.xml
2 files changed, 11 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/10103/3
-- 
To view, visit http://gerrit.cloudera.org:8080/10103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If04c6cf73d92562b6a236ce244b8d499a0d91949
Gerrit-Change-Number: 10103
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-6868: [DOCS] Removed kerberos reinit interval flag

Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10103 )

Change subject: IMPALA-6868: [DOCS] Removed kerberos_reinit_interval flag
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10103/1/docs/topics/impala_scalability.xml
File docs/topics/impala_scalability.xml:

http://gerrit.cloudera.org:8080/#/c/10103/1/docs/topics/impala_scalability.xml@965
PS1, Line 965: 
Can we add a note saying that the 'kerberos_reinit_flag' is deprecated and add something like the following?

'kerberos_reinit_interval' is no longer needed to determine when to re-authenticate with the KDC. Impala now automatically detects the ticket lifetime from the kerberos configuration file and re-authenticates accordingly.

Else users might get confused as to why the flag disappeared suddenly.

We can remove this note after a couple more releases.



-- 
To view, visit http://gerrit.cloudera.org:8080/10103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If04c6cf73d92562b6a236ce244b8d499a0d91949
Gerrit-Change-Number: 10103
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Apr 2018 20:54:25 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6868: [DOCS] Removed kerberos reinit interval flag

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10103 )

Change subject: IMPALA-6868: [DOCS] Removed kerberos_reinit_interval flag
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If04c6cf73d92562b6a236ce244b8d499a0d91949
Gerrit-Change-Number: 10103
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 01:15:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6868: [DOCS] Removed kerberos reinit interval flag

Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10103 )

Change subject: IMPALA-6868: [DOCS] Removed kerberos_reinit_interval flag
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

LGTM, just one more small comment.

http://gerrit.cloudera.org:8080/#/c/10103/2/docs/topics/impala_scalability.xml
File docs/topics/impala_scalability.xml:

http://gerrit.cloudera.org:8080/#/c/10103/2/docs/topics/impala_scalability.xml@973
PS2, Line 973: The <codeph>kerberos_reinit_interval</codeph>
The kerberos_reinit_interval configuration setting is removed...



-- 
To view, visit http://gerrit.cloudera.org:8080/10103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If04c6cf73d92562b6a236ce244b8d499a0d91949
Gerrit-Change-Number: 10103
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Apr 2018 23:25:54 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6868: [DOCS] Removed kerberos reinit interval flag

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Sailesh Mukil, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10103

to look at the new patch set (#2).

Change subject: IMPALA-6868: [DOCS] Removed kerberos_reinit_interval flag
......................................................................

IMPALA-6868: [DOCS] Removed kerberos_reinit_interval flag

Change-Id: If04c6cf73d92562b6a236ce244b8d499a0d91949
Cherry-picks: not for 2.x.
---
M docs/topics/impala_kerberos.xml
M docs/topics/impala_scalability.xml
2 files changed, 11 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/10103/2
-- 
To view, visit http://gerrit.cloudera.org:8080/10103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If04c6cf73d92562b6a236ce244b8d499a0d91949
Gerrit-Change-Number: 10103
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-6868: [DOCS] Removed kerberos reinit interval flag

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10103 )

Change subject: IMPALA-6868: [DOCS] Removed kerberos_reinit_interval flag
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/10103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If04c6cf73d92562b6a236ce244b8d499a0d91949
Gerrit-Change-Number: 10103
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 01:26:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6868: [DOCS] Removed kerberos reinit interval flag

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10103 )

Change subject: IMPALA-6868: [DOCS] Removed kerberos_reinit_interval flag
......................................................................

IMPALA-6868: [DOCS] Removed kerberos_reinit_interval flag

Change-Id: If04c6cf73d92562b6a236ce244b8d499a0d91949
Cherry-picks: not for 2.x.
Reviewed-on: http://gerrit.cloudera.org:8080/10103
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_kerberos.xml
M docs/topics/impala_scalability.xml
2 files changed, 11 insertions(+), 23 deletions(-)

Approvals:
  Alex Rodoni: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/10103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If04c6cf73d92562b6a236ce244b8d499a0d91949
Gerrit-Change-Number: 10103
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-6868: [DOCS] Removed kerberos reinit interval flag

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10103 )

Change subject: IMPALA-6868: [DOCS] Removed kerberos_reinit_interval flag
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10103/2/docs/topics/impala_scalability.xml
File docs/topics/impala_scalability.xml:

http://gerrit.cloudera.org:8080/#/c/10103/2/docs/topics/impala_scalability.xml@973
PS2, Line 973: The <codeph>kerberos_reinit_interval</codeph>
> The kerberos_reinit_interval configuration setting is removed...
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/10103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If04c6cf73d92562b6a236ce244b8d499a0d91949
Gerrit-Change-Number: 10103
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 01:14:04 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6868: [DOCS] Removed kerberos reinit interval flag

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10103 )

Change subject: IMPALA-6868: [DOCS] Removed kerberos_reinit_interval flag
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10103/1/docs/topics/impala_scalability.xml
File docs/topics/impala_scalability.xml:

http://gerrit.cloudera.org:8080/#/c/10103/1/docs/topics/impala_scalability.xml@965
PS1, Line 965: 
> Can we add a note saying that the 'kerberos_reinit_flag' is deprecated and 
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/10103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If04c6cf73d92562b6a236ce244b8d499a0d91949
Gerrit-Change-Number: 10103
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Apr 2018 23:18:16 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6868: [DOCS] Removed kerberos reinit interval flag

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10103 )

Change subject: IMPALA-6868: [DOCS] Removed kerberos_reinit_interval flag
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/248/


-- 
To view, visit http://gerrit.cloudera.org:8080/10103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If04c6cf73d92562b6a236ce244b8d499a0d91949
Gerrit-Change-Number: 10103
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 01:15:18 +0000
Gerrit-HasComments: No