You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ks...@apache.org on 2019/02/17 12:40:51 UTC
[arrow] branch master updated: PARQUET-1532: [C++] Fix build error
with MinGW
This is an automated email from the ASF dual-hosted git repository.
kszucs pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 3f3da9d PARQUET-1532: [C++] Fix build error with MinGW
3f3da9d is described below
commit 3f3da9d6ecad8c2dbae22dee3919903d3bb84736
Author: Kouhei Sutou <ko...@clear-code.com>
AuthorDate: Sun Feb 17 13:40:31 2019 +0100
PARQUET-1532: [C++] Fix build error with MinGW
Error message:
In file included from C:/msys64/mingw64/include/thrift/TApplicationException.h:23,
from C:/Users/kou/work/arrow/arrow.kou/cpp/src/parquet/thrift.h:35,
from C:/Users/kou/work/arrow/arrow.kou/cpp/src/parquet/column_reader.cc:36:
C:/msys64/mingw64/include/thrift/Thrift.h:32:10: fatal error: netinet/in.h: No such file or directory
#include <netinet/in.h>
^~~~~~~~~~~~~~
Author: Kouhei Sutou <ko...@clear-code.com>
Closes #3676 from kou/cpp-parquet-fix-build-error-with-mingw and squashes the following commits:
248063c6 <Kouhei Sutou> Fix build error with MinGW
---
cpp/src/parquet/CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cpp/src/parquet/CMakeLists.txt b/cpp/src/parquet/CMakeLists.txt
index c195b92..2626966 100644
--- a/cpp/src/parquet/CMakeLists.txt
+++ b/cpp/src/parquet/CMakeLists.txt
@@ -248,7 +248,7 @@ foreach(LIB_TARGET ${PARQUET_LIBRARIES})
HAVE_INTTYPES_H
PRIVATE
HAVE_NETDB_H)
- if(MSVC)
+ if(WIN32)
target_compile_definitions(${LIB_TARGET} PRIVATE NOMINMAX)
else()
target_compile_definitions(${LIB_TARGET} PRIVATE HAVE_NETINET_IN_H)