You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "shawnh2 (via GitHub)" <gi...@apache.org> on 2023/06/04 11:08:50 UTC
[GitHub] [dubbo-go-pixiu] shawnh2 opened a new pull request, #565: feat: add support for header based route
shawnh2 opened a new pull request, #565:
URL: https://github.com/apache/dubbo-go-pixiu/pull/565
增加 header 路由的支持
- 路由中单独使用 header 时，正则表达式生效，并优先匹配所有只带有 header 的路由
- prefix 和 header 可以混用，此时只有既命中 prefix 又命中 header 时才会匹配该路由，但 header 的正则表达式此时不生效
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on pull request #565: feat: add support for header based route
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on PR #565:
URL: https://github.com/apache/dubbo-go-pixiu/pull/565#issuecomment-1596124980
@yqxu review this pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] sonarcloud[bot] commented on pull request #565: feat: add support for header based route
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #565:
URL: https://github.com/apache/dubbo-go-pixiu/pull/565#issuecomment-1612554643
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=565)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=565) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=565&metric=new_duplicated_lines_density&view=list) [1.7% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=565&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z commented on a diff in pull request #565: feat: add support for header based route
Posted by "mark4z (via GitHub)" <gi...@apache.org>.
mark4z commented on code in PR #565:
URL: https://github.com/apache/dubbo-go-pixiu/pull/565#discussion_r1225720827
##########
pixiu/pkg/common/router/router.go:
##########
@@ -83,6 +114,21 @@ func (rm *RouterCoordinator) initTrie() {
}
}
+func (rm *RouterCoordinator) initRegex() {
+ for _, router := range rm.activeConfig.Routes {
+ headers := router.Match.Headers
+ for i := range headers {
+ if headers[i].Regex && len(headers[i].Values) > 0 {
+ // regexp always use first value of header
+ err := headers[i].SetValueRegex(headers[i].Values[0])
+ if err != nil {
+ logger.Errorf("invalid regexp in headers[%d]: %v", i, err)
Review Comment:
Shouldn't it be panic here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] shawnh2 commented on pull request #565: feat: add support for header based route
Posted by "shawnh2 (via GitHub)" <gi...@apache.org>.
shawnh2 commented on PR #565:
URL: https://github.com/apache/dubbo-go-pixiu/pull/565#issuecomment-1594691107
> 考虑扩展下现有的samples来演示如何使用header路由
sample has been added, https://github.com/apache/dubbo-go-pixiu-samples/pull/30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] yqxu commented on a diff in pull request #565: feat: add support for header based route
Posted by "yqxu (via GitHub)" <gi...@apache.org>.
yqxu commented on code in PR #565:
URL: https://github.com/apache/dubbo-go-pixiu/pull/565#discussion_r1233274019
##########
pixiu/pkg/model/router.go:
##########
@@ -75,22 +75,83 @@ func NewRouterMatchPrefix(name string) RouterMatch {
return RouterMatch{Prefix: "/" + name + "/"}
}
-func (rc *RouteConfiguration) RouteByPathAndMethod(path, method string) (*RouteAction, error) {
+func (rc *RouteConfiguration) RouteByPathAndMethod(path, method string, header stdHttp.Header) (*RouteAction, error) {
Review Comment:
The behavior of a method should be reflected in its name. It is recommended to modify the name as RouteByPathAndMethodAndHeader.
##########
pixiu/pkg/common/router/trie/trie.go:
##########
@@ -333,13 +355,14 @@ func (node *Node) putNode(matchStr string, isReal bool, bizInfo interface{}) boo
if isReal {
selfNode.bizInfo = bizInfo
+ selfNode.header = header
Review Comment:
The "header" should be an attribute of "bizInfo".
##########
pixiu/pkg/common/router/trie/trie.go:
##########
@@ -317,7 +339,7 @@ func (node *Node) putPathVariable(pathVariable string, isReal bool, bizInfo inte
return true
}
-func (node *Node) putNode(matchStr string, isReal bool, bizInfo interface{}) bool {
+func (node *Node) putNode(matchStr string, isReal bool, bizInfo interface{}, header map[string][]string) bool {
Review Comment:
The "header" should be an attribute of "bizInfo".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] sonarcloud[bot] commented on pull request #565: feat: add support for header based route
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #565:
URL: https://github.com/apache/dubbo-go-pixiu/pull/565#issuecomment-1575524390
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=565)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=565) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=565&metric=new_duplicated_lines_density&view=list) [2.8% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=565&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] sonarcloud[bot] commented on pull request #565: feat: add support for header based route
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #565:
URL: https://github.com/apache/dubbo-go-pixiu/pull/565#issuecomment-1594635154
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=565)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=565) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=565&metric=new_duplicated_lines_density&view=list) [2.8% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=565&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z commented on pull request #565: feat: add support for header based route
Posted by "mark4z (via GitHub)" <gi...@apache.org>.
mark4z commented on PR #565:
URL: https://github.com/apache/dubbo-go-pixiu/pull/565#issuecomment-1586037457
Good job!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #565: feat: add support for header based route
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #565:
URL: https://github.com/apache/dubbo-go-pixiu/pull/565#issuecomment-1595776117
## [Codecov](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#565](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9288b90) into [develop](https://app.codecov.io/gh/apache/dubbo-go-pixiu/commit/613998aea45a874c9bab438d8c5ac887680a9d15?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (613998a) will **increase** coverage by `0.02%`.
> The diff coverage is `66.66%`.
> :exclamation: Current head 9288b90 differs from pull request most recent head d009c5f. Consider uploading reports for the commit d009c5f to get more accurate results
```diff
@@ Coverage Diff @@
## develop #565 +/- ##
===========================================
+ Coverage 54.76% 54.79% +0.02%
===========================================
Files 669 669
Lines 78297 78331 +34
===========================================
+ Hits 42882 42918 +36
- Misses 31756 31757 +1
+ Partials 3659 3656 -3
```
| [Impacted Files](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [pixiu/pkg/server/http.go](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGl4aXUvcGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pixiu/pkg/router/route.go](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGl4aXUvcGtnL3JvdXRlci9yb3V0ZS5nbw==) | `45.73% <50.00%> (ø)` | |
| [pixiu/pkg/common/router/trie/trie.go](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGl4aXUvcGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `72.30% <55.17%> (-3.11%)` | :arrow_down: |
| [pixiu/pkg/common/router/router.go](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGl4aXUvcGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `82.19% <84.00%> (+13.56%)` | :arrow_up: |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/565/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks merged pull request #565: feat: add support for header based route
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks merged PR #565:
URL: https://github.com/apache/dubbo-go-pixiu/pull/565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] sonarcloud[bot] commented on pull request #565: feat: add support for header based route
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #565:
URL: https://github.com/apache/dubbo-go-pixiu/pull/565#issuecomment-1580427440
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=565)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=565) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=565&metric=new_duplicated_lines_density&view=list) [2.8% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=565&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z commented on pull request #565: feat: add support for header based route
Posted by "mark4z (via GitHub)" <gi...@apache.org>.
mark4z commented on PR #565:
URL: https://github.com/apache/dubbo-go-pixiu/pull/565#issuecomment-1586037423
考虑扩展下现有的samples来演示如何使用header路由
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] shawnh2 commented on a diff in pull request #565: feat: add support for header based route
Posted by "shawnh2 (via GitHub)" <gi...@apache.org>.
shawnh2 commented on code in PR #565:
URL: https://github.com/apache/dubbo-go-pixiu/pull/565#discussion_r1232217772
##########
pixiu/pkg/common/router/router.go:
##########
@@ -83,6 +114,21 @@ func (rm *RouterCoordinator) initTrie() {
}
}
+func (rm *RouterCoordinator) initRegex() {
+ for _, router := range rm.activeConfig.Routes {
+ headers := router.Match.Headers
+ for i := range headers {
+ if headers[i].Regex && len(headers[i].Values) > 0 {
+ // regexp always use first value of header
+ err := headers[i].SetValueRegex(headers[i].Values[0])
+ if err != nil {
+ logger.Errorf("invalid regexp in headers[%d]: %v", i, err)
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] sonarcloud[bot] commented on pull request #565: feat: add support for header based route
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #565:
URL: https://github.com/apache/dubbo-go-pixiu/pull/565#issuecomment-1604018481
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=565)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=565&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=565) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=565&metric=new_duplicated_lines_density&view=list) [1.6% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=565&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org