[jira] [Commented] (GEODE-4080) Improve JSON encoding for new protocol

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292997#comment-16292997 ] 

ASF GitHub Bot commented on GEODE-4080:
---------------------------------------

galen-pivotal opened a new pull request #1171: GEODE-4080: Protobuf JSON objects are in a proto string
URL: https://github.com/apache/geode/pull/1171
 
 
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [x] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improve JSON encoding for new protocol
> --------------------------------------
>
>                 Key: GEODE-4080
>                 URL: https://issues.apache.org/jira/browse/GEODE-4080
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: Galen O'Sullivan
>
> One of the encoding types in the new protobuf protocol is called {{CustomEncodedValue}}. However, users aren't really free to encode their own types. Also, packing JSON into a byte array is going to be harder for users than just sending ti as a string. Let's make the JSON type a string and put the custom value type in later when we actually have support for custom encoding.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)