You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/02/24 14:04:45 UTC
[GitHub] [incubator-inlong] imvan opened a new pull request #2709: [INLONG-2693][Feature][Manager] Define tables and beans for getSortSource interface
imvan opened a new pull request #2709:
URL: https://github.com/apache/incubator-inlong/pull/2709
### Title Name: [INLONG-2693][Feature][Manager] Define tables and beans for getSortSource interface
Fixes #2693
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] kipshi commented on a change in pull request #2709: [INLONG-2693][Manager] Define tables and beans for getSortSource interface
Posted by GitBox <gi...@apache.org>.
kipshi commented on a change in pull request #2709:
URL: https://github.com/apache/incubator-inlong/pull/2709#discussion_r815558869
##########
File path: inlong-manager/manager-web/sql/apache_inlong_manager.sql
##########
@@ -1123,6 +1123,52 @@ CREATE TABLE `sort_task_sink_param`
) ENGINE = InnoDB
DEFAULT CHARSET = utf8mb4 COMMENT ='Sort task sink params table';
+-- ----------------------------
+-- Table structure for sort_source_config
+-- ----------------------------
+DROP TABLE IF EXISTS `sort_source_config`;
+CREATE TABLE `sort_source_config`
+(
+ `id` int(11) NOT NULL AUTO_INCREMENT COMMENT 'Incremental primary key',
+ `cluster_name` varchar(128) NOT NULL COMMENT 'Cluster name',
+ `task_name` varchar(128) NOT NULL COMMENT 'Task name',
+ `zone_name` varchar(128) NOT NULL COMMENT 'Cache zone name',
+ PRIMARY KEY (`id`),
+ KEY `index_sort_source_config` (`cluster_name`, `task_name`)
+) ENGINE = InnoDB
+ DEFAULT CHARSET = utf8mb4 COMMENT ='Sort source config table';
Review comment:
All three tables cannot be designed as one table? If you need to design more abstract and reasonable than simple CRUD .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] imvan commented on a change in pull request #2709: [INLONG-2693][Manager] Define tables and beans for getSortSource interface
Posted by GitBox <gi...@apache.org>.
imvan commented on a change in pull request #2709:
URL: https://github.com/apache/incubator-inlong/pull/2709#discussion_r815632512
##########
File path: inlong-manager/manager-web/sql/apache_inlong_manager.sql
##########
@@ -1123,6 +1123,52 @@ CREATE TABLE `sort_task_sink_param`
) ENGINE = InnoDB
DEFAULT CHARSET = utf8mb4 COMMENT ='Sort task sink params table';
+-- ----------------------------
+-- Table structure for sort_source_config
+-- ----------------------------
+DROP TABLE IF EXISTS `sort_source_config`;
+CREATE TABLE `sort_source_config`
+(
+ `id` int(11) NOT NULL AUTO_INCREMENT COMMENT 'Incremental primary key',
+ `cluster_name` varchar(128) NOT NULL COMMENT 'Cluster name',
+ `task_name` varchar(128) NOT NULL COMMENT 'Task name',
+ `zone_name` varchar(128) NOT NULL COMMENT 'Cache zone name',
+ PRIMARY KEY (`id`),
+ KEY `index_sort_source_config` (`cluster_name`, `task_name`)
+) ENGINE = InnoDB
+ DEFAULT CHARSET = utf8mb4 COMMENT ='Sort source config table';
Review comment:
has redesigned the structure of table. use one table instead of three
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on pull request #2709: [INLONG-2693][Feature][Manager] Define tables and beans for getSortSource interface
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #2709:
URL: https://github.com/apache/incubator-inlong/pull/2709#issuecomment-1053753138
@healchow @kipshi PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #2709: [INLONG-2693][Manager] Define tables and beans for getSortSource interface
Posted by GitBox <gi...@apache.org>.
healchow merged pull request #2709:
URL: https://github.com/apache/incubator-inlong/pull/2709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org