[GitHub] [doris] yiguolei commented on a diff in pull request #11353: [fix] fix compile error: missing libbrpc.a

[GitBox <gi...@apache.org>]

yiguolei commented on code in PR #11353:
URL: https://github.com/apache/doris/pull/11353#discussion_r933797943


##########
thirdparty/build-thirdparty.sh:
##########
@@ -345,7 +345,7 @@ build_protobuf() {
         ldflags="-L${TP_LIB_DIR} -static-libstdc++ -static-libgcc -Wl,--undefined=pthread_create"
     fi
 
-    CXXFLAGS="-O2 -I${TP_INCLUDE_DIR}" \
+    CXXFLAGS="-fPIC -O2 -I${TP_INCLUDE_DIR}" \

Review Comment:
   why add -fPIC here? I find pxl do remove it few days ago.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org