[GitHub] [pinot] agavra commented on a diff in pull request #9630: [multistage] [debugability] Support explain distributed stage plan and add a test for explicit distinct

[GitBox <gi...@apache.org>]

agavra commented on code in PR #9630:
URL: https://github.com/apache/pinot/pull/9630#discussion_r1006088327


##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/ExplainPlanStageVisitor.java:
##########
@@ -44,7 +44,7 @@
  */
 public class ExplainPlanStageVisitor implements StageNodeVisitor<StringBuilder, ExplainPlanStageVisitor.Context> {
 
-  private final QueryPlan _queryPlan;

Review Comment:
   context on Rong's comment: it's important to note that the distributed plan doesn't include the mailbox_receiver -> sender information, which makes the traversal "break". (note that `_sender` is `transient` under `MailboxReceiveNode`)
   
   otherwise I agree that having this is helpful



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org