You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by "liubao68 (via GitHub)" <gi...@apache.org> on 2025/05/16 14:43:46 UTC

Re: [PR] [#4813] Adjust the log information about scheduled tasks and limiting to improve product experience [servicecomb-java-chassis]

liubao68 commented on code in PR #4814:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4814#discussion_r2092620179


##########
clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/ServiceCenterClient.java:
##########
@@ -250,6 +250,12 @@ public FindMicroserviceInstancesResponse findMicroserviceInstance(String consume
         result.setModified(false);
         return result;
       }
+      if (response.getStatusCode() == HttpStatus.SC_TOO_MANY_REQUESTS) {
+        LOGGER.warn("rate limited, keep the local service {}#{} instance cache unchanged, if there has invoking error, "
+            + "contact the platform for handling", appId, serviceName);

Review Comment:
   how to "contact the platform" ?



##########
clients/config-kie-client/src/main/java/org/apache/servicecomb/config/kie/client/KieConfigManager.java:
##########
@@ -156,7 +156,8 @@ public void execute() {
               new PollConfigurationTask(0, this.configurationsRequest)));
         }
       } catch (Exception e) {
-        LOGGER.error("get configurations from KieConfigCenter failed, and will try again.", e);
+        LOGGER.warn("get configurations from KieConfigCenter failed, and will try again, cause message: {}. Special "
+            + "tips, current fail does not affect the obtained historical configuration.", e.getCause().getMessage());

Review Comment:
   I'd prefer remove `Special tips`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org