You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2016/04/29 15:31:01 UTC

Review Request 46832: Fixed the CMake build.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46832/
-----------------------------------------------------------

Review request for mesos and Bernd Mathiske.


Repository: mesos


Description
-------

CMake builds failed to compile under Linux because of a missing include.
This was due to a typo in 'src/CMakeLists.txt', resulting in
'state.pb.h' not being created.


Diffs
-----

  src/CMakeLists.txt f991743f1a467f24a786e925983390a411792327 

Diff: https://reviews.apache.org/r/46832/diff/


Testing
-------

mkdir build && cd build && cmake .. && make (with Fedora 23)


Thanks,

Jan Schlicht


Re: Review Request 46832: Fixed the CMake build.

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46832/#review131091
-----------------------------------------------------------


Ship it!




Ship It!

- Bernd Mathiske


On April 29, 2016, 6:31 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46832/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 6:31 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake builds failed to compile under Linux because of a missing include.
> This was due to a typo in 'src/CMakeLists.txt', resulting in
> 'state.pb.h' not being created.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt f991743f1a467f24a786e925983390a411792327 
> 
> Diff: https://reviews.apache.org/r/46832/diff/
> 
> 
> Testing
> -------
> 
> mkdir build && cd build && cmake .. && make (with Fedora 23)
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>