[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #11988: [Java Client] Make Audience Field Optional in OAuth2 Client Credentials

[GitBox <gi...@apache.org>]

michaeljmarshall commented on code in PR #11988:
URL: https://github.com/apache/pulsar/pull/11988#discussion_r897316881


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/auth/oauth2/protocol/TokenClient.java:
##########
@@ -73,10 +73,21 @@ public void close() throws Exception {
 
     /**
      * Constructing http request parameters.
-     * @param bodyMap List of parameters to be requested.
+     * @param req object with relevant request parameters
      * @return Generate the final request body from a map.
      */
-    String buildClientCredentialsBody(Map<String, String> bodyMap) {
+    String buildClientCredentialsBody(ClientCredentialsExchangeRequest req) {
+        Map<String, String> bodyMap = new TreeMap<>();

Review Comment:
   It's only a `TreeMap` because I copied it from `exchangeClientCredentials`. I don't remember any specific reason for using this data structure.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org