[GitHub] [iotdb] wangchao316 commented on a change in pull request #4580: [IOTDB-2111] ClusterServiceProvider: Support MQTT / REST protocols in cluster mode

[GitBox <gi...@apache.org>]

wangchao316 commented on a change in pull request #4580:
URL: https://github.com/apache/iotdb/pull/4580#discussion_r770161822



##########
File path: server/src/main/java/org/apache/iotdb/db/service/thrift/impl/TSServiceImpl.java
##########
@@ -155,14 +155,15 @@
 import java.util.Set;
 import java.util.stream.Collectors;
 
+import static org.apache.iotdb.db.service.basic.ServiceProvider.*;

Review comment:
       do not *

##########
File path: server/src/main/java/org/apache/iotdb/db/service/basic/ServiceProvider.java
##########
@@ -61,40 +59,55 @@
 
 import static org.apache.iotdb.db.utils.ErrorHandlingUtils.onNPEOrUnexpectedException;
 
-public class BasicServiceProvider {
+public abstract class ServiceProvider {
 
-  private static final Logger LOGGER = LoggerFactory.getLogger(BasicServiceProvider.class);
-  protected static final Logger AUDIT_LOGGER =
+  private static final Logger LOGGER = LoggerFactory.getLogger(ServiceProvider.class);
+  public static final Logger AUDIT_LOGGER =
       LoggerFactory.getLogger(IoTDBConstant.AUDIT_LOGGER_NAME);
-  protected static final Logger SLOW_SQL_LOGGER =
+  public static final Logger SLOW_SQL_LOGGER =
       LoggerFactory.getLogger(IoTDBConstant.SLOW_SQL_LOGGER_NAME);
 
-  protected static final TSProtocolVersion CURRENT_RPC_VERSION =
+  public static final TSProtocolVersion CURRENT_RPC_VERSION =
       TSProtocolVersion.IOTDB_SERVICE_PROTOCOL_V3;
 
-  protected static final IoTDBConfig CONFIG = IoTDBDescriptor.getInstance().getConfig();
+  public static final IoTDBConfig CONFIG = IoTDBDescriptor.getInstance().getConfig();
+
+  public static final QueryTimeManager QUERY_TIME_MANAGER = QueryTimeManager.getInstance();
+  public static final TracingManager TRACING_MANAGER = TracingManager.getInstance();
+  public static final QueryFrequencyRecorder QUERY_FREQUENCY_RECORDER =
+      new QueryFrequencyRecorder(CONFIG);
 
-  protected final QueryTimeManager queryTimeManager = QueryTimeManager.getInstance();
-  public static SessionManager sessionManager = SessionManager.getInstance();
-  protected final TracingManager tracingManager = TracingManager.getInstance();
-  protected final QueryFrequencyRecorder queryFrequencyRecorder;
+  public static SessionManager SESSION_MANAGER = SessionManager.getInstance();
 

Review comment:
       why static object?   generate "final" use "SESSION_MANAGER".

##########
File path: server/src/main/java/org/apache/iotdb/db/service/thrift/impl/InfluxDBServiceImpl.java
##########
@@ -30,8 +30,9 @@
 import org.apache.iotdb.db.qp.physical.PhysicalPlan;
 import org.apache.iotdb.db.qp.physical.crud.InsertRowPlan;
 import org.apache.iotdb.db.qp.physical.sys.SetStorageGroupPlan;
+import org.apache.iotdb.db.service.IoTDB;
 import org.apache.iotdb.db.service.basic.BasicOpenSessionResp;
-import org.apache.iotdb.db.service.basic.BasicServiceProvider;
+import org.apache.iotdb.db.service.basic.ServiceProvider;
 import org.apache.iotdb.db.utils.DataTypeUtils;
 import org.apache.iotdb.protocol.influxdb.rpc.thrift.*;

Review comment:
       does not *




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org